Fix blocker sonar issue in sli/core
authorParshad Patel <pars.patel@samsung.com>
Wed, 7 Nov 2018 06:58:19 +0000 (15:58 +0900)
committerParshad Patel <pars.patel@samsung.com>
Mon, 19 Nov 2018 06:28:50 +0000 (15:28 +0900)
Fix use try with resources issue in FileRecorder.java

Issue-ID: CCSDK-647
Change-Id: Ibe8afb5873b3af681def5310cc53ea0172608f1a
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
sli/recording/src/main/java/org/onap/ccsdk/sli/core/sli/recording/FileRecorder.java

index 772906e..ac3dbd2 100644 (file)
@@ -82,7 +82,6 @@ public class FileRecorder implements SvcLogicRecorder {
                }
                
                File recordFile = new File(fileName);
-               FileWriter fileWriter = null;
                Date now = new Date();
 
                TimeZone tz = TimeZone.getTimeZone("UTC");
@@ -93,8 +92,8 @@ public class FileRecorder implements SvcLogicRecorder {
                        record = record.replaceFirst("__TIMESTAMP__", dateFmt.format(now));
                }
                
-               try ( PrintWriter recPrinter = new PrintWriter(fileWriter = new
-                               FileWriter(recordFile, true)))
+               try ( FileWriter fileWriter = new FileWriter(recordFile, true);
+                       PrintWriter recPrinter = new PrintWriter(fileWriter))
                {
                        recPrinter.println(record);
                }
@@ -102,19 +101,6 @@ public class FileRecorder implements SvcLogicRecorder {
                {
                        throw new SvcLogicException("Cannot write record to file", e);
                }
-               finally
-               {
-                       if (fileWriter != null)
-                       {
-                               try {
-                                       fileWriter.close();
-                               } catch (IOException e) {
-
-                               }
-                       }
-               }
-               
-               
        }
 
 }