sonar fix:Exception handling in emsdriver 23/36923/1
authorajay priyadarshi <ajay.priyadarshi@ril.com>
Tue, 20 Mar 2018 05:06:16 +0000 (10:36 +0530)
committerajay priyadarshi <ajay.priyadarshi@ril.com>
Tue, 20 Mar 2018 05:06:16 +0000 (10:36 +0530)
collector/TaskThread.java
file name: MessageUtil.java

Change-Id: I6f5700f731f62ef34fb33f9107564293a0e91d54
Issue-ID: VFC-829
Signed-off-by: ajay priyadarshi <ajay.priyadarshi@ril.com>
ems/boco/src/main/java/org/onap/vfc/nfvo/emsdriver/collector/TaskThread.java
ems/boco/src/main/java/org/onap/vfc/nfvo/emsdriver/collector/alarm/MessageUtil.java

index da48829..94d9c56 100644 (file)
@@ -43,7 +43,7 @@ import java.util.regex.Pattern;
 public class TaskThread implements Runnable {
 
        private static final Log log = LogFactory.getLog(TaskThread.class);
-       private MessageChannel pmResultChannel; //This should also be private. Need to change in TastThreadTest 
+       private MessageChannel pmResultChannel; 
        private MessageChannel cmResultChannel;
        private CollectMsg data;
 
@@ -929,7 +929,7 @@ public class TaskThread implements Runnable {
                return pmResultChannel;
        }
 
-       public void setPmResultChannel(MessageChannel pmResultChannel) {
-               this.pmResultChannel = pmResultChannel;
+       public void setPmResultChannel(MessageChannel pmResChannel) {
+               this.pmResultChannel = pmResChannel;
        }
 }
index eede19b..d7a4dd8 100644 (file)
@@ -77,7 +77,7 @@ public class MessageUtil {
             dis.readFully(inputB);
             short startSign = ois.readShort();
             if (startSign != Msg.StartSign) {
-                throw new Exception("start sign is [" + Msg.StartSign
+                throw new IOException("start sign is [" + Msg.StartSign
                         + "],not is [" + startSign + "]");
             }
             int msgType = ois.readByte();
@@ -86,7 +86,7 @@ public class MessageUtil {
             msg.setTimeStamp(timeStamp);
             int bodylength = ois.readShort();
             msg.setLenOfBody(bodylength);
-            byte b[] = new byte[bodylength];
+            byte[] b = new byte[bodylength];
             dis.readFully(b);
             msg.newBodyfromBytes(b);
         } catch (Exception e) {