Fix major sonar issues 21/14221/1
authorshashikanth <shashikanth.vh@huawei.com>
Thu, 21 Sep 2017 11:50:03 +0000 (17:20 +0530)
committershashikanth <shashikanth.vh@huawei.com>
Thu, 21 Sep 2017 11:50:03 +0000 (17:20 +0530)
Fix Major sonar issues in aai/traversal module
https://sonar.onap.org/component_issues?id=org.onap.aai.traversal%3Atraversal#resolved=false|severities=MAJOR

Fixed string literal on the left side of this string comparison

Issue-Id:AAI-212
Change-Id: I41fab87df2e9c32f3ab2a07db9ab5aadc9c91d25
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
aai-traversal/src/main/java/org/openecomp/aai/rest/search/SearchProvider.java

index ee6b1ab..4330db1 100644 (file)
@@ -105,7 +105,7 @@ public class SearchProvider extends RESTAPI {
                        //only consider header value for search         
                        DBConnectionType type = this.determineConnectionType("force-cache", realTime);
                        final Version version;
-                       if (versionParam.equals("latest")) {
+                       if ("latest".equals(versionParam)) {
                                version = AAIProperties.LATEST;
                        } else {
                                version = Version.valueOf(versionParam);
@@ -197,7 +197,7 @@ public class SearchProvider extends RESTAPI {
                        DBConnectionType type = this.determineConnectionType("force-cache", realTime);
                        
                        final Version version;
-                       if (versionParam.equals("latest")) {
+                       if ("latest".equals(versionParam)) {
                                version = AAIProperties.LATEST;
                        } else {
                                version = Version.valueOf(versionParam);