Fix Sonar violations - ConfigurationDataSource 63/27063/2
authorojasdubey <ojas.dubey@amdocs.com>
Wed, 27 Dec 2017 15:00:32 +0000 (20:30 +0530)
committerVitaly Emporopulo <Vitaliy.Emporopulo@amdocs.com>
Wed, 27 Dec 2017 15:46:14 +0000 (15:46 +0000)
1. Fixed major sonar violations configuration management core
- ConfigurationDataSource

Change-Id: Iee96111b3051a67d25f99a0ba49e99f4d9290345
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
common/openecomp-common-configuration-management/openecomp-configuration-management-core/src/main/java/org/openecomp/config/impl/ConfigurationDataSource.java

index 0cfc96b..a60403e 100644 (file)
@@ -22,11 +22,16 @@ public final class ConfigurationDataSource {
   private static Set<String> validCallers = Collections.unmodifiableSet(new HashSet<>(
       Arrays.asList(ConfigurationUtils.class.getName(), CliConfigurationImpl.class.getName())));
 
+  private ConfigurationDataSource() {
+    //Hide constructor to prevent instantiation using the default implicit constructor
+  }
+
   static {
     try {
       configDBDatasource = initDataSource();
     } catch (Exception exception) {
-      System.err.println("Datasource initialization error. Configuration management will be using in-memory persistence.");
+      System.err.println("Datasource initialization error. Configuration management will be using"
+          + "in-memory persistence.");
     }
   }
 
@@ -83,7 +88,6 @@ public final class ConfigurationDataSource {
       Driver driver = Driver.class.cast(Class.forName(driverClassName).newInstance());
       return driver.acceptsURL(url);
     } catch (Exception exception) {
-      exception.printStackTrace();
       return false;
     }
   }