fixed sonar issues in ConfigModelService.java

fixed sonar issues

Issue-ID: CCSDK-552
Change-Id: Iab02d1cee2b0cb9e182f9d4af839000307ec99bf
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>

diff --git a/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/ConfigModelService.java b/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/ConfigModelService.java
index a2f653c..b2fff26 100644 (file)
--- a/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/ConfigModelService.java
+++ b/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/ConfigModelService.java
@@ -55,6 +55,7 @@ public class ConfigModelService {
     private ConfigModelRepository configModelRepository;\r
     private ConfigModelContentRepository configModelContentRepository;\r
     private ConfigModelCreateService configModelCreateService;\r
+    private static final String CONFIG_MODEL_ID_FAILURE_MSG= "failed to get config model id(%d) from repo";\r
 \r
     /**\r
      * This is a ConfigModelService constructor.\r
@@ -174,7 +175,7 @@ public class ConfigModelService {
         if (dbConfigModel.isPresent()) {\r
             configModel = dbConfigModel.get();\r
         } else {\r
-            throw new BluePrintException(String.format("failed to get config model id(%d) from repo", id));\r
+            throw new BluePrintException(String.format(CONFIG_MODEL_ID_FAILURE_MSG, id));\r
         }\r
 \r
         return configModel;\r
@@ -232,7 +233,7 @@ public class ConfigModelService {
                 }\r
             }\r
         } else {\r
-            throw new BluePrintException(String.format("failed to get config model id(%d) from repo", id));\r
+            throw new BluePrintException(String.format(CONFIG_MODEL_ID_FAILURE_MSG, id));\r
         }\r
 \r
         return cloneConfigModel;\r
@@ -252,7 +253,7 @@ public class ConfigModelService {
             configModelContentRepository.deleteByConfigModel(dbConfigModel.get());\r
             configModelRepository.delete(dbConfigModel.get());\r
         } else {\r
-            throw new BluePrintException(String.format("failed to get config model id(%d) from repo", id));\r
+            throw new BluePrintException(String.format(CONFIG_MODEL_ID_FAILURE_MSG, id));\r
         }\r
     }\r
 \r