Merge "Fixed latest Sonar blocker issues"
authorSeshu Kumar M <seshu.kumar.m@huawei.com>
Thu, 11 Apr 2019 06:46:05 +0000 (06:46 +0000)
committerGerrit Code Review <gerrit@onap.org>
Thu, 11 Apr 2019 06:46:05 +0000 (06:46 +0000)
54 files changed:
adapters/mso-catalog-db-adapter/src/main/java/db/migration/R__CloudConfigMigration.java
adapters/mso-catalog-db-adapter/src/main/resources/db/migration/R__WorkflowDesignerData.sql [new file with mode: 0644]
adapters/mso-catalog-db-adapter/src/main/resources/db/migration/V5.10__AlterforWorkFlowDesignerTables.sql [new file with mode: 0644]
adapters/mso-catalog-db-adapter/src/test/java/org/onap/so/db/catalog/client/CatalogDbClientTest.java
adapters/mso-catalog-db-adapter/src/test/resources/db/migration/afterMigrate.sql
adapters/mso-openstack-adapters/src/main/java/org/onap/so/adapters/network/MsoNetworkAdapterAsyncImpl.java
adapters/mso-openstack-adapters/src/main/java/org/onap/so/adapters/vnf/VnfAdapterRest.java
adapters/mso-openstack-adapters/src/test/java/org/onap/so/adapters/vnf/MsoVnfAdapterImplTest.java
asdc-controller/src/main/java/org/onap/so/asdc/activity/ActivitySpecsActions.java [new file with mode: 0644]
asdc-controller/src/main/java/org/onap/so/asdc/activity/DeployActivitySpecs.java [new file with mode: 0644]
asdc-controller/src/main/java/org/onap/so/asdc/activity/beans/ActivitySpec.java [new file with mode: 0644]
asdc-controller/src/main/java/org/onap/so/asdc/activity/beans/ActivitySpecCreateResponse.java [new file with mode: 0644]
asdc-controller/src/main/java/org/onap/so/asdc/activity/beans/Input.java [new file with mode: 0644]
asdc-controller/src/main/java/org/onap/so/asdc/activity/beans/Output.java [new file with mode: 0644]
asdc-controller/src/main/java/org/onap/so/asdc/client/ASDCController.java
asdc-controller/src/main/java/org/onap/so/asdc/installer/heat/ToscaResourceInstaller.java
asdc-controller/src/test/java/org/onap/asdc/activity/ActivitySpecsActionsTest.java [new file with mode: 0644]
asdc-controller/src/test/java/org/onap/asdc/activity/DeployActivitySpecsTest.java [new file with mode: 0644]
asdc-controller/src/test/java/org/onap/so/asdc/BaseTest.java
asdc-controller/src/test/java/org/onap/so/asdc/BeansTest.java [new file with mode: 0644]
asdc-controller/src/test/java/org/onap/so/asdc/installer/heat/ToscaResourceInstallerTest.java
asdc-controller/src/test/resources/application-test.yaml
bpmn/MSOCommonBPMN/src/main/groovy/org/onap/so/bpmn/common/scripts/ExternalAPIUtil.groovy
bpmn/MSOCommonBPMN/src/main/java/org/onap/so/bpmn/common/resource/ResourceRequestBuilder.java
bpmn/MSOCommonBPMN/src/test/groovy/org/onap/so/bpmn/common/scripts/ExternalAPIUtilTest.groovy
bpmn/MSOCommonBPMN/src/test/java/org/onap/so/bpmn/common/resource/ResourceRequestBuilderTest.java
bpmn/MSOCoreBPMN/src/main/java/org/onap/so/bpmn/core/domain/ServiceDecomposition.java
bpmn/mso-infrastructure-bpmn/src/main/java/org/onap/so/bpmn/infrastructure/MSOInfrastructureApplication.java
bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/AssignVnfBB.bpmn
bpmn/so-bpmn-building-blocks/src/test/java/org/onap/so/bpmn/infrastructure/bpmn/subprocess/AssignVnfBBTest.java
bpmn/so-bpmn-infrastructure-common/src/main/groovy/org/onap/so/bpmn/infrastructure/scripts/Create3rdONAPE2EServiceInstance.groovy
bpmn/so-bpmn-infrastructure-common/src/main/groovy/org/onap/so/bpmn/infrastructure/scripts/DoCompareServiceInstanceData.groovy [new file with mode: 0644]
bpmn/so-bpmn-infrastructure-common/src/main/groovy/org/onap/so/bpmn/infrastructure/scripts/UpdateCustomE2EServiceInstance.groovy
bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/PnfNotificationEvent.java [new file with mode: 0644]
bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/delegate/InformDmaapClient.java
bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/dmaap/PnfEventReadyDmaapClient.java
bpmn/so-bpmn-infrastructure-common/src/test/groovy/org/onap/so/bpmn/infrastructure/scripts/DoCompareServiceInstanceDataTest.groovy [new file with mode: 0644]
bpmn/so-bpmn-infrastructure-common/src/test/java/org/onap/so/bpmn/infrastructure/pnf/delegate/InformDmaapClientTest.java
bpmn/so-bpmn-infrastructure-common/src/test/java/org/onap/so/bpmn/infrastructure/pnf/dmaap/PnfEventReadyDmaapClientTest.java
bpmn/so-bpmn-infrastructure-flows/src/main/resources/process/UpdateCustomE2EServiceInstance.bpmn
bpmn/so-bpmn-infrastructure-flows/src/main/resources/subprocess/DoCompareServiceInstanceData.bpmn [new file with mode: 0644]
bpmn/so-bpmn-infrastructure-flows/src/main/resources/subprocess/DoUpdateE2EServiceInstance.bpmn
bpmn/so-bpmn-infrastructure-flows/src/test/java/org/onap/so/bpmn/infrastructure/process/CreateVcpeResCustServiceSimplifiedTest.java
bpmn/so-bpmn-tasks/src/test/java/org/onap/so/bpmn/infrastructure/sdnc/tasks/SDNCUnassignTasksTest.java
mso-api-handlers/mso-api-handler-infra/src/main/java/org/onap/so/apihandlerinfra/WorkflowSpecificationsHandler.java
mso-api-handlers/mso-api-handler-infra/src/test/java/org/onap/so/apihandlerinfra/WorkflowSpecificationsHandlerTest.java
mso-api-handlers/mso-api-handler-infra/src/test/resources/__files/catalogdb/WorkflowActivitySpecSequence_Response.json [new file with mode: 0644]
mso-api-handlers/mso-api-handler-infra/src/test/resources/__files/catalogdb/WorkflowSpecifications.json [moved from mso-api-handlers/mso-api-handler-infra/src/test/resources/__files/WorkflowSpecifications.json with 96% similarity]
mso-api-handlers/mso-api-handler-infra/src/test/resources/__files/catalogdb/WorkflowSpecificationsQuery_Response.json [new file with mode: 0644]
mso-catalog-db/src/main/java/org/onap/so/db/catalog/client/CatalogDbClient.java
mso-catalog-db/src/main/java/org/onap/so/db/catalog/data/repository/WorkflowRepository.java
mso-catalog-db/src/test/java/org/onap/so/db/catalog/data/repository/WorkflowRepositoryTest.java
mso-catalog-db/src/test/resources/data.sql
mso-catalog-db/src/test/resources/schema.sql

index 053c6da..469a7ad 100644 (file)
@@ -69,21 +69,6 @@ public class R__CloudConfigMigration implements JdbcMigration, MigrationInfoProv
 
         CloudConfig cloudConfig = null;
 
-        String tableQuery = "SELECT * FROM identity_services";
-        int totalRetries = 20;
-        boolean tableExists = false;
-        int count = 1;
-        while (!tableExists && count != totalRetries) {
-            try (Statement stmt = connection.createStatement();) {
-                stmt.executeQuery(tableQuery);
-                tableExists = true;
-            } catch (SQLException e) {
-                count++;
-                // Wait 5 mintues
-                Thread.sleep(300000);
-            }
-        }
-
         // Try the override file
         String configLocation = System.getProperty("spring.config.additional-location");
         if (configLocation != null) {
diff --git a/adapters/mso-catalog-db-adapter/src/main/resources/db/migration/R__WorkflowDesignerData.sql b/adapters/mso-catalog-db-adapter/src/main/resources/db/migration/R__WorkflowDesignerData.sql
new file mode 100644 (file)
index 0000000..c74ce69
--- /dev/null
@@ -0,0 +1,27 @@
+use catalogdb;
+
+DELETE FROM activity_spec_to_activity_spec_parameters;
+DELETE FROM activity_spec_to_activity_spec_categories;
+DELETE FROM activity_spec;
+DELETE FROM activity_spec_categories;
+DELETE FROM activity_spec_parameters;
+
+INSERT INTO activity_spec (NAME, DESCRIPTION, VERSION) 
+VALUES ('VNFSetInMaintFlagActivity','Activity to Set InMaint Flag in A&AI',1.0);
+
+INSERT INTO activity_spec_categories (NAME)
+VALUES ('VNF');
+
+INSERT INTO activity_spec_parameters (NAME, TYPE, DIRECTION, DESCRIPTION) 
+VALUES('WorkflowException','WorkflowException','outputParameters','Description');
+
+INSERT INTO activity_spec_to_activity_spec_categories(ACTIVITY_SPEC_ID, ACTIVITY_SPEC_CATEGORIES_ID) 
+VALUES
+(
+(select ID from ACTIVITY_SPEC where NAME='VNFSetInMaintFlagActivity' and VERSION=1.0),
+(select ID from activity_spec_categories where NAME='VNF'));
+
+INSERT INTO activity_spec_to_activity_spec_parameters( ACTIVITY_SPEC_ID, ACTIVITY_SPEC_PARAMETERS_ID) 
+VALUES(
+(select ID from ACTIVITY_SPEC where NAME='VNFSetInMaintFlagActivity' and VERSION=1.0),
+(select ID from activity_spec_parameters where NAME='WorkflowException' and DIRECTION='outputParameters'));
\ No newline at end of file
diff --git a/adapters/mso-catalog-db-adapter/src/main/resources/db/migration/V5.10__AlterforWorkFlowDesignerTables.sql b/adapters/mso-catalog-db-adapter/src/main/resources/db/migration/V5.10__AlterforWorkFlowDesignerTables.sql
new file mode 100644 (file)
index 0000000..775455d
--- /dev/null
@@ -0,0 +1,14 @@
+use catalogdb;
+
+ALTER TABLE activity_spec_to_activity_spec_categories DROP FOREIGN KEY fk_activity_spec_to_activity_spec_categories__activity_spec_c1;
+
+ALTER TABLE activity_spec_categories modify id INT(11) not null auto_increment;
+
+ALTER TABLE activity_spec_to_activity_spec_categories ADD 
+ CONSTRAINT `fk_activity_spec_to_activity_spec_categories__activity_spec_c1` 
+    FOREIGN KEY (`ACTIVITY_SPEC_CATEGORIES_ID`) 
+    REFERENCES `activity_spec_categories` (`ID`) 
+    ON DELETE CASCADE 
+    ON UPDATE CASCADE; 
+    
+ALTER TABLE activity_spec_to_activity_spec_categories modify id INT(11) not null auto_increment; 
\ No newline at end of file
index e1152ba..51b44b0 100644 (file)
@@ -658,4 +658,19 @@ public class CatalogDbClientTest extends CatalogDbAdapterBaseTest {
         Assert.assertNull(workflow);
     }
 
+    @Test
+    public void getWorkflowByModelUUID_validUuid_expectedOutput() {
+        List<Workflow> workflows = client.findWorkflowByModelUUID("ff2ae348-214a-11e7-93ae-92361f002671");
+        assertTrue(workflows != null);
+        assertTrue(workflows.size() != 0);
+
+        assertEquals("testingWorkflow", workflows.get(0).getArtifactName());
+    }
+
+    @Test
+    public void getWorkflowByModelUUID_invalidUuid_nullOutput() {
+        Workflow workflow = client.findWorkflowByArtifactUUID(UUID.randomUUID().toString());
+        Assert.assertNull(workflow);
+    }
+
 }
index af00732..0229dd0 100644 (file)
@@ -226,3 +226,6 @@ insert into pnf_resource_customization_to_service(service_model_uuid, resource_m
 
 insert into workflow(artifact_uuid, artifact_name, name, operation_name, version, description, body, resource_target, source) values
 ('5b0c4322-643d-4c9f-b184-4516049e99b1', 'testingWorkflow', 'testingWorkflow', 'create', 1, 'Test Workflow', null, 'vnf', 'sdc');
+
+insert into vnf_resource_to_workflow(vnf_resource_model_uuid, workflow_id) values
+('ff2ae348-214a-11e7-93ae-92361f002671', '1');
index d13b172..4753b1c 100644 (file)
@@ -67,7 +67,7 @@ public class MsoNetworkAdapterAsyncImpl implements MsoNetworkAdapterAsync {
     private static final Logger logger = LoggerFactory.getLogger(MsoNetworkAdapterAsyncImpl.class);
 
     private static final String BPEL_AUTH_PROP = "org.onap.so.adapters.network.bpelauth";
-    private static final String ENCRYPTION_KEY_PROP = "org.onap.so.adapters.network.encryptionKey";
+    private static final String ENCRYPTION_KEY_PROP = "mso.msoKey";
     private static final String NETWORK_EXCEPTION_MSG = "Got a NetworkException on createNetwork: ";
     private static final String CREATE_NETWORK_ERROR_LOGMSG = "{} {} Error sending createNetwork notification {} ";
     private static final String FAULT_INFO_ERROR_LOGMSG = "{} {} Exception - fault info ";
index 487b14b..e81b211 100644 (file)
@@ -359,22 +359,7 @@ public class VnfAdapterRest {
                     vfModuleStackId.value = "479D3D8B-6360-47BC-AB75-21CC91981484";
                     outputs.value = VolumeAdapterRest.testMap();
                 } else {
-                    // vnfAdapter.createVnf (createReq.getCloudSiteId(),
-                    // createReq.getTenantId(),
-                    // createReq.getVnfType(),
-                    // createReq.getVnfVersion(),
-                    // createReq.getVfModuleName(),
-                    // createReq.getRequestType(),
-                    // createReq.getVolumeGroupStackId(),
-                    // createReq.getVfModuleParams(),
-                    // createReq.getFailIfExists(),
-                    // createReq.getBackout(),
-                    // createReq.getMsoRequest(),
-                    // vfModuleStackId,
-                    // outputs,
-                    // vnfRollback);
                     vnfAdapter.createVfModule(req.getCloudSiteId(), req.getCloudOwner(), req.getTenantId(),
-                            // req.getVnfType(),
                             completeVnfVfModuleType, req.getVnfVersion(), req.getVnfId(), req.getVfModuleName(),
                             req.getVfModuleId(), req.getRequestType(), req.getVolumeGroupStackId(),
                             req.getBaseVfModuleStackId(), req.getModelCustomizationUuid(), req.getVfModuleParams(),
index f314d32..0c56222 100644 (file)
@@ -296,7 +296,7 @@ public class MsoVnfAdapterImplTest extends BaseRestTestUtils {
         Map<String, Object> map = new HashMap<>();
         map.put("key1", "value1");
         instance.createVfModule("mtn13", "CloudOwner", "88a6ca3ee0394ade9403f075db23167e", "vnf", "1", "", vnfName, "",
-                "VFMOD", "volumeGroupHeatStackId", "baseVfHeatStackId", "88a6ca3ee0394ade9403f075db23167e", map,
+                "VFMOD", "volumeGroupHeatStackId", "baseVfHeatStackId", "9b339a61-69ca-465f-86b8-1c72c582b8e8", map,
                 Boolean.FALSE, Boolean.TRUE, Boolean.FALSE, msoRequest, new Holder<>(),
                 new Holder<Map<String, String>>(), new Holder<VnfRollback>());
     }
diff --git a/asdc-controller/src/main/java/org/onap/so/asdc/activity/ActivitySpecsActions.java b/asdc-controller/src/main/java/org/onap/so/asdc/activity/ActivitySpecsActions.java
new file mode 100644 (file)
index 0000000..c80e84b
--- /dev/null
@@ -0,0 +1,123 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP - SO
+ * ================================================================================
+ * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.so.asdc.activity;
+
+import javax.ws.rs.core.Response;
+import javax.ws.rs.core.UriBuilder;
+import org.apache.http.HttpStatus;
+import org.apache.http.entity.ContentType;
+import org.onap.so.asdc.activity.beans.ActivitySpec;
+import org.onap.so.asdc.activity.beans.ActivitySpecCreateResponse;
+import org.onap.so.client.HttpClient;
+import org.onap.so.client.HttpClientFactory;
+import org.onap.so.utils.TargetEntity;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.stereotype.Component;
+import com.fasterxml.jackson.annotation.JsonInclude.Include;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import java.net.URL;
+
+@Component
+public class ActivitySpecsActions {
+
+    private static final String ACTIVITY_SPEC_URI = "/v1.0/activity-spec";
+    private static final String ACTIVITY_SPEC_URI_SUFFIX = "/versions/latest/actions";
+    private static final String CERTIFY_ACTIVITY_PAYLOAD = "{\"action\": \"CERTIFY\"}";
+
+    private final HttpClientFactory httpClientFactory = new HttpClientFactory();
+    protected static final Logger logger = LoggerFactory.getLogger(ActivitySpecsActions.class);
+
+    public String createActivitySpec(String hostname, ActivitySpec activitySpec) {
+        if (activitySpec == null) {
+            return null;
+        }
+
+        String activitySpecId = null;
+
+        try {
+            ObjectMapper mapper = new ObjectMapper();
+            mapper.setSerializationInclusion(Include.NON_NULL);
+            String payload = mapper.writer().writeValueAsString(activitySpec);
+
+            String urlString = UriBuilder.fromUri(hostname).path(ACTIVITY_SPEC_URI).build().toString();
+            URL url = new URL(urlString);
+
+            HttpClient httpClient = httpClientFactory.newJsonClient(url, TargetEntity.SDC);
+            httpClient.addAdditionalHeader("Content-Type", ContentType.APPLICATION_JSON.toString());
+
+            Response response = httpClient.post(payload);
+
+            int statusCode = response.getStatus();
+            if (statusCode != HttpStatus.SC_OK) {
+                logger.warn("{} {} {}", "Error creating activity spec", activitySpec.getName(), statusCode);
+            } else {
+                if (response.getEntity() != null) {
+                    ActivitySpecCreateResponse activitySpecCreateResponse =
+                            response.readEntity(ActivitySpecCreateResponse.class);
+                    if (activitySpecCreateResponse != null) {
+                        activitySpecId = activitySpecCreateResponse.getId();
+                    } else {
+                        logger.warn("{} {}", "Unable to read activity spec", activitySpec.getName());
+                    }
+                } else {
+                    logger.warn("{} {}", "No activity spec response returned", activitySpec.getName());
+                }
+            }
+        } catch (Exception e) {
+            logger.warn("{} {}", "Exception creating activitySpec", e.getMessage());
+        }
+
+        return activitySpecId;
+    }
+
+    public boolean certifyActivitySpec(String hostname, String activitySpecId) {
+        boolean certificationResult = false;
+        if (activitySpecId == null) {
+            return false;
+        }
+
+        try {
+            String path = ACTIVITY_SPEC_URI + "/" + activitySpecId + ACTIVITY_SPEC_URI_SUFFIX;
+
+            String urlString = UriBuilder.fromUri(hostname).path(path).build().toString();
+            URL url = new URL(urlString);
+
+            HttpClient httpClient = httpClientFactory.newJsonClient(url, TargetEntity.SDC);
+            httpClient.addAdditionalHeader("Content-Type", ContentType.APPLICATION_JSON.toString());
+
+            Response response = httpClient.put(CERTIFY_ACTIVITY_PAYLOAD);
+
+            int statusCode = response.getStatus();
+
+            if (statusCode != HttpStatus.SC_OK) {
+                logger.warn("{} {} {}", "Error certifying activity", activitySpecId, statusCode);
+            } else {
+                certificationResult = true;
+            }
+
+        } catch (Exception e) {
+            logger.warn("{} {}", "Exception certifying activitySpec", e.getMessage());
+        }
+
+        return certificationResult;
+    }
+}
diff --git a/asdc-controller/src/main/java/org/onap/so/asdc/activity/DeployActivitySpecs.java b/asdc-controller/src/main/java/org/onap/so/asdc/activity/DeployActivitySpecs.java
new file mode 100644 (file)
index 0000000..46d0f78
--- /dev/null
@@ -0,0 +1,67 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP - SO
+ * ================================================================================
+ * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.so.asdc.activity;
+
+import javax.annotation.PostConstruct;
+import java.util.ArrayList;
+import java.util.List;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.core.env.Environment;
+import org.springframework.stereotype.Component;
+import org.onap.so.asdc.activity.beans.ActivitySpec;
+import org.onap.so.db.catalog.client.CatalogDbClient;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Component
+public class DeployActivitySpecs {
+    @Autowired
+    private ActivitySpecsActions activitySpecsActions;
+
+    @Autowired
+    private Environment env;
+
+    private static final String SDC_ENDPOINT = "mso.asdc.config.activity.endpoint";
+
+    protected static final Logger logger = LoggerFactory.getLogger(DeployActivitySpecs.class);
+
+    public void deployActivities() throws Exception {
+        String hostname = this.env.getProperty(SDC_ENDPOINT);
+        List<ActivitySpec> activitySpecs = new ArrayList<ActivitySpec>();
+
+        // Initialize activitySpecs from Catalog DB
+
+        for (ActivitySpec activitySpec : activitySpecs) {
+            String activitySpecId = activitySpecsActions.createActivitySpec(hostname, activitySpec);
+            if (activitySpecId != null) {
+                logger.info("{} {}", "Successfully created activitySpec", activitySpec.getName());
+                boolean certificationResult = activitySpecsActions.certifyActivitySpec(hostname, activitySpecId);
+                if (certificationResult) {
+                    logger.info("{} {}", "Successfully certified activitySpec", activitySpec.getName());
+                } else {
+                    logger.info("{} {}", "Failed to certify activitySpec", activitySpec.getName());
+                }
+            } else {
+                logger.info("{} {}", "Failed to create activitySpec", activitySpec.getName());
+            }
+        }
+    }
+}
diff --git a/asdc-controller/src/main/java/org/onap/so/asdc/activity/beans/ActivitySpec.java b/asdc-controller/src/main/java/org/onap/so/asdc/activity/beans/ActivitySpec.java
new file mode 100644 (file)
index 0000000..e7d1ff1
--- /dev/null
@@ -0,0 +1,99 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP - SO
+ * ================================================================================
+ * Copyright (C) 2019 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.onap.so.asdc.activity.beans;
+
+import java.util.List;
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonPropertyOrder;
+import org.apache.commons.lang.builder.ToStringBuilder;
+
+@JsonInclude(JsonInclude.Include.NON_NULL)
+@JsonPropertyOrder({"name", "description", "categoryList", "inputs", "outputs"})
+public class ActivitySpec {
+
+    @JsonProperty("name")
+    private String name;
+    @JsonProperty("description")
+    private String description;
+    @JsonProperty("categoryList")
+    private List<String> categoryList = null;
+    @JsonProperty("inputs")
+    private List<Input> inputs = null;
+    @JsonProperty("outputs")
+    private List<Output> outputs = null;
+
+    @JsonProperty("name")
+    public String getName() {
+        return name;
+    }
+
+    @JsonProperty("name")
+    public void setName(String name) {
+        this.name = name;
+    }
+
+    @JsonProperty("description")
+    public String getDescription() {
+        return description;
+    }
+
+    @JsonProperty("description")
+    public void setDescription(String description) {
+        this.description = description;
+    }
+
+    @JsonProperty("categoryList")
+    public List<String> getCategoryList() {
+        return categoryList;
+    }
+
+    @JsonProperty("categoryList")
+    public void setCategoryList(List<String> categoryList) {
+        this.categoryList = categoryList;
+    }
+
+    @JsonProperty("inputs")
+    public List<Input> getInputs() {
+        return inputs;
+    }
+
+    @JsonProperty("inputs")
+    public void setInputs(List<Input> inputs) {
+        this.inputs = inputs;
+    }
+
+    @JsonProperty("outputs")
+    public List<Output> getOutputs() {
+        return outputs;
+    }
+
+    @JsonProperty("outputs")
+    public void setOutputs(List<Output> outputs) {
+        this.outputs = outputs;
+    }
+
+    @Override
+    public String toString() {
+        return new ToStringBuilder(this).append("name", name).append("description", description)
+                .append("categoryList", categoryList).append("inputs", inputs).append("outputs", outputs).toString();
+    }
+
+}
diff --git a/asdc-controller/src/main/java/org/onap/so/asdc/activity/beans/ActivitySpecCreateResponse.java b/asdc-controller/src/main/java/org/onap/so/asdc/activity/beans/ActivitySpecCreateResponse.java
new file mode 100644 (file)
index 0000000..1384425
--- /dev/null
@@ -0,0 +1,61 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP - SO
+ * ================================================================================
+ * Copyright (C) 2019 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.onap.so.asdc.activity.beans;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonPropertyOrder;
+import org.apache.commons.lang.builder.ToStringBuilder;
+
+@JsonInclude(JsonInclude.Include.NON_NULL)
+@JsonPropertyOrder({"id", "versionId"})
+public class ActivitySpecCreateResponse {
+
+    @JsonProperty("id")
+    private String id;
+    @JsonProperty("versionId")
+    private String versionId;
+
+    @JsonProperty("id")
+    public String getId() {
+        return id;
+    }
+
+    @JsonProperty("id")
+    public void setId(String id) {
+        this.id = id;
+    }
+
+    @JsonProperty("versionId")
+    public String getVersionId() {
+        return versionId;
+    }
+
+    @JsonProperty("versionId")
+    public void setVersionId(String versionId) {
+        this.versionId = versionId;
+    }
+
+    @Override
+    public String toString() {
+        return new ToStringBuilder(this).append("id", id).append("versionId", versionId).toString();
+    }
+
+}
diff --git a/asdc-controller/src/main/java/org/onap/so/asdc/activity/beans/Input.java b/asdc-controller/src/main/java/org/onap/so/asdc/activity/beans/Input.java
new file mode 100644 (file)
index 0000000..3359d1d
--- /dev/null
@@ -0,0 +1,61 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP - SO
+ * ================================================================================
+ * Copyright (C) 2019 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.onap.so.asdc.activity.beans;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonPropertyOrder;
+import org.apache.commons.lang.builder.ToStringBuilder;
+
+@JsonInclude(JsonInclude.Include.NON_NULL)
+@JsonPropertyOrder({"name", "type"})
+public class Input {
+
+    @JsonProperty("name")
+    private String name;
+    @JsonProperty("type")
+    private String type;
+
+    @JsonProperty("name")
+    public String getName() {
+        return name;
+    }
+
+    @JsonProperty("name")
+    public void setName(String name) {
+        this.name = name;
+    }
+
+    @JsonProperty("type")
+    public String getType() {
+        return type;
+    }
+
+    @JsonProperty("type")
+    public void setType(String type) {
+        this.type = type;
+    }
+
+    @Override
+    public String toString() {
+        return new ToStringBuilder(this).append("name", name).append("type", type).toString();
+    }
+
+}
diff --git a/asdc-controller/src/main/java/org/onap/so/asdc/activity/beans/Output.java b/asdc-controller/src/main/java/org/onap/so/asdc/activity/beans/Output.java
new file mode 100644 (file)
index 0000000..1e3d2e4
--- /dev/null
@@ -0,0 +1,73 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP - SO
+ * ================================================================================
+ * Copyright (C) 2019 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.onap.so.asdc.activity.beans;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonPropertyOrder;
+import org.apache.commons.lang.builder.ToStringBuilder;
+
+@JsonInclude(JsonInclude.Include.NON_NULL)
+@JsonPropertyOrder({"name", "type", "value"})
+public class Output {
+
+    @JsonProperty("name")
+    private String name;
+    @JsonProperty("type")
+    private String type;
+    @JsonProperty("value")
+    private String value;
+
+    @JsonProperty("name")
+    public String getName() {
+        return name;
+    }
+
+    @JsonProperty("name")
+    public void setName(String name) {
+        this.name = name;
+    }
+
+    @JsonProperty("type")
+    public String getType() {
+        return type;
+    }
+
+    @JsonProperty("type")
+    public void setType(String type) {
+        this.type = type;
+    }
+
+    @JsonProperty("value")
+    public String getValue() {
+        return value;
+    }
+
+    @JsonProperty("value")
+    public void setValue(String value) {
+        this.value = value;
+    }
+
+    @Override
+    public String toString() {
+        return new ToStringBuilder(this).append("name", name).append("type", type).append("value", value).toString();
+    }
+
+}
index 92326b1..57e9c17 100644 (file)
@@ -1,5 +1,5 @@
 /*-
-d * ============LICENSE_START=======================================================
+ * ============LICENSE_START=======================================================
  * ONAP - SO
  * ================================================================================
  * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
@@ -250,9 +250,11 @@ public class ASDCController {
         this.changeControllerStatus(ASDCControllerStatus.STOPPED);
     }
 
-    private boolean checkResourceAlreadyDeployed(VfResourceStructure resource) throws ArtifactInstallerException {
+    protected boolean checkResourceAlreadyDeployed(ResourceStructure resource, boolean serviceDeployed)
+            throws ArtifactInstallerException {
 
-        if (toscaInstaller.isResourceAlreadyDeployed(resource)) {
+
+        if (toscaInstaller.isResourceAlreadyDeployed(resource, serviceDeployed)) {
             logger.info("{} {} {} {}", MessageEnum.ASDC_ARTIFACT_ALREADY_EXIST.toString(),
                     resource.getResourceInstance().getResourceInstanceName(),
                     resource.getResourceInstance().getResourceUUID(), resource.getResourceInstance().getResourceName());
@@ -656,6 +658,7 @@ public class ASDCController {
         ToscaResourceStructure toscaResourceStructure = new ToscaResourceStructure(msoConfigPath);
         boolean deploySuccessful = true;
         String errorMessage = null;
+        boolean serviceDeployed = false;
 
         try {
             this.processCsarServiceArtifacts(iNotif, toscaResourceStructure);
@@ -686,12 +689,45 @@ public class ASDCController {
                     resourceStructure.setResourceType(ResourceType.OTHER);
                 }
 
-                for (IArtifactInfo artifact : resource.getArtifacts()) {
-                    IDistributionClientDownloadResult resultArtifact =
-                            this.downloadTheArtifact(artifact, iNotif.getDistributionID());
-                    if (resultArtifact != null) {
-                        resourceStructure.addArtifactToStructure(distributionClient, artifact, resultArtifact);
+                try {
+
+                    if (!this.checkResourceAlreadyDeployed(resourceStructure, serviceDeployed)) {
+
+                        logger.debug("Processing Resource Type: " + resourceType + " and Model UUID: "
+                                + resourceStructure.getResourceInstance().getResourceUUID());
+
+                        if ("VF".equals(resourceType) && !"Allotted Resource".equalsIgnoreCase(category)) {
+
+                            for (IArtifactInfo artifact : resource.getArtifacts()) {
+                                IDistributionClientDownloadResult resultArtifact =
+                                        this.downloadTheArtifact(artifact, iNotif.getDistributionID());
+                                if (resultArtifact != null) {
+
+                                    if (ASDCConfiguration.VF_MODULES_METADATA.equals(artifact.getArtifactType())) {
+                                        logger.debug("VF_MODULE_ARTIFACT: "
+                                                + new String(resultArtifact.getArtifactPayload(), "UTF-8"));
+                                        logger.debug(ASDCNotificationLogging
+                                                .dumpVfModuleMetaDataList(((VfResourceStructure) resourceStructure)
+                                                        .decodeVfModuleArtifact(resultArtifact.getArtifactPayload())));
+                                    }
+                                    resourceStructure.addArtifactToStructure(distributionClient, artifact,
+                                            resultArtifact);
+                                }
+                            }
+
+                            // Deploy VF resource and artifacts
+                            logger.debug("Preparing to deploy Service: {}", iNotif.getServiceUUID());
+
+
+                            this.deployResourceStructure(resourceStructure, toscaResourceStructure);
+                            serviceDeployed = true;
+                        }
                     }
+
+                } catch (ArtifactInstallerException e) {
+                    deploySuccessful = false;
+                    errorMessage = e.getMessage();
+                    logger.error("Exception occurred", e);
                 }
 
                 // Deploy VF resource and artifacts
index 0e30b77..e61aafa 100644 (file)
@@ -249,9 +249,10 @@ public class ToscaResourceInstaller {
 
     protected static final Logger logger = LoggerFactory.getLogger(ToscaResourceInstaller.class);
 
-    public boolean isResourceAlreadyDeployed(VfResourceStructure vfResourceStruct) throws ArtifactInstallerException {
+    public boolean isResourceAlreadyDeployed(ResourceStructure vfResourceStruct, boolean serviceDeployed)
+            throws ArtifactInstallerException {
         boolean status = false;
-        VfResourceStructure vfResourceStructure = vfResourceStruct;
+        ResourceStructure vfResourceStructure = vfResourceStruct;
         try {
             status = vfResourceStructure.isDeployedSuccessfully();
         } catch (RuntimeException e) {
@@ -260,7 +261,7 @@ public class ToscaResourceInstaller {
         try {
             Service existingService =
                     serviceRepo.findOneByModelUUID(vfResourceStructure.getNotification().getServiceUUID());
-            if (existingService != null)
+            if (existingService != null && serviceDeployed == false)
                 status = true;
             if (status) {
                 logger.info(vfResourceStructure.getResourceInstance().getResourceInstanceName(),
diff --git a/asdc-controller/src/test/java/org/onap/asdc/activity/ActivitySpecsActionsTest.java b/asdc-controller/src/test/java/org/onap/asdc/activity/ActivitySpecsActionsTest.java
new file mode 100644 (file)
index 0000000..4381209
--- /dev/null
@@ -0,0 +1,76 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP - SO
+ * ================================================================================
+ * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.onap.asdc.activity;
+
+import static com.github.tomakehurst.wiremock.client.WireMock.aResponse;
+import static com.github.tomakehurst.wiremock.client.WireMock.post;
+import static com.github.tomakehurst.wiremock.client.WireMock.put;
+import static com.github.tomakehurst.wiremock.client.WireMock.urlPathMatching;
+import static org.junit.Assert.*;
+import org.junit.Test;
+import org.onap.so.asdc.BaseTest;
+import org.onap.so.asdc.activity.ActivitySpecsActions;
+import org.onap.so.asdc.activity.beans.ActivitySpec;
+import org.onap.so.asdc.activity.beans.ActivitySpecCreateResponse;
+import org.springframework.beans.factory.annotation.Autowired;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+public class ActivitySpecsActionsTest extends BaseTest {
+    @Autowired
+    ActivitySpecsActions activitySpecsActions;
+
+    @Test
+    public void CreateActivitySpec_Test() throws Exception {
+        String HOSTNAME = createURLWithPort("");
+
+        ActivitySpec activitySpec = new ActivitySpec();
+        activitySpec.setName("testActivitySpec");
+        activitySpec.setDescription("Test Activity Spec");
+        ActivitySpecCreateResponse activitySpecCreateResponse = new ActivitySpecCreateResponse();
+        activitySpecCreateResponse.setId("testActivityId");
+        ObjectMapper mapper = new ObjectMapper();
+        String body = mapper.writeValueAsString(activitySpecCreateResponse);
+        wireMockServer.stubFor(post(urlPathMatching("/v1.0/activity-spec"))
+                .willReturn(aResponse().withHeader("Content-Type", "application/json")
+                        .withStatus(org.springframework.http.HttpStatus.OK.value()).withBody(body)));
+
+        String activitySpecId = activitySpecsActions.createActivitySpec(HOSTNAME, activitySpec);
+        assertEquals("testActivityId", activitySpecId);
+    }
+
+    @Test
+    public void CertifyActivitySpec_Test() throws Exception {
+        String HOSTNAME = createURLWithPort("");
+
+        String activitySpecId = "testActivitySpec";
+        String urlPath = "/v1.0/activity-spec/testActivitySpec/versions/latest/actions";
+
+        wireMockServer.stubFor(
+                put(urlPathMatching(urlPath)).willReturn(aResponse().withHeader("Content-Type", "application/json")
+                        .withStatus(org.springframework.http.HttpStatus.OK.value())));
+
+        boolean certificationResult = activitySpecsActions.certifyActivitySpec(HOSTNAME, activitySpecId);
+        assertTrue(certificationResult);
+    }
+
+    private String createURLWithPort(String uri) {
+        return "http://localhost:" + wireMockPort + uri;
+    }
+}
diff --git a/asdc-controller/src/test/java/org/onap/asdc/activity/DeployActivitySpecsTest.java b/asdc-controller/src/test/java/org/onap/asdc/activity/DeployActivitySpecsTest.java
new file mode 100644 (file)
index 0000000..86f6a89
--- /dev/null
@@ -0,0 +1,38 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP - SO
+ * ================================================================================
+ * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.onap.asdc.activity;
+
+import org.junit.Test;
+import org.onap.so.asdc.BaseTest;
+import org.onap.so.asdc.activity.DeployActivitySpecs;
+import org.springframework.beans.factory.annotation.Autowired;
+
+
+public class DeployActivitySpecsTest extends BaseTest {
+
+    @Autowired
+    private DeployActivitySpecs deployActivitySpecs;
+
+    @Test
+    public void DeployActivitySpecs_Test() throws Exception {
+        // Mock catalog DB results
+        deployActivitySpecs.deployActivities();
+    }
+}
index 0fcf9b0..7ecd472 100644 (file)
@@ -45,6 +45,7 @@ import com.github.tomakehurst.wiremock.WireMockServer;
 @ActiveProfiles("test")
 @ContextConfiguration(classes = SpringContextHelper.class, initializers = ConfigFileApplicationContextInitializer.class)
 @AutoConfigureWireMock(port = 0)
+
 public abstract class BaseTest {
     @MockBean
     protected VfResourceStructure vfResourceStructure;
diff --git a/asdc-controller/src/test/java/org/onap/so/asdc/BeansTest.java b/asdc-controller/src/test/java/org/onap/so/asdc/BeansTest.java
new file mode 100644 (file)
index 0000000..86e4d27
--- /dev/null
@@ -0,0 +1,70 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP - SO
+ * ================================================================================
+ * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.so.asdc;
+
+import org.junit.Test;
+import org.onap.so.openpojo.rules.ToStringTester;
+import com.openpojo.reflection.PojoClass;
+import com.openpojo.reflection.PojoClassFilter;
+import com.openpojo.reflection.filters.FilterEnum;
+import com.openpojo.reflection.filters.FilterNonConcrete;
+import com.openpojo.reflection.filters.FilterPackageInfo;
+import com.openpojo.validation.Validator;
+import com.openpojo.validation.ValidatorBuilder;
+import com.openpojo.validation.rule.impl.GetterMustExistRule;
+import com.openpojo.validation.rule.impl.SetterMustExistRule;
+import com.openpojo.validation.test.impl.GetterTester;
+import com.openpojo.validation.test.impl.SetterTester;
+
+public class BeansTest {
+
+
+    private PojoClassFilter filterTestClasses = new FilterTestClasses();
+
+    private PojoClassFilter enumFilter = new FilterEnum();
+
+
+    @Test
+    public void pojoStructure() {
+        test("org.onap.so.asdc.activity.beans");
+    }
+
+    private void test(String pojoPackage) {
+        Validator validator = ValidatorBuilder.create().with(new GetterMustExistRule()).with(new SetterMustExistRule())
+
+                .with(new SetterTester()).with(new GetterTester())
+
+                .with(new SetterTester()).with(new GetterTester()).with(new ToStringTester())
+
+                .build();
+
+
+        validator.validate(pojoPackage, new FilterPackageInfo(), filterTestClasses, enumFilter,
+                new FilterNonConcrete());
+    }
+
+    private static class FilterTestClasses implements PojoClassFilter {
+        @Override
+        public boolean include(PojoClass pojoClass) {
+            return !pojoClass.getSourcePath().contains("/test-classes/");
+        }
+    }
+}
index 99833da..d3c0bde 100644 (file)
@@ -131,7 +131,7 @@ public class ToscaResourceInstallerTest extends BaseTest {
         doReturn("resourceCustomizationUUID").when(resourceInstance).getResourceCustomizationUUID();
         doReturn("resourceName").when(resourceInstance).getResourceName();
 
-        toscaInstaller.isResourceAlreadyDeployed(vfResourceStructure);
+        toscaInstaller.isResourceAlreadyDeployed(vfResourceStructure, false);
 
         WatchdogComponentDistributionStatus actualWatchdogComponentDistributionStatus = getWatchdogCDStatusWithName(
                 watchdogCDStatusRepository.findByDistributionId(notificationData.getDistributionID()), MSO);
@@ -156,7 +156,7 @@ public class ToscaResourceInstallerTest extends BaseTest {
         doReturn("resourceCustomizationUUID").when(resourceInstance).getResourceCustomizationUUID();
         doReturn("resourceName").when(resourceInstance).getResourceName();
 
-        toscaInstaller.isResourceAlreadyDeployed(vfResourceStructure);
+        toscaInstaller.isResourceAlreadyDeployed(vfResourceStructure, false);
 
         verify(vfResourceStructure, times(3)).getResourceInstance();
         verify(vfResourceStructure, times(4)).getNotification();
@@ -166,7 +166,7 @@ public class ToscaResourceInstallerTest extends BaseTest {
     public void isResourceAlreadyDeployedExceptionTest() throws ArtifactInstallerException {
         expectedException.expect(ArtifactInstallerException.class);
 
-        toscaInstaller.isResourceAlreadyDeployed(vfResourceStructure);
+        toscaInstaller.isResourceAlreadyDeployed(vfResourceStructure, false);
     }
 
     @Test
index 5ba8521..ec53649 100644 (file)
@@ -89,6 +89,8 @@ mso:
       messageBusAddress: localhost,localhost
   asdc:
     config:
+      activity:
+        endpoint: http://localhost:${wiremock.server.port}
       key: 566B754875657232314F5548556D3665
       components:
         count: 3,
index 918bcdd..64567a3 100644 (file)
@@ -143,12 +143,14 @@ class ExternalAPIUtil {
                        String uuid = utils.getRequestID()
                        logger.debug( "Generated uuid is: " + uuid)
                        logger.debug( "URL to be used is: " + url)
+                       logger.debug("URL to be passed in header is: " + execution.getVariable("SPPartnerUrl"))
 
                        HttpClient client = httpClientFactory.newJsonClient(new URL(url), TargetEntity.EXTERNAL)
                        client.addBasicAuthHeader(execution.getVariable("URN_externalapi_auth"), execution.getVariable("URN_mso_msoKey"))
                        client.addAdditionalHeader("X-FromAppId", "MSO")
                        client.addAdditionalHeader(ONAPLogConstants.Headers.REQUEST_ID, uuid)
                        client.addAdditionalHeader("Accept", MediaType.APPLICATION_JSON)
+                       client.addAdditionalHeader("Target",execution.getVariable("SPPartnerUrl"))
 
                        apiResponse = client.get()
 
@@ -179,11 +181,13 @@ class ExternalAPIUtil {
                        String uuid = utils.getRequestID()
                        logger.debug( "Generated uuid is: " + uuid)
                        logger.debug( "URL to be used is: " + url)
+                       logger.debug("URL to be passed in header is: " + execution.getVariable("SPPartnerUrl"))
 
                        HttpClient httpClient = httpClientFactory.newJsonClient(new URL(url), TargetEntity.AAI)
                        httpClient.addBasicAuthHeader(execution.getVariable("URN_externalapi_auth"), execution.getVariable("URN_mso_msoKey"))
                        httpClient.addAdditionalHeader("X-FromAppId", "MSO")
                        httpClient.addAdditionalHeader("X-TransactionId", uuid)
+                       httpClient.addAdditionalHeader("Target",execution.getVariable("SPPartnerUrl"))
 
                        apiResponse = httpClient.post(payload)
 
index e7ab6e4..0dbf2c2 100644 (file)
@@ -139,7 +139,6 @@ public class ResourceRequestBuilder {
             Map<String, Object> serviceInputs) {
         try {
             Map<String, Object> serviceInstnace = getServiceInstnace(serviceUuid);
-
             // find match of customization uuid in vnf
             Map<String, Map<String, Object>> serviceResources =
                     (Map<String, Map<String, Object>>) serviceInstnace.get("serviceResources");
@@ -200,7 +199,11 @@ public class ResourceRequestBuilder {
                 if (serviceInputs.containsKey(tmpKey)) {
                     value = (String) serviceInputs.get(tmpKey);
                 } else {
-                    value = split[1];
+                    if (split.length == 1) { // means value is empty e.g. "a":"key1|"
+                        value = "";
+                    } else {
+                        value = split[1];
+                    }
                 }
             }
             resourceInput.put(key, value);
index db11cb6..837bc77 100644 (file)
@@ -146,6 +146,7 @@ class ExternalAPIUtilTest {
         DelegateExecution delegateExecution = mock(DelegateExecution.class)
         given(delegateExecution.getVariable("URN_externalapi_auth")).willReturn("value_externalapi_auth")
         given(delegateExecution.getVariable("URN_mso_msoKey")).willReturn("value_mso_msoKey")
+               given(delegateExecution.getVariable("SPPartnerUrl")).willReturn("http://LocalExtAPIURL:8080")
         return delegateExecution
     }
 
index 0c2862b..c7c1817 100644 (file)
@@ -7,9 +7,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  */
 package org.onap.so.bpmn.common.resource;
 
+import org.junit.Test;
+import org.onap.so.BaseTest;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
 import static com.github.tomakehurst.wiremock.client.WireMock.get;
 import static com.github.tomakehurst.wiremock.client.WireMock.ok;
 import static com.github.tomakehurst.wiremock.client.WireMock.urlEqualTo;
 import static org.junit.Assert.assertEquals;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import org.junit.Test;
-import org.onap.so.BaseTest;
 
 
 public class ResourceRequestBuilderTest extends BaseTest {
@@ -341,4 +341,49 @@ public class ResourceRequestBuilderTest extends BaseTest {
         assertEquals(0, stringObjectMap.size());
     }
 
+    @Test
+    public void testGetResourceInputEmptyValue() {
+        wireMockServer.stubFor(get(urlEqualTo(
+                "/ecomp/mso/catalog/v2/serviceResources?serviceModelUuid=c3954379-4efe-431c-8258-f84905b158e5"))
+                        .willReturn(ok("{ \"serviceResources\"    : {\n" + "\t\"modelInfo\"       : {\n"
+                                + "\t\t\"modelName\"          : \"demoVFWCL\",\n"
+                                + "\t\t\"modelUuid\"          : \"c3954379-4efe-431c-8258-f84905b158e5\",\n"
+                                + "\t\t\"modelInvariantUuid\" : \"0cbff61e-3b0a-4eed-97ce-b1b4faa03493\",\n"
+                                + "\t\t\"modelVersion\"       : \"1.0\"\n" + "\t},\n"
+                                + "\t\"serviceType\"        : \"\",\n" + "\t\"serviceRole\"        : \"\",\n"
+                                + "\t\"environmentContext\" : null,\n" + "\t\"resourceOrder\"       : \"res1,res2\",\n"
+                                + "\t\"workloadContext\"    : \"Production\",\n" + "\t\"serviceVnfs\": [\n" + "\t\n"
+                                + "\t\t{ \"modelInfo\"                    : {\n"
+                                + "\t\t\t\"modelName\"              : \"15968a6e-2fe5-41bf-a481\",\n"
+                                + "\t\t\t\"modelUuid\"              : \"808abda3-2023-4105-92d2-e62644b61d53\",\n"
+                                + "\t\t\t\"modelInvariantUuid\"     : \"6e4ffc7c-497e-4a77-970d-af966e642d31\",\n"
+                                + "\t\t\t\"modelVersion\"           : \"1.0\",\n"
+                                + "\t\t\t\"modelCustomizationUuid\" : \"a00404d5-d7eb-4c46-b6b6-9cf2d087e545\",\n"
+                                + "\t\t\t\"modelInstanceName\"      : \"15968a6e-2fe5-41bf-a481 0\"\n" + "\t\t\t},\n"
+                                + "\t\t\"toscaNodeType\"            : \"org.openecomp.resource.vf.15968a6e2fe541bfA481\",\n"
+                                + "\t\t\"nfFunction\"           \t: null,\n"
+                                + "\"resourceInput\":\"{\\\"a\\\":\\\"key1|\\\"}\","
+                                + "\t\t\"nfType\"              \t\t: null,\n"
+                                + "\t\t\"nfRole\"              \t\t: null,\n"
+                                + "\t\t\"nfNamingCode\"         \t: null,\n"
+                                + "\t\t\"multiStageDesign\"         : \"false\",\n" + "\t\t\t\"vfModules\": [\n"
+                                + "\t\t\t\t{\n" + "\t\t\t\t\t\"modelInfo\"               : { \n"
+                                + "\t\t\t\t\t\t\"modelName\"              : \"15968a6e2fe541bfA481..base_vfw..module-0\",\n"
+                                + "\t\t\t\t\t\t\"modelUuid\"              : \"ec7fadde-1e5a-42f7-8255-cb19e475ff45\",\n"
+                                + "\t\t\t\t\t\t\"modelInvariantUuid\"     : \"61ab8b64-a014-4cf3-8a5a-b5ef388f8819\",\n"
+                                + "\t\t\t\t\t\t\"modelVersion\"           : \"1\",\n"
+                                + "\t\t\t\t\t\t\"modelCustomizationUuid\" : \"123aff6b-854f-4026-ae1e-cc74a3924576\"\n"
+                                + "\t\t\t\t\t},\t\t\"isBase\"                 : true,\n"
+                                + "\t\t\t\t\t\"vfModuleLabel\"          : \"base_vfw\",\n"
+                                + "\t\t\t\t\t\"initialCount\"           : 1,\n"
+                                + "\t\t\t\t\t\"hasVolumeGroup\"           : true\n" + "\t\t\t\t}\n" + "\t\t\t]\n"
+                                + "\t\t}]}}")));
+
+        HashMap serviceInput = new HashMap();
+        serviceInput.put("key2", "value");
+        Map<String, Object> stringObjectMap = ResourceRequestBuilder.buildResouceRequest(
+                "c3954379-4efe-431c-8258-f84905b158e5", "a00404d5-d7eb-4c46-b6b6-9cf2d087e545", serviceInput);
+        assertEquals(stringObjectMap.get("a"), "");
+    }
+
 }
index 0e03989..419f545 100644 (file)
@@ -54,7 +54,6 @@ public class ServiceDecomposition extends JsonWrapper implements Serializable {
     private String serviceRole;
     private ServiceInstance serviceInstance;
     private Request request;
-    private Customer customer;
     private String callbackURN;
     private String sdncVersion;
     @JsonProperty("project")
@@ -217,14 +216,6 @@ public class ServiceDecomposition extends JsonWrapper implements Serializable {
         this.request = request;
     }
 
-    public Customer getCustomer() {
-        return customer;
-    }
-
-    public void setCustomer(Customer customer) {
-        this.customer = customer;
-    }
-
     public String getCallbackURN() {
         return callbackURN;
     }
index bd430fd..c61808e 100644 (file)
@@ -28,18 +28,24 @@ import org.camunda.bpm.application.PostDeploy;
 import org.camunda.bpm.application.PreUndeploy;
 import org.camunda.bpm.application.ProcessApplicationInfo;
 import org.camunda.bpm.engine.ProcessEngine;
+import org.camunda.bpm.engine.repository.DeploymentBuilder;
 import org.onap.so.bpmn.common.DefaultToShortClassNameBeanNameGenerator;
+import org.onap.so.db.catalog.beans.Workflow;
+import org.onap.so.db.catalog.data.repository.WorkflowRepository;
 import org.onap.so.logging.jaxrs.filter.MDCTaskDecorator;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.boot.SpringApplication;
 import org.springframework.boot.autoconfigure.SpringBootApplication;
+import org.springframework.boot.autoconfigure.domain.EntityScan;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.ComponentScan;
 import org.springframework.context.annotation.ComponentScan.Filter;
 import org.springframework.context.annotation.FilterType;
 import org.springframework.context.annotation.Primary;
+import org.springframework.data.jpa.repository.config.EnableJpaRepositories;
 import org.springframework.scheduling.annotation.EnableAsync;
 import org.springframework.scheduling.concurrent.ThreadPoolTaskExecutor;
 
@@ -50,12 +56,18 @@ import org.springframework.scheduling.concurrent.ThreadPoolTaskExecutor;
 
 @SpringBootApplication
 @EnableAsync
+@EnableJpaRepositories("org.onap.so.db.catalog.data.repository")
+@EntityScan({"org.onap.so.db.catalog.beans"})
 @ComponentScan(basePackages = {"org.onap"}, nameGenerator = DefaultToShortClassNameBeanNameGenerator.class,
         excludeFilters = {@Filter(type = FilterType.ANNOTATION, classes = SpringBootApplication.class)})
+
 public class MSOInfrastructureApplication {
 
     private static final Logger logger = LoggerFactory.getLogger(MSOInfrastructureApplication.class);
 
+    @Autowired
+    private WorkflowRepository workflowRepository;
+
     @Value("${mso.async.core-pool-size}")
     private int corePoolSize;
 
@@ -66,6 +78,7 @@ public class MSOInfrastructureApplication {
     private int queueCapacity;
 
     private static final String LOGS_DIR = "logs_dir";
+    private static final String BPMN_SUFFIX = ".bpmn";
 
 
     private static void setLogsDir() {
@@ -81,7 +94,10 @@ public class MSOInfrastructureApplication {
     }
 
     @PostDeploy
-    public void postDeploy(ProcessEngine processEngineInstance) {}
+    public void postDeploy(ProcessEngine processEngineInstance) {
+        DeploymentBuilder deploymentBuilder = processEngineInstance.getRepositoryService().createDeployment();
+        deployCustomWorkflows(deploymentBuilder);
+    }
 
     @PreUndeploy
     public void cleanup(ProcessEngine processEngine, ProcessApplicationInfo processApplicationInfo,
@@ -99,4 +115,25 @@ public class MSOInfrastructureApplication {
         executor.initialize();
         return executor;
     }
+
+    public void deployCustomWorkflows(DeploymentBuilder deploymentBuilder) {
+        if (workflowRepository == null) {
+            return;
+        }
+        List<Workflow> workflows = workflowRepository.findAll();
+        if (workflows != null && workflows.size() != 0) {
+            for (Workflow workflow : workflows) {
+                String workflowName = workflow.getName();
+                String workflowBody = workflow.getBody();
+                if (!workflowName.endsWith(BPMN_SUFFIX)) {
+                    workflowName += BPMN_SUFFIX;
+                }
+                if (workflowBody != null) {
+                    logger.info("{} {}", "Deploying custom workflow", workflowName);
+                    deploymentBuilder.addString(workflowName, workflowBody);
+                }
+            }
+            deploymentBuilder.deploy();
+        }
+    }
 }
index ce4d2e1..ea762c8 100644 (file)
@@ -1,13 +1,9 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<bpmn:definitions xmlns:bpmn="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:di="http://www.omg.org/spec/DD/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:camunda="http://camunda.org/schema/1.0/bpmn" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" id="Definitions_1" targetNamespace="http://bpmn.io/schema/bpmn" exporter="Camunda Modeler" exporterVersion="1.7.1">
+<bpmn:definitions xmlns:bpmn="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:di="http://www.omg.org/spec/DD/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:camunda="http://camunda.org/schema/1.0/bpmn" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" id="Definitions_1" targetNamespace="http://bpmn.io/schema/bpmn" exporter="Camunda Modeler" exporterVersion="1.8.2">
   <bpmn:process id="AssignVnfBB" name="AssignVnfBB" isExecutable="true">
     <bpmn:startEvent id="Start_AssignVnfBB">
       <bpmn:outgoing>SequenceFlow_0zaz9o2</bpmn:outgoing>
     </bpmn:startEvent>
-    <bpmn:serviceTask id="Task_SDNCAdapterVnfTopologyAssign" name="&#10;SDNC &#10;Create Request&#10;(vnf)&#10;" camunda:expression="${SDNCAssignTasks.assignVnf(InjectExecution.execute(execution, execution.getVariable(&#34;gBuildingBlockExecution&#34;)))}">
-      <bpmn:incoming>SequenceFlow_1samncw</bpmn:incoming>
-      <bpmn:outgoing>SequenceFlow_1qkhm79</bpmn:outgoing>
-    </bpmn:serviceTask>
     <bpmn:endEvent id="End_AssignVnfBB">
       <bpmn:incoming>SequenceFlow_0csh9dc</bpmn:incoming>
     </bpmn:endEvent>
@@ -18,7 +14,7 @@
     <bpmn:sequenceFlow id="SequenceFlow_0zaz9o2" sourceRef="Start_AssignVnfBB" targetRef="Task_CreateVnf" />
     <bpmn:sequenceFlow id="SequenceFlow_0csh9dc" sourceRef="Task_UpdateVnfOrchestrationStatusAssigned" targetRef="End_AssignVnfBB" />
     <bpmn:serviceTask id="Task_UpdateVnfOrchestrationStatusAssigned" name="&#10;AAI&#10;Update&#10;(vnf)&#10;" camunda:expression="${AAIUpdateTasks.updateOrchestrationStatusAssignedVnf(InjectExecution.execute(execution, execution.getVariable(&#34;gBuildingBlockExecution&#34;)))}">
-      <bpmn:incoming>SequenceFlow_1vw20wu</bpmn:incoming>
+      <bpmn:incoming>SequenceFlow_0yzidhu</bpmn:incoming>
       <bpmn:outgoing>SequenceFlow_0csh9dc</bpmn:outgoing>
     </bpmn:serviceTask>
     <bpmn:serviceTask id="Task_createInstanceGroups" name="&#10;AAI&#10;Create&#10;(instance grp)&#10;" camunda:expression="${AssignVnf.createInstanceGroups(InjectExecution.execute(execution, execution.getVariable(&#34;gBuildingBlockExecution&#34;)))}">
@@ -62,6 +58,7 @@
       </bpmn:endEvent>
       <bpmn:sequenceFlow id="SequenceFlow_1i52a7x" sourceRef="StartEvent_1c3cyuv" targetRef="EndEvent_1bywujf" />
     </bpmn:subProcess>
+    <bpmn:sequenceFlow id="SequenceFlow_14mpqit" sourceRef="ExclusiveGateway_1blf52g" targetRef="Task_SDNCCreateRequest" />
     <bpmn:inclusiveGateway id="ExclusiveGateway_02tchpp" name="Call Homing?" default="SequenceFlow_11jum90">
       <bpmn:incoming>SequenceFlow_1nle8kc</bpmn:incoming>
       <bpmn:outgoing>SequenceFlow_11jum90</bpmn:outgoing>
@@ -70,7 +67,7 @@
     <bpmn:inclusiveGateway id="ExclusiveGateway_1blf52g">
       <bpmn:incoming>SequenceFlow_11jum90</bpmn:incoming>
       <bpmn:incoming>SequenceFlow_0v8d14a</bpmn:incoming>
-      <bpmn:outgoing>SequenceFlow_1samncw</bpmn:outgoing>
+      <bpmn:outgoing>SequenceFlow_14mpqit</bpmn:outgoing>
     </bpmn:inclusiveGateway>
     <bpmn:serviceTask id="ServiceTask_ConnectVnfToCloudRegion" name="&#10;AAI&#10;Connect&#10;(vnf to cloud region)&#10;" camunda:expression="${AAICreateTasks.connectVnfToCloudRegion(InjectExecution.execute(execution, execution.getVariable(&#34;gBuildingBlockExecution&#34;)))}">
       <bpmn:incoming>SequenceFlow_0qj7zcn</bpmn:incoming>
     </bpmn:serviceTask>
     <bpmn:sequenceFlow id="SequenceFlow_0nsg48b" sourceRef="ServiceTask_ConnectVnfToCloudRegion" targetRef="ServiceTask_ConnectVnfToTenant" />
     <bpmn:sequenceFlow id="SequenceFlow_18ixm0j" sourceRef="ServiceTask_ConnectVnfToTenant" targetRef="Task_createPlatform" />
-    <bpmn:callActivity id="CallActivity_sdncAssign" name="SDNC Assign (vnf)" calledElement="SDNCHandler">
+    <bpmn:serviceTask id="Task_SDNCCreateRequest" name="&#10;SDNC &#10;Create Request&#10;(vnf)&#10;" camunda:expression="${SDNCAssignTasks.assignVnf(InjectExecution.execute(execution, execution.getVariable(&#34;gBuildingBlockExecution&#34;)))}">
+      <bpmn:incoming>SequenceFlow_14mpqit</bpmn:incoming>
+      <bpmn:outgoing>SequenceFlow_1991eue</bpmn:outgoing>
+    </bpmn:serviceTask>
+    <bpmn:callActivity id="CallActivity_SDNCAssignVnf" name="SDNC Assign (vnf)" calledElement="SDNCHandler">
       <bpmn:extensionElements>
         <camunda:in source="SDNCRequest" target="SDNCRequest" />
         <camunda:out source="SDNCResponse" target="SDNCResponse" />
         <camunda:out source="WorkflowException" target="WorkflowException" />
         <camunda:in source="mso-request-id" target="mso-request-id" />
       </bpmn:extensionElements>
-      <bpmn:incoming>SequenceFlow_1qkhm79</bpmn:incoming>
-      <bpmn:outgoing>SequenceFlow_1vw20wu</bpmn:outgoing>
+      <bpmn:incoming>SequenceFlow_1991eue</bpmn:incoming>
+      <bpmn:outgoing>SequenceFlow_0yzidhu</bpmn:outgoing>
     </bpmn:callActivity>
-    <bpmn:sequenceFlow id="SequenceFlow_1samncw" sourceRef="ExclusiveGateway_1blf52g" targetRef="Task_SDNCAdapterVnfTopologyAssign" />
-    <bpmn:sequenceFlow id="SequenceFlow_1qkhm79" sourceRef="Task_SDNCAdapterVnfTopologyAssign" targetRef="CallActivity_sdncAssign" />
-    <bpmn:sequenceFlow id="SequenceFlow_1vw20wu" sourceRef="CallActivity_sdncAssign" targetRef="Task_UpdateVnfOrchestrationStatusAssigned" />
+    <bpmn:sequenceFlow id="SequenceFlow_1991eue" sourceRef="Task_SDNCCreateRequest" targetRef="CallActivity_SDNCAssignVnf" />
+    <bpmn:sequenceFlow id="SequenceFlow_0yzidhu" sourceRef="CallActivity_SDNCAssignVnf" targetRef="Task_UpdateVnfOrchestrationStatusAssigned" />
   </bpmn:process>
   <bpmn:error id="Error_0rgauy1" name="gDelegateError" errorCode="7000" />
   <bpmndi:BPMNDiagram id="BPMNDiagram_1">
           <dc:Bounds x="-275" y="152" width="90" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNShape>
-      <bpmndi:BPMNShape id="ServiceTask_0m0ikey_di" bpmnElement="Task_SDNCAdapterVnfTopologyAssign">
-        <dc:Bounds x="930" y="94" width="100" height="80" />
-      </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="EndEvent_1h93h9d_di" bpmnElement="End_AssignVnfBB">
-        <dc:Bounds x="1323" y="116" width="36" height="36" />
+        <dc:Bounds x="1415" y="116" width="36" height="36" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="1296" y="156" width="90" height="12" />
+          <dc:Bounds x="1388" y="156" width="90" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="ServiceTask_1r380lg_di" bpmnElement="Task_CreateVnf">
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNEdge id="SequenceFlow_0csh9dc_di" bpmnElement="SequenceFlow_0csh9dc">
-        <di:waypoint xsi:type="dc:Point" x="1303" y="134" />
-        <di:waypoint xsi:type="dc:Point" x="1323" y="134" />
+        <di:waypoint xsi:type="dc:Point" x="1342" y="134" />
+        <di:waypoint xsi:type="dc:Point" x="1415" y="134" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="1268" y="113" width="90" height="12" />
+          <dc:Bounds x="1334" y="113" width="90" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNShape id="ServiceTask_0s6d1be_di" bpmnElement="Task_UpdateVnfOrchestrationStatusAssigned">
-        <dc:Bounds x="1203" y="94" width="100" height="80" />
+        <dc:Bounds x="1242" y="94" width="100" height="80" />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="ServiceTask_0wjy7za_di" bpmnElement="Task_createInstanceGroups">
         <dc:Bounds x="534" y="94" width="100" height="80" />
         <dc:Bounds x="404" y="94" width="100" height="80" />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="SubProcess_19596dp_di" bpmnElement="SubProcess_19596dp" isExpanded="true">
-        <dc:Bounds x="673" y="239" width="231" height="135" />
+        <dc:Bounds x="249" y="267" width="231" height="135" />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="StartEvent_1c3cyuv_di" bpmnElement="StartEvent_1c3cyuv">
-        <dc:Bounds x="710" y="295" width="36" height="36" />
+        <dc:Bounds x="286" y="323" width="36" height="36" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="638" y="331" width="90" height="12" />
+          <dc:Bounds x="259" y="359" width="0" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="EndEvent_1bywujf_di" bpmnElement="EndEvent_1bywujf">
-        <dc:Bounds x="846" y="295" width="36" height="36" />
+        <dc:Bounds x="422" y="323" width="36" height="36" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="774" y="331" width="90" height="12" />
+          <dc:Bounds x="395" y="359" width="0" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNShape>
       <bpmndi:BPMNEdge id="SequenceFlow_1i52a7x_di" bpmnElement="SequenceFlow_1i52a7x">
-        <di:waypoint xsi:type="dc:Point" x="746" y="313" />
-        <di:waypoint xsi:type="dc:Point" x="846" y="313" />
+        <di:waypoint xsi:type="dc:Point" x="322" y="341" />
+        <di:waypoint xsi:type="dc:Point" x="422" y="341" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="372" y="320" width="0" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
+      <bpmndi:BPMNEdge id="SequenceFlow_14mpqit_di" bpmnElement="SequenceFlow_14mpqit">
+        <di:waypoint xsi:type="dc:Point" x="899" y="134" />
+        <di:waypoint xsi:type="dc:Point" x="937" y="134" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="751" y="292" width="90" height="12" />
+          <dc:Bounds x="873" y="113" width="90" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNShape id="InclusiveGateway_0x0c3kk_di" bpmnElement="ExclusiveGateway_02tchpp">
           <dc:Bounds x="259.5" y="113" width="0" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
-      <bpmndi:BPMNShape id="CallActivity_12uxg1m_di" bpmnElement="CallActivity_sdncAssign">
-        <dc:Bounds x="1060" y="94" width="100" height="80" />
+      <bpmndi:BPMNShape id="ServiceTask_07icomz_di" bpmnElement="Task_SDNCCreateRequest">
+        <dc:Bounds x="940" y="94" width="100" height="80" />
       </bpmndi:BPMNShape>
-      <bpmndi:BPMNEdge id="SequenceFlow_1samncw_di" bpmnElement="SequenceFlow_1samncw">
-        <di:waypoint xsi:type="dc:Point" x="899" y="134" />
-        <di:waypoint xsi:type="dc:Point" x="930" y="134" />
-        <bpmndi:BPMNLabel>
-          <dc:Bounds x="914.5" y="113" width="0" height="12" />
-        </bpmndi:BPMNLabel>
-      </bpmndi:BPMNEdge>
-      <bpmndi:BPMNEdge id="SequenceFlow_1qkhm79_di" bpmnElement="SequenceFlow_1qkhm79">
-        <di:waypoint xsi:type="dc:Point" x="1030" y="134" />
-        <di:waypoint xsi:type="dc:Point" x="1060" y="134" />
+      <bpmndi:BPMNShape id="CallActivity_09hycsr_di" bpmnElement="CallActivity_SDNCAssignVnf">
+        <dc:Bounds x="1088" y="94" width="100" height="80" />
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNEdge id="SequenceFlow_1991eue_di" bpmnElement="SequenceFlow_1991eue">
+        <di:waypoint xsi:type="dc:Point" x="1040" y="134" />
+        <di:waypoint xsi:type="dc:Point" x="1088" y="134" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="1045" y="113" width="0" height="12" />
+          <dc:Bounds x="1064" y="113" width="0" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
-      <bpmndi:BPMNEdge id="SequenceFlow_1vw20wu_di" bpmnElement="SequenceFlow_1vw20wu">
-        <di:waypoint xsi:type="dc:Point" x="1160" y="134" />
-        <di:waypoint xsi:type="dc:Point" x="1203" y="134" />
+      <bpmndi:BPMNEdge id="SequenceFlow_0yzidhu_di" bpmnElement="SequenceFlow_0yzidhu">
+        <di:waypoint xsi:type="dc:Point" x="1188" y="134" />
+        <di:waypoint xsi:type="dc:Point" x="1242" y="134" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="1181.5" y="113" width="0" height="12" />
+          <dc:Bounds x="1215" y="113" width="0" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
     </bpmndi:BPMNPlane>
   </bpmndi:BPMNDiagram>
 </bpmn:definitions>
-
index 078b0ae..9943e39 100644 (file)
@@ -39,9 +39,8 @@ public class AssignVnfBBTest extends BaseBPMNTest {
         assertThat(pi).isNotNull();
         assertThat(pi).isStarted().hasPassedInOrder("Start_AssignVnfBB", "Task_CreateVnf",
                 "ServiceTask_ConnectVnfToCloudRegion", "ServiceTask_ConnectVnfToTenant", "Task_createPlatform",
-                "Task_createLineOfBusiness", "Task_createInstanceGroups", "Task_callHoming",
-                "Task_SDNCAdapterVnfTopologyAssign", "CallActivity_sdncAssign",
-                "Task_UpdateVnfOrchestrationStatusAssigned", "End_AssignVnfBB");
+                "Task_createLineOfBusiness", "Task_createInstanceGroups", "Task_callHoming", "Task_SDNCCreateRequest",
+                "CallActivity_SDNCAssignVnf", "Task_UpdateVnfOrchestrationStatusAssigned", "End_AssignVnfBB");
         assertThat(pi).isEnded();
     }
 
index c8b48c6..1578f0f 100644 (file)
@@ -347,8 +347,9 @@ public class Create3rdONAPE2EServiceInstance extends AbstractServiceTaskProcesso
                logger.info(" ***** Started prepare3rdONAPRequest *****")
 
                String sppartnerUrl = execution.getVariable(Prefix + "SppartnerUrl")
-               String extAPIPath = sppartnerUrl + '/serviceOrder'
+               String extAPIPath = UrnPropertiesReader.getVariable("extapi.endpoint", execution) + '/serviceOrder'
                execution.setVariable("ExternalAPIURL", extAPIPath)
+               execution.setVariable("SPPartnerUrl",sppartnerUrl)
 
                // ExternalAPI message format
                String externalId = execution.getVariable("resourceName")
diff --git a/bpmn/so-bpmn-infrastructure-common/src/main/groovy/org/onap/so/bpmn/infrastructure/scripts/DoCompareServiceInstanceData.groovy b/bpmn/so-bpmn-infrastructure-common/src/main/groovy/org/onap/so/bpmn/infrastructure/scripts/DoCompareServiceInstanceData.groovy
new file mode 100644 (file)
index 0000000..a1f68f9
--- /dev/null
@@ -0,0 +1,270 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP - SO
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.onap.so.bpmn.infrastructure.scripts
+
+import org.camunda.bpm.engine.delegate.DelegateExecution
+import org.onap.aai.domain.yang.ServiceInstance
+import org.onap.so.bpmn.common.scripts.AbstractServiceTaskProcessor
+import org.onap.so.bpmn.common.scripts.ExceptionUtil
+import org.onap.so.bpmn.core.domain.Resource
+import org.onap.so.bpmn.core.domain.ServiceDecomposition
+import org.onap.so.bpmn.core.json.JsonUtils
+import org.onap.so.bpmn.infrastructure.workflow.service.ServicePluginFactory
+import org.slf4j.Logger
+import org.slf4j.LoggerFactory
+/**
+ * This groovy class supports the <class>DoCompareServiceInstanceData.bpmn</class> process.
+ *
+ * Inputs:
+ * @param - serviceInstanceData-original
+ * @param - serviceInstanceId
+ * @param - uuiRequest
+ * @param - model-invariant-id-original
+ * @param - model-version-id-original
+ * @param - msoRequestId
+ * @param - isDebugLogEnabled
+ *
+ * Outputs:
+ * @param - addResourceList
+ * @param - delResourceList
+ * @param - uuiRequest-add
+ * @param - uuiRequest-del
+ *
+ */
+public class DoCompareServiceInstanceData extends AbstractServiceTaskProcessor {
+
+       ExceptionUtil exceptionUtil = new ExceptionUtil()
+       JsonUtils jsonUtil = new JsonUtils()
+    private static final Logger logger = LoggerFactory.getLogger( DoCompareServiceInstanceData.class);
+
+    public void preProcessRequest (DelegateExecution execution) {
+               def isDebugEnabled = execution.getVariable("isDebugLogEnabled")
+               logger.info("INFO"," ***** preProcessRequest *****",  isDebugEnabled)
+               try {
+            checkInput("serviceInstanceData-original", execution, isDebugEnabled)
+            checkInput("serviceInstanceId", execution, isDebugEnabled)
+            checkInput("uuiRequest", execution, isDebugEnabled)
+            checkInput("model-invariant-id-original", execution, isDebugEnabled)
+            checkInput("model-version-id-original", execution, isDebugEnabled)
+            checkInput("msoRequestId", execution, isDebugEnabled)
+               } catch (Exception ex){
+            String msg = "Exception in preProcessRequest " + ex.getMessage()
+                       logger.info("INFO", msg, isDebugEnabled)
+                       exceptionUtil.buildAndThrowWorkflowException(execution, 7000, msg)
+               }
+               logger.info("INFO"," ***** Exit preProcessRequest *****",  isDebugEnabled)
+       }
+
+    private void checkInput(String inputName, DelegateExecution execution, isDebugEnabled) {
+        String msg
+        Object inputValue = execution.getVariable(inputName)
+        if (inputValue == null) {
+            msg = "Input" + inputName + "is null"
+            logger.info("INFO", msg, isDebugEnabled)
+            exceptionUtil.buildAndThrowWorkflowException(execution, 500, msg)
+        }
+    }
+
+
+    public void prepareDecomposeService_Original(DelegateExecution execution) {
+        def isDebugEnabled=execution.getVariable("isDebugLogEnabled")
+
+        try {
+            logger.debug( " ***** Inside prepareDecomposeService_Original of update generic e2e service ***** ")
+            String modelInvariantUuid = execution.getVariable("model-invariant-id-original")
+            String modelUuid = execution.getVariable("model-version-id-original")
+            //here modelVersion is not set, we use modelUuid to decompose the service.
+            String serviceModelInfo = """{
+            "modelInvariantUuid":"${modelInvariantUuid}",
+            "modelUuid":"${modelUuid}",
+            "modelVersion":""
+             }"""
+
+            execution.setVariable("serviceModelInfo_Original", serviceModelInfo)
+
+            logger.debug( " ***** Completed prepareDecomposeService_Original of update generic e2e service ***** ")
+        } catch (Exception ex) {
+            // try error in method block
+            String exceptionMessage = "Bpmn error encountered in update generic e2e service flow. Unexpected Error from method prepareDecomposeService_Original() - " + ex.getMessage()
+            exceptionUtil.buildAndThrowWorkflowException(execution, 7000, exceptionMessage)
+        }
+    }
+
+    public void processDecomposition_Original(DelegateExecution execution) {
+        def isDebugEnabled=execution.getVariable("isDebugLogEnabled")
+
+        logger.debug( " ***** Inside processDecomposition_Original() of update generic e2e service flow ***** ")
+        try {
+            ServiceDecomposition serviceDecomposition = execution.getVariable("serviceDecomposition")
+            execution.setVariable("serviceDecomposition_Original", serviceDecomposition)
+        } catch (Exception ex) {
+            String exceptionMessage = "Bpmn error encountered in update generic e2e service flow. processDecomposition_Original() - " + ex.getMessage()
+            logger.debug( exceptionMessage)
+            exceptionUtil.buildAndThrowWorkflowException(execution, 7000, exceptionMessage)
+        }
+    }
+
+    public void doCompareUuiRquestInput(DelegateExecution execution) {
+
+        def isDebugEnabled = execution.getVariable("isDebugLogEnabled")
+        logger.info("INFO", "======== Start doCompareUuiRquestInput Process ======== ", isDebugEnabled)
+
+        String uuiRequest_Target = execution.getVariable("uuiRequest")
+        Map<String, Object> serviceParametersObject_Target = getServiceParametersObject(uuiRequest_Target)
+        Map<String, Object> serviceRequestInputs_Target = (Map<String, Object>) serviceParametersObject_Target.get("requestInputs")
+        List<Object> resources_Target = (List<Object>) serviceParametersObject_Target.get("resources")
+
+        String uuiRequest_Original = ((ServiceInstance) execution.getVariable("serviceInstanceData-original")).getInputParameters()
+        Map<String, Object> serviceParametersObject_Original = getServiceParametersObject(uuiRequest_Original)
+        Map<String, Object> serviceRequestInputs_Original = (Map<String, Object>) serviceParametersObject_Original.get("requestInputs")
+        List<Object> resources_Original = (List<Object>) serviceParametersObject_Original.get("resources")
+
+        logger.info("INFO", "uuiRequest is: " + uuiRequest_Target, isDebugEnabled)
+
+        //the resources which are included by resources_Target but resources_Original are the resources going to be added
+        ArrayList<Object> resourceList_Add = findResourceListIncluded(resources_Target, resources_Original)
+        HashMap<String, Object> serviceRequestInputs_Add = getServiceRequestInputsIncluded(resourceList_Add, serviceRequestInputs_Target, serviceParametersObject_Target)
+        String uuiRequest_add = loadUuiRequestJsonString(uuiRequest_Target, resourceList_Add, serviceRequestInputs_Add)
+        execution.setVariable("uuiRequest", uuiRequest_add)
+        logger.info("INFO", "uuiRequest will be changed to: " + uuiRequest_add, isDebugEnabled)
+
+        //the resources which are included by resources_Original but resources_Target are the resources going to be deleted
+        ArrayList<Object> resourceList_Del = findResourceListIncluded(resources_Original, resources_Target)
+        HashMap<String, Object> serviceRequestInputs_Del = getServiceRequestInputsIncluded(resourceList_Del, serviceRequestInputs_Original, serviceParametersObject_Original)
+        String uuiRequest_del = loadUuiRequestJsonString(uuiRequest_Original, resourceList_Del, serviceRequestInputs_Del)
+        execution.setVariable("uuiRequest-del", uuiRequest_del)
+        logger.info("INFO", "uuiRequest-del: " + uuiRequest_del, isDebugEnabled)
+
+        List<Resource> addResourceList = findResourceList(resourceList_Add, execution)
+        execution.setVariable("addResourceList", addResourceList)
+        logger.info("INFO", "addResourceList: " + addResourceList, isDebugEnabled)
+
+        List<Resource> delResourceList = findResourceList(resourceList_Del, execution)
+        execution.setVariable("delResourceList", delResourceList)
+        logger.info("INFO", "delResourceList: " + delResourceList, isDebugEnabled)
+
+        logger.info("INFO", "======== COMPLETED doCompareUuiRquestInput Process ======== ", isDebugEnabled)
+    }
+
+    private List<Resource> findResourceList(ArrayList<Object> uuiResourceList, DelegateExecution execution) {
+        HashSet<String> addResourceCustomizationUuidSet = getCustomizationUuidSet(uuiResourceList)
+        Set<Resource> resourceSet = new HashSet<>()
+        ServiceDecomposition serviceDecomposition_Original = execution.getVariable("serviceDecomposition_Original")
+        List<Resource> allSR_original = serviceDecomposition_Original.getServiceResources()
+        for (Resource resource : allSR_original) {
+            if (addResourceCustomizationUuidSet.contains(resource.getModelInfo().getModelCustomizationUuid())) {
+                resourceSet.add(resource)
+            }
+        }
+        List<Resource> resourceList = new ArrayList<String>(resourceSet)
+        resourceList
+    }
+
+    private HashSet<String> getCustomizationUuidSet(ArrayList<Object> resourceList_Add) {
+        Set<String> addRsourceCustomizationUuidSet = new HashSet<>()
+        for (Map<String, Object> resourceAdded : resourceList_Add) {
+            addRsourceCustomizationUuidSet.add(resourceAdded.get("rsourceCustomizationUuid"))
+        }
+        addRsourceCustomizationUuidSet
+    }
+
+    private String loadUuiRequestJsonString(String uuiRequest_Target, ArrayList<Object> resourceList_Add, HashMap<String, Object> serviceRequestInputs_Add) {
+        Map<String, Object> uuiObject = ServicePluginFactory.getInstance().getJsonObject(uuiRequest_Target, Map.class)
+        Map<String, Object> serviceObject = (Map<String, Object>) uuiObject.get("service")
+        Map<String, Object> serviceParametersObject = (Map<String, Object>) serviceObject.get("parameters")
+        serviceParametersObject.put("resources", resourceList_Add)
+        serviceParametersObject.put("requestInputs", serviceRequestInputs_Add)
+        String uuiRequest_add = ServicePluginFactory.getInstance().getJsonString(serviceObject)
+        uuiRequest_add
+    }
+
+    private HashMap<String, Object> getServiceRequestInputsIncluded(ArrayList<Object> resourceList_Add, Map<String, Object> serviceRequestInputs_Target, Map<String, Object> serviceParametersObject_Target) {
+        ArrayList<String> newResourceNames = getNewResourceNames(resourceList_Add)
+        Map<String, Object> serviceRequestInputs_Add = new HashMap<String, Object>()
+        for (String inputKey : serviceRequestInputs_Target.keySet()) {
+            String resourceName = (inputKey.split("_"))[0]
+            if (newResourceNames.contains(resourceName)) {
+                serviceRequestInputs_Add.put(inputKey, serviceParametersObject_Target.get(inputKey))
+            }
+        }
+        serviceRequestInputs_Add
+    }
+
+    private ArrayList<String> getNewResourceNames(ArrayList<Object> addResourceList) {
+        Set<String> newResourceNames = new ArrayList<String>()
+        for (Object resourceObject : addResourceList) {
+            Map<String, Object> resourceAdded = (Map<String, Object>) resourceObject
+            String resName = new String(resourceAdded.get("resourceName"))
+            normalizeName(resName)
+            newResourceNames.add(resName)
+        }
+        newResourceNames
+    }
+
+    private void normalizeName(String resName) {
+        resName.replaceAll("_", "")
+        resName.replaceAll(" ", "")
+        resName.toLowerCase()
+    }
+
+    private ArrayList<Object> findResourceListIncluded(List<Object> resources_Target, List<Object> resources_Original) {
+        List<Object> addResourceList = new ArrayList<Object>()
+        for (Object resource_Target : resources_Target) {
+            Map<String, Object> resourceObject_Target = (Map<String, Object>) resource_Target
+            boolean isNewResourceInstance = isNewResourceInstance(resourceObject_Target, resources_Original)
+            if (isNewResourceInstance) {
+                addResourceList.add(resource_Target)
+            }
+        }
+        addResourceList
+    }
+
+    private boolean isNewResourceInstance(Map<String, Object> resourceObject_Target, List<Object> resources_Original) {
+        String resourceIndex_Target = null
+        if (resourceObject_Target.keySet().contains("resourceIndex")) {
+            resourceIndex_Target = resourceObject_Target.get("resourceIndex")
+        }
+        String resourceName_Target = resourceObject_Target.get("resourceName")
+        boolean isNewResourceInstance = true
+        for (Object resource_Original : resources_Original) {
+            Map<String, Object> resourceObject_Original = (Map<String, Object>) resource_Original
+            String resourceIndex_Original = null
+            if (resourceObject_Original.keySet().contains("resourceIndex")) {
+                resourceIndex_Original = resourceObject_Original.get("resourceIndex")
+            }
+            String resourceName_Original = resourceObject_Original.get("resourceName")
+            if (resourceName_Target.equals(resourceName_Original)) {
+                if (resourceIndex_Target != null && resourceIndex_Original != null) {
+                    if (resourceIndex_Target.equals(resourceIndex_Original)) {
+                        isNewResourceInstance = false
+                    }
+                } else {
+                    isNewResourceInstance = false
+                }
+            }
+        }
+        isNewResourceInstance
+    }
+
+    private Map<String, Object> getServiceParametersObject(String uuiRequest_Target) {
+        Map<String, Object> uuiObject = ServicePluginFactory.getInstance().getJsonObject(uuiRequest_Target, Map.class)
+        Map<String, Object> serviceObject = (Map<String, Object>) uuiObject.get("service")
+        Map<String, Object> serviceParametersObject = (Map<String, Object>) serviceObject.get("parameters")
+        serviceParametersObject
+    }
+
+}
index 1168b20..8e554e2 100644 (file)
@@ -189,6 +189,7 @@ public class UpdateCustomE2EServiceInstance extends AbstractServiceTaskProcessor
                        JSONObject ob = new JSONObject(wrapper.getJson())
                        JSONArray ar = ob.getJSONObject("relationship-list").getJSONArray("relationship")
 
+                       execution.setVariable("serviceInstanceData-original", si.get())
                        execution.setVariable("serviceRelationShip", ar.toString())
 
 
diff --git a/bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/PnfNotificationEvent.java b/bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/PnfNotificationEvent.java
new file mode 100644 (file)
index 0000000..267ddbf
--- /dev/null
@@ -0,0 +1,42 @@
+/*-
+ * ============LICENSE_START=======================================================
+ *  Copyright (C) 2019 Nordix Foundation.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.so.bpmn.infrastructure.pnf;
+
+import org.springframework.context.ApplicationEvent;
+
+public class PnfNotificationEvent extends ApplicationEvent {
+
+    private String pnfCorrelationId;
+
+    /**
+     * Create a new ApplicationEvent.
+     *
+     * @param source the object on which the event initially occurred (never {@code null})
+     */
+    public PnfNotificationEvent(Object source, String pnfCorrelationId) {
+        super(source);
+        this.pnfCorrelationId = pnfCorrelationId;
+    }
+
+    public String getPnfCorrelationId() {
+        return pnfCorrelationId;
+    }
+}
index 5cbd530..e2dc375 100644 (file)
@@ -23,14 +23,20 @@ package org.onap.so.bpmn.infrastructure.pnf.delegate;
 import org.camunda.bpm.engine.RuntimeService;
 import org.camunda.bpm.engine.delegate.DelegateExecution;
 import org.camunda.bpm.engine.delegate.JavaDelegate;
+import org.onap.so.bpmn.infrastructure.pnf.PnfNotificationEvent;
 import org.onap.so.bpmn.infrastructure.pnf.dmaap.DmaapClient;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.ApplicationListener;
 import org.springframework.stereotype.Component;
 
 @Component
-public class InformDmaapClient implements JavaDelegate {
+public class InformDmaapClient implements JavaDelegate, ApplicationListener<PnfNotificationEvent> {
 
+    private Logger logger = LoggerFactory.getLogger(getClass());
     private DmaapClient dmaapClient;
+    private DelegateExecution execution;
 
     @Override
     public void execute(DelegateExecution execution) {
@@ -38,10 +44,19 @@ public class InformDmaapClient implements JavaDelegate {
         RuntimeService runtimeService = execution.getProcessEngineServices().getRuntimeService();
         dmaapClient.registerForUpdate(pnfCorrelationId, () -> runtimeService.createMessageCorrelation("WorkflowMessage")
                 .processInstanceBusinessKey(execution.getProcessBusinessKey()).correlateWithResult());
+        this.execution = execution;
     }
 
     @Autowired
     public void setDmaapClient(DmaapClient dmaapClient) {
         this.dmaapClient = dmaapClient;
     }
+
+    @Override
+    public void onApplicationEvent(PnfNotificationEvent event) {
+        logger.info("Received application event for pnfCorrelationId: {}", event.getPnfCorrelationId());
+        RuntimeService runtimeService = execution.getProcessEngineServices().getRuntimeService();
+        runtimeService.createMessageCorrelation("WorkflowMessage")
+                .processInstanceBusinessKey(execution.getProcessBusinessKey()).correlateWithResult();
+    }
 }
index 3de0f38..2869111 100644 (file)
@@ -35,9 +35,11 @@ import org.apache.http.client.HttpClient;
 import org.apache.http.client.methods.HttpGet;
 import org.apache.http.impl.client.HttpClientBuilder;
 import org.apache.http.util.EntityUtils;
+import org.onap.so.bpmn.infrastructure.pnf.PnfNotificationEvent;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.ApplicationEventPublisher;
 import org.springframework.core.env.Environment;
 import org.springframework.stereotype.Component;
 
@@ -53,8 +55,11 @@ public class PnfEventReadyDmaapClient implements DmaapClient {
     private volatile ScheduledThreadPoolExecutor executor;
     private volatile boolean dmaapThreadListenerIsRunning;
 
+    private ApplicationEventPublisher applicationEventPublisher;
+
     @Autowired
-    public PnfEventReadyDmaapClient(Environment env) {
+    public PnfEventReadyDmaapClient(Environment env, ApplicationEventPublisher applicationEventPublisher) {
+        this.applicationEventPublisher = applicationEventPublisher;
         httpClient = HttpClientBuilder.create().build();
         pnfCorrelationIdToThreadMap = new ConcurrentHashMap<>();
         topicListenerDelayInSeconds = env.getProperty("pnf.dmaap.topicListenerDelayInSeconds", Integer.class);
@@ -130,13 +135,9 @@ public class PnfEventReadyDmaapClient implements DmaapClient {
         }
 
         private void informAboutPnfReadyIfPnfCorrelationIdFound(String pnfCorrelationId) {
-            Runnable runnable = unregister(pnfCorrelationId);
-            if (runnable != null) {
-                logger.debug("dmaap listener gets pnf ready event for pnfCorrelationId: {}", pnfCorrelationId);
-                // runnable.run();
-                runnable = null;
-            }
+            unregister(pnfCorrelationId);
+            PnfNotificationEvent pnfNotificationEvent = new PnfNotificationEvent(this, pnfCorrelationId);
+            applicationEventPublisher.publishEvent(pnfNotificationEvent);
         }
     }
-
 }
diff --git a/bpmn/so-bpmn-infrastructure-common/src/test/groovy/org/onap/so/bpmn/infrastructure/scripts/DoCompareServiceInstanceDataTest.groovy b/bpmn/so-bpmn-infrastructure-common/src/test/groovy/org/onap/so/bpmn/infrastructure/scripts/DoCompareServiceInstanceDataTest.groovy
new file mode 100644 (file)
index 0000000..afbace7
--- /dev/null
@@ -0,0 +1,301 @@
+package org.onap.so.bpmn.infrastructure.scripts
+
+import org.camunda.bpm.engine.delegate.BpmnError
+import org.camunda.bpm.engine.impl.persistence.entity.ExecutionEntity
+import org.junit.Before
+import org.junit.Test
+import org.mockito.ArgumentCaptor
+import org.mockito.Captor
+import org.mockito.Mockito
+import org.onap.aai.domain.yang.ServiceInstance
+import org.onap.so.bpmn.common.scripts.MsoGroovyTest
+import org.onap.so.bpmn.core.domain.Resource
+import org.onap.so.bpmn.core.domain.ServiceDecomposition
+
+import static com.shazam.shazamcrest.MatcherAssert.assertThat
+import static com.shazam.shazamcrest.matcher.Matchers.sameBeanAs
+import static org.mockito.Mockito.times
+import static org.mockito.Mockito.when
+/**
+ * Copyright 2018 ZTE Corporation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+class DoCompareServiceInstanceDataTest extends MsoGroovyTest {
+
+
+    public static final String uuiSoString = "{\n" +
+            "    \"service\":{\n" +
+            "        \"name\":\"SiteService\",\n" +
+            "        \"description\":\"SiteService\",\n" +
+            "        \"serviceInvariantUuid\":\"5c13f3fb-2744-4635-9f1f-c59c92dc8f70\",\n" +
+            "        \"serviceUuid\":\"3a76b1f5-fb0d-4b6b-82d5-0e8a4ebc3838\",\n" +
+            "        \"globalSubscriberId\":\"test_custormer\",\n" +
+            "        \"serviceType\":\"example-service-type\",\n" +
+            "        \"parameters\":{\n" +
+            "            \"locationConstraints\":[\n" +
+            "\n" +
+            "            ],\n" +
+            "            \"resources\":[\n" +
+            "                {\n" +
+            "                    \"resourceIndex\":\"1\",\n" +
+            "                    \"resourceName\":\"sdwanvpnresource\",\n" +
+            "                    \"resourceInvariantUuid\":\"0c0e1cbe-6e01-4f9e-8c45-a9700ebc14df\",\n" +
+            "                    \"resourceUuid\":\"4ad2d390-5c51-45f5-9710-b467a4ec7a73\",\n" +
+            "                    \"resourceCustomizationUuid\":\"66590e07-0777-415c-af44-36347cf3ddd3\",\n" +
+            "                    \"parameters\":{\n" +
+            "                        \"locationConstraints\":[\n" +
+            "\n" +
+            "                        ],\n" +
+            "                        \"resources\":[\n" +
+            "\n" +
+            "                        ],\n" +
+            "                        \"requestInputs\":{\n" +
+            "\n" +
+            "                        }\n" +
+            "                    }\n" +
+            "                },\n" +
+            "                {\n" +
+            "                    \"resourceIndex\":\"1\",\n" +
+            "                    \"resourceName\":\"sdwansiteresource\",\n" +
+            "                    \"resourceInvariantUuid\":\"97a3e552-08c4-4697-aeeb-d8d3e09ce58e\",\n" +
+            "                    \"resourceUuid\":\"63d8e1af-32dc-4c71-891d-e3f7b6a976d2\",\n" +
+            "                    \"resourceCustomizationUuid\":\"205456e7-3dc0-40c4-8cb0-28e6c1877042\",\n" +
+            "                    \"parameters\":{\n" +
+            "                        \"locationConstraints\":[\n" +
+            "\n" +
+            "                        ],\n" +
+            "                        \"resources\":[\n" +
+            "\n" +
+            "                        ],\n" +
+            "                        \"requestInputs\":{\n" +
+            "\n" +
+            "                        }\n" +
+            "                    }\n" +
+            "                },\n" +
+            "                {\n" +
+            "                    \"resourceIndex\":\"2\",\n" +
+            "                    \"resourceName\":\"sdwansiteresource\",\n" +
+            "                    \"resourceInvariantUuid\":\"97a3e552-08c4-4697-aeeb-d8d3e09ce58e\",\n" +
+            "                    \"resourceUuid\":\"63d8e1af-32dc-4c71-891d-e3f7b6a976d2\",\n" +
+            "                    \"resourceCustomizationUuid\":\"205456e7-3dc0-40c4-8cb0-28e6c1877042\",\n" +
+            "                    \"parameters\":{\n" +
+            "                        \"locationConstraints\":[\n" +
+            "\n" +
+            "                        ],\n" +
+            "                        \"resources\":[\n" +
+            "\n" +
+            "                        ],\n" +
+            "                        \"requestInputs\":{\n" +
+            "\n" +
+            "                        }\n" +
+            "                    }\n" +
+            "                }\n" +
+            "            ],\n" +
+            "            \"requestInputs\":{\n" +
+            "                \"sdwanvpnresource_list\":[\n" +
+            "                    {\n" +
+            "                        \"sdwanvpn_topology\":\"hub_spoke\",\n" +
+            "                        \"sdwanvpn_name\":\"defaultvpn\",\n" +
+            "                        \"sdwansitelan_list\":[\n" +
+            "                            {\n" +
+            "                                \"role\":\"Hub\",\n" +
+            "                                \"portType\":\"GE\",\n" +
+            "                                \"portSwitch\":\"layer3-port\",\n" +
+            "                                \"vlanId\":\"\",\n" +
+            "                                \"ipAddress\":\"192.168.10.1\",\n" +
+            "                                \"deviceName\":\"vCPE\",\n" +
+            "                                \"portNumer\":\"0/0/1\"\n" +
+            "                            },\n" +
+            "                            {\n" +
+            "                                \"role\":\"Hub\",\n" +
+            "                                \"portType\":\"GE\",\n" +
+            "                                \"portSwitch\":\"layer2-port\",\n" +
+            "                                \"vlanId\":\"55\",\n" +
+            "                                \"ipAddress\":\"192.168.11.1\",\n" +
+            "                                \"deviceName\":\"CPE_Beijing\",\n" +
+            "                                \"portNumer\":\"0/0/1\"\n" +
+            "                            }\n" +
+            "                        ]\n" +
+            "                    }\n" +
+            "                ],\n" +
+            "                \"sdwansiteresource_list\":[\n" +
+            "                    {\n" +
+            "                        \"sdwansite_emails\":\"chenchuanyu@huawei.com\",\n" +
+            "                        \"sdwansite_address\":\"Huawei Public Cloud\",\n" +
+            "                        \"sdwansite_description\":\"DC Site\",\n" +
+            "                        \"sdwansite_role\":\"dsvpn_hub\",\n" +
+            "                        \"sdwansite_postcode\":\"20000\",\n" +
+            "                        \"sdwansite_type\":\"single_gateway\",\n" +
+            "                        \"sdwansite_latitude\":\"\",\n" +
+            "                        \"sdwansite_controlPoint\":\"\",\n" +
+            "                        \"sdwansite_longitude\":\"\",\n" +
+            "                        \"sdwansitewan_list\":[\n" +
+            "                            {\n" +
+            "                                \"providerIpAddress\":\"\",\n" +
+            "                                \"portType\":\"GE\",\n" +
+            "                                \"inputBandwidth\":\"1000\",\n" +
+            "                                \"ipAddress\":\"\",\n" +
+            "                                \"name\":\"10000\",\n" +
+            "                                \"transportNetworkName\":\"internet\",\n" +
+            "                                \"outputBandwidth\":\"10000\",\n" +
+            "                                \"deviceName\":\"vCPE\",\n" +
+            "                                \"portNumber\":\"0/0/0\",\n" +
+            "                                \"ipMode\":\"DHCP\",\n" +
+            "                                \"publicIP\":\"119.3.7.113\"\n" +
+            "                            }\n" +
+            "                        ],\n" +
+            "                        \"sdwandevice_list\":[\n" +
+            "                            {\n" +
+            "                                \"esn\":\"XXXXXXX\",\n" +
+            "                                \"vendor\":\"Huawei\",\n" +
+            "                                \"name\":\"vCPE\",\n" +
+            "                                \"type\":\"AR1000V\",\n" +
+            "                                \"version\":\"1.0\",\n" +
+            "                                \"class\":\"VNF\",\n" +
+            "                                \"systemIp\":\"20.20.20.1\"\n" +
+            "                            }\n" +
+            "                        ]\n" +
+            "                    },\n" +
+            "                    {\n" +
+            "                        \"sdwansite_emails\":\"chenchuanyu@huawei.com\",\n" +
+            "                        \"sdwansite_address\":\"Huawei Public Cloud\",\n" +
+            "                        \"sdwansite_description\":\"DC Site\",\n" +
+            "                        \"sdwansite_role\":\"dsvpn_hub\",\n" +
+            "                        \"sdwansite_postcode\":\"20000\",\n" +
+            "                        \"sdwansite_type\":\"single_gateway\",\n" +
+            "                        \"sdwansite_latitude\":\"\",\n" +
+            "                        \"sdwansite_controlPoint\":\"\",\n" +
+            "                        \"sdwansite_longitude\":\"\",\n" +
+            "                        \"sdwansitewan_list\":[\n" +
+            "                            {\n" +
+            "                                \"providerIpAddress\":\"\",\n" +
+            "                                \"portType\":\"GE\",\n" +
+            "                                \"inputBandwidth\":\"1000\",\n" +
+            "                                \"ipAddress\":\"172.18.1.2/24\",\n" +
+            "                                \"name\":\"10000\",\n" +
+            "                                \"transportNetworkName\":\"internet\",\n" +
+            "                                \"outputBandwidth\":\"10000\",\n" +
+            "                                \"deviceName\":\"CPE_Beijing\",\n" +
+            "                                \"portNumber\":\"0/0/0\",\n" +
+            "                                \"ipMode\":\"Static\",\n" +
+            "                                \"publicIP\":\"\"\n" +
+            "                            }\n" +
+            "                        ],\n" +
+            "                        \"sdwandevice_list\":[\n" +
+            "                            {\n" +
+            "                                \"esn\":\"XXXXXXX\",\n" +
+            "                                \"vendor\":\"Huawei\",\n" +
+            "                                \"name\":\"CPE_Beijing\",\n" +
+            "                                \"type\":\"AR161\",\n" +
+            "                                \"version\":\"1.0\",\n" +
+            "                                \"class\":\"PNF\",\n" +
+            "                                \"systemIp\":\"20.20.20.2\"\n" +
+            "                            }\n" +
+            "                        ]\n" +
+            "                    }\n" +
+            "                ]\n" +
+            "            }\n" +
+            "        }\n" +
+            "    }\n" +
+            "}"
+
+    @Before
+    void setUp() {
+        super.init("DoCompareServiceInstanceData")
+    }
+
+    @Captor
+    static ArgumentCaptor<ExecutionEntity> captor = ArgumentCaptor.forClass(ExecutionEntity.class)
+
+    @Test
+    void testPreProcessRequest() {
+        mockData()
+        DoCompareServiceInstanceData csi = new DoCompareServiceInstanceData()
+        csi.preProcessRequest(mockExecution)
+    }
+
+    @Test(expected = BpmnError.class)
+    void testPreProcessRequestException() {
+        DoCompareServiceInstanceData csi = new DoCompareServiceInstanceData()
+        csi.preProcessRequest(mockExecution)
+    }
+
+    @Test
+    void testPrepareDecomposeService_Original() {
+        mockData()
+        DoCompareServiceInstanceData csi = new DoCompareServiceInstanceData()
+        csi.prepareDecomposeService_Original(mockExecution)
+        Mockito.verify(mockExecution, times(1)).setVariable(captor.capture(), captor.capture())
+        String serviceModelInfo = getServiceModelInfo()
+        assertThat(captor.getValue(), sameBeanAs(serviceModelInfo))
+    }
+
+    @Test
+    void testProcessDecomposition_Original() {
+        mockData()
+        DoCompareServiceInstanceData csi = new DoCompareServiceInstanceData()
+        csi.processDecomposition_Original(mockExecution)
+        Mockito.verify(mockExecution, times(1)).setVariable(captor.capture(), captor.capture())
+        ServiceDecomposition serviceDecomposition = getServiceDecomposition()
+        assertThat(captor.getValue(), sameBeanAs(serviceDecomposition))
+    }
+
+    @Test
+    void testDoCompareUuiRquestInput() {
+        mockData()
+        DoCompareServiceInstanceData csi = new DoCompareServiceInstanceData()
+        csi.doCompareUuiRquestInput(mockExecution)
+        Mockito.verify(mockExecution, times(4)).setVariable(captor.capture(), captor.capture())
+    }
+
+    private String getServiceModelInfo() {
+        String modelInvariantUuid = mockExecution.getVariable("model-invariant-id-original")
+        String modelUuid = mockExecution.getVariable("model-version-id-original")
+        String serviceModelInfo = """{
+            "modelInvariantUuid":"${modelInvariantUuid}",
+            "modelUuid":"${modelUuid}",
+            "modelVersion":""
+             }"""
+        serviceModelInfo
+    }
+
+    private void mockData() {
+        when(mockExecution.getVariable("isDebugLogEnabled")).thenReturn("true")
+        when(mockExecution.getVariable("msoRequestId")).thenReturn("12345")
+        when(mockExecution.getVariable("model-version-id-original")).thenReturn("12345")
+        when(mockExecution.getVariable("model-invariant-id-original")).thenReturn("12345")
+        when(mockExecution.getVariable("uuiRequest")).thenReturn(uuiSoString)
+        when(mockExecution.getVariable("serviceInstanceId")).thenReturn("1234")
+        when(mockExecution.getVariable("serviceInstanceData-original")).thenReturn(getExpectedServiceInstance())
+        when(mockExecution.getVariable("serviceDecomposition")).thenReturn(getServiceDecomposition())
+        when(mockExecution.getVariable("serviceDecomposition_Original")).thenReturn(getServiceDecomposition())
+    }
+
+    private ServiceDecomposition getServiceDecomposition() {
+        ServiceDecomposition decomposition = new ServiceDecomposition()
+        List<Resource> allSR_original = new ArrayList<>()
+        decomposition.setAllottedResources(allSR_original)
+        return decomposition
+    }
+
+    private ServiceInstance getExpectedServiceInstance() {
+        ServiceInstance expectedServiceInstanceData = new ServiceInstance()
+        expectedServiceInstanceData.setServiceInstanceId("1234")
+        expectedServiceInstanceData.setServiceInstanceName("volte-service")
+        expectedServiceInstanceData.setServiceType("E2E Service")
+        expectedServiceInstanceData.setServiceRole("E2E Service")
+        expectedServiceInstanceData.setInputParameters(uuiSoString)
+        return expectedServiceInstanceData
+    }
+}
index 446c73d..96c3db0 100644 (file)
@@ -27,12 +27,14 @@ import org.camunda.bpm.engine.runtime.MessageCorrelationBuilder;
 import org.junit.Before;
 import org.junit.Test;
 import org.mockito.InOrder;
+import org.onap.so.bpmn.infrastructure.pnf.PnfNotificationEvent;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.*;
 
 public class InformDmaapClientTest {
+
     @Before
     public void setUp() throws Exception {
         informDmaapClient = new InformDmaapClient();
@@ -71,6 +73,19 @@ public class InformDmaapClientTest {
         inOrder.verify(messageCorrelationBuilder).correlateWithResult();
     }
 
+    @Test
+    public void onApplicationEvent_validPnfNotificationEvent_expectedOutput() {
+
+        PnfNotificationEvent pnfNotificationEvent = new PnfNotificationEvent(this, "testPnfCorrelationId");
+
+        informDmaapClient.execute(delegateExecution);
+        informDmaapClient.onApplicationEvent(pnfNotificationEvent);
+
+        InOrder inOrder = inOrder(messageCorrelationBuilder);
+        inOrder.verify(messageCorrelationBuilder).processInstanceBusinessKey("testBusinessKey");
+        inOrder.verify(messageCorrelationBuilder).correlateWithResult();
+    }
+
     private DelegateExecution mockDelegateExecution() {
         DelegateExecution delegateExecution = mock(DelegateExecution.class);
         when(delegateExecution.getVariable(eq(ExecutionVariableNames.PNF_CORRELATION_ID)))
index ca3373e..9f31e2a 100644 (file)
@@ -25,8 +25,10 @@ package org.onap.so.bpmn.infrastructure.pnf.dmaap;
 
 import static org.junit.Assert.*;
 import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyObject;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.verifyZeroInteractions;
 import static org.mockito.Mockito.when;
@@ -47,9 +49,12 @@ import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.ArgumentCaptor;
+import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.junit.MockitoJUnitRunner;
+import org.onap.so.bpmn.infrastructure.pnf.PnfNotificationEvent;
 import org.onap.so.bpmn.infrastructure.pnf.dmaap.PnfEventReadyDmaapClient.DmaapTopicListenerThread;
+import org.springframework.context.ApplicationEventPublisher;
 import org.springframework.core.env.Environment;
 
 @RunWith(MockitoJUnitRunner.class)
@@ -80,6 +85,9 @@ public class PnfEventReadyDmaapClientTest {
     private Runnable threadMockToNotifyCamundaFlow;
     private ScheduledThreadPoolExecutor executorMock;
 
+    @Mock
+    private ApplicationEventPublisher applicationEventPublisher;
+
     @Before
     public void init() throws NoSuchFieldException, IllegalAccessException {
         when(env.getProperty(eq("pnf.dmaap.port"), eq(Integer.class))).thenReturn(PORT);
@@ -91,7 +99,7 @@ public class PnfEventReadyDmaapClientTest {
         when(env.getProperty(eq("pnf.dmaap.consumerGroup"))).thenReturn(CONSUMER_GROUP);
         when(env.getProperty(eq("pnf.dmaap.topicListenerDelayInSeconds"), eq(Integer.class)))
                 .thenReturn(TOPIC_LISTENER_DELAY_IN_SECONDS);
-        testedObject = new PnfEventReadyDmaapClient(env);
+        testedObject = new PnfEventReadyDmaapClient(env, applicationEventPublisher);
         testedObjectInnerClassThread = testedObject.new DmaapTopicListenerThread();
         httpClientMock = mock(HttpClient.class);
         threadMockToNotifyCamundaFlow = mock(Runnable.class);
@@ -123,7 +131,10 @@ public class PnfEventReadyDmaapClientTest {
         assertEquals(captor1.getValue().getURI().getPath(),
                 "/" + URI_PATH_PREFIX + "/" + EVENT_TOPIC_TEST + "/" + CONSUMER_GROUP + "/" + CONSUMER_ID + "");
 
-        // verify(threadMockToNotifyCamundaFlow).run();
+        /**
+         * Two PNF returned from HTTP request.
+         */
+        verify(applicationEventPublisher, times(2)).publishEvent(any(PnfNotificationEvent.class));
         verify(executorMock).shutdown();
     }
 
index e2488fd..345e0bb 100644 (file)
@@ -45,6 +45,7 @@ ex.processJavaException(execution)]]></bpmn:script>
         <camunda:in source="addResourceList" target="addResourceList" />
         <camunda:in source="delResourceList" target="delResourceList" />
         <camunda:in source="serviceRelationShip" target="serviceRelationShip" />
+        <camunda:in source="uuiRequest-del" target="uuiRequest-del" />
       </bpmn:extensionElements>
       <bpmn:incoming>SequenceFlow_04qwbbf</bpmn:incoming>
       <bpmn:outgoing>SequenceFlow_0klbpxx</bpmn:outgoing>
@@ -192,7 +193,7 @@ csi.postCompareModelVersions(execution)]]></bpmn:script>
     </bpmn:scriptTask>
     <bpmn:scriptTask id="ScriptTask_0hixtxc" name="Prepare for Compare Model Versions" scriptFormat="groovy">
       <bpmn:incoming>SequenceFlow_03i6zhx</bpmn:incoming>
-      <bpmn:outgoing>SequenceFlow_1pdv4qj</bpmn:outgoing>
+      <bpmn:outgoing>SequenceFlow_16jngfs</bpmn:outgoing>
       <bpmn:script><![CDATA[import org.onap.so.bpmn.infrastructure.scripts.*
 def ddsi = new UpdateCustomE2EServiceInstance()
 ddsi.preCompareModelVersions(execution)]]></bpmn:script>
@@ -210,11 +211,10 @@ ddsi.preCompareModelVersions(execution)]]></bpmn:script>
         <camunda:out source="addResourceList" target="addResourceList" />
         <camunda:out source="delResourceList" target="delResourceList" />
       </bpmn:extensionElements>
-      <bpmn:incoming>SequenceFlow_1pdv4qj</bpmn:incoming>
+      <bpmn:incoming>SequenceFlow_1bvnbfu</bpmn:incoming>
       <bpmn:outgoing>SequenceFlow_0xhbobd</bpmn:outgoing>
     </bpmn:callActivity>
     <bpmn:sequenceFlow id="SequenceFlow_03i6zhx" sourceRef="ScriptTask_0cx1y0g" targetRef="ScriptTask_0hixtxc" />
-    <bpmn:sequenceFlow id="SequenceFlow_1pdv4qj" sourceRef="ScriptTask_0hixtxc" targetRef="CallActivity_1rkoyc5" />
     <bpmn:sequenceFlow id="SequenceFlow_0xhbobd" sourceRef="CallActivity_1rkoyc5" targetRef="ScriptTask_11y3uq6" />
     <bpmn:exclusiveGateway id="ExclusiveGateway_0mc34qe" name="HasResourcetoUpdate?" default="SequenceFlow_1n8h3zt">
       <bpmn:incoming>SequenceFlow_0secadm</bpmn:incoming>
@@ -315,14 +315,54 @@ ddsi.preUpdateServiceOperationStatus(execution)]]></bpmn:script>
       <bpmn:conditionExpression xsi:type="bpmn:tFormalExpression"><![CDATA[#{execution.getVariable("hasResourcetoUpdate") == true}]]></bpmn:conditionExpression>
     </bpmn:sequenceFlow>
     <bpmn:sequenceFlow id="SequenceFlow_1n8h3zt" name="No" sourceRef="ExclusiveGateway_0mc34qe" targetRef="ScriptTask_04a0t3p" />
+    <bpmn:exclusiveGateway id="ExclusiveGateway_0o2r7np" name="IsServiceInstanceModification?" default="SequenceFlow_1bvnbfu">
+      <bpmn:incoming>SequenceFlow_16jngfs</bpmn:incoming>
+      <bpmn:outgoing>SequenceFlow_1bvnbfu</bpmn:outgoing>
+      <bpmn:outgoing>SequenceFlow_1po82kn</bpmn:outgoing>
+    </bpmn:exclusiveGateway>
+    <bpmn:sequenceFlow id="SequenceFlow_16jngfs" sourceRef="ScriptTask_0hixtxc" targetRef="ExclusiveGateway_0o2r7np" />
+    <bpmn:sequenceFlow id="SequenceFlow_1bvnbfu" name="No" sourceRef="ExclusiveGateway_0o2r7np" targetRef="CallActivity_1rkoyc5" />
+    <bpmn:sequenceFlow id="SequenceFlow_1po82kn" name="Yes" sourceRef="ExclusiveGateway_0o2r7np" targetRef="Task_1ktxr5y">
+      <bpmn:conditionExpression xsi:type="bpmn:tFormalExpression"><![CDATA[#{execution.getVariable("model-version-id-original") == execution.getVariable("model-version-id-target") && execution.getVariable("model-invariant-id-original") == execution.getVariable("model-invariant-id-target")}]]></bpmn:conditionExpression>
+    </bpmn:sequenceFlow>
+    <bpmn:callActivity id="Task_1ktxr5y" name="Call DoCompareServiceInstanceData" calledElement="DoCompareServiceInstanceData">
+      <bpmn:extensionElements>
+        <camunda:in source="serviceInstanceData-original" target="serviceInstanceData-original" />
+        <camunda:in source="serviceInstanceId" target="serviceInstanceId" />
+        <camunda:in source="uuiRequest" target="uuiRequest" />
+        <camunda:out source="addResourceList" target="addResourceList" />
+        <camunda:out source="delResourceList" target="delResourceList" />
+        <camunda:out source="uuiRequest" target="uuiRequest" />
+        <camunda:out source="uuiRequest-del" target="uuiRequest-del" />
+        <camunda:in source="model-invariant-id-original" target="model-invariant-id-original" />
+        <camunda:in source="model-version-id-original" target="model-version-id-original" />
+        <camunda:in source="msoRequestId" target="msoRequestId" />
+        <camunda:in source="isDebugLogEnabled" target="isDebugLogEnabled" />
+      </bpmn:extensionElements>
+      <bpmn:incoming>SequenceFlow_1po82kn</bpmn:incoming>
+      <bpmn:outgoing>SequenceFlow_0gqpsvb</bpmn:outgoing>
+    </bpmn:callActivity>
+    <bpmn:sequenceFlow id="SequenceFlow_0gqpsvb" sourceRef="Task_1ktxr5y" targetRef="Task_1xbq4e3" />
+    <bpmn:intermediateThrowEvent id="IntermediateThrowEvent_01jy2z3" name="GoToOperStatusInit">
+      <bpmn:incoming>SequenceFlow_0qe8uv2</bpmn:incoming>
+      <bpmn:linkEventDefinition name="StartOperStatusInit" />
+    </bpmn:intermediateThrowEvent>
+    <bpmn:sequenceFlow id="SequenceFlow_0qe8uv2" sourceRef="Task_1xbq4e3" targetRef="IntermediateThrowEvent_01jy2z3" />
+    <bpmn:scriptTask id="Task_1xbq4e3" name="Post for Compare Service Instance Data" scriptFormat="groovy">
+      <bpmn:incoming>SequenceFlow_0gqpsvb</bpmn:incoming>
+      <bpmn:outgoing>SequenceFlow_0qe8uv2</bpmn:outgoing>
+      <bpmn:script><![CDATA[import org.onap.so.bpmn.infrastructure.scripts.*
+def csi = new UpdateCustomE2EServiceInstance()
+csi.postCompareModelVersions(execution)]]></bpmn:script>
+    </bpmn:scriptTask>
   </bpmn:process>
   <bpmn:error id="Error_0nbdy47" name="MSOWorkflowException" errorCode="MSOWorkflowException" />
   <bpmndi:BPMNDiagram id="BPMNDiagram_1">
     <bpmndi:BPMNPlane id="BPMNPlane_1" bpmnElement="UpdateCustomE2EServiceInstance">
       <bpmndi:BPMNShape id="StartEvent_00qj6ro_di" bpmnElement="StartEvent_00qj6ro">
-        <dc:Bounds x="-6" y="180" width="36" height="36" />
+        <dc:Bounds x="-6" y="135" width="36" height="36" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="-24" y="221" width="73" height="24" />
+          <dc:Bounds x="-25" y="176" width="75" height="24" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="SubProcess_0ka59nc_di" bpmnElement="SubProcess_0ka59nc" isExpanded="true">
@@ -338,7 +378,7 @@ ddsi.preUpdateServiceOperationStatus(execution)]]></bpmn:script>
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="ScriptTask_1s09c7d_di" bpmnElement="ScriptTask_1s09c7d">
-        <dc:Bounds x="147" y="158" width="100" height="80" />
+        <dc:Bounds x="107" y="113" width="100" height="80" />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="ScriptTask_0ttvn8r_di" bpmnElement="ScriptTask_0ttvn8r">
         <dc:Bounds x="782" y="585" width="100" height="80" />
@@ -350,7 +390,7 @@ ddsi.preUpdateServiceOperationStatus(execution)]]></bpmn:script>
         <dc:Bounds x="-61" y="908" width="1322" height="164" />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="ScriptTask_0xupxj9_di" bpmnElement="ScriptTask_0xupxj9">
-        <dc:Bounds x="451" y="337" width="100" height="80" />
+        <dc:Bounds x="451" y="362" width="100" height="80" />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="ExclusiveGateway_0aqn64l_di" bpmnElement="ExclusiveGateway_0aqn64l" isMarkerVisible="true">
         <dc:Bounds x="639" y="600" width="50" height="50" />
@@ -365,10 +405,10 @@ ddsi.preUpdateServiceOperationStatus(execution)]]></bpmn:script>
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNShape>
       <bpmndi:BPMNEdge id="SequenceFlow_0s2spoq_di" bpmnElement="SequenceFlow_0s2spoq">
-        <di:waypoint xsi:type="dc:Point" x="30" y="198" />
-        <di:waypoint xsi:type="dc:Point" x="147" y="198" />
+        <di:waypoint xsi:type="dc:Point" x="30" y="153" />
+        <di:waypoint xsi:type="dc:Point" x="107" y="153" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="43.5" y="177" width="90" height="12" />
+          <dc:Bounds x="23.5" y="132" width="90" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNEdge id="SequenceFlow_0klbpxx_di" bpmnElement="SequenceFlow_0klbpxx">
@@ -485,49 +525,42 @@ ddsi.preUpdateServiceOperationStatus(execution)]]></bpmn:script>
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNShape id="ScriptTask_0cx1y0g_di" bpmnElement="ScriptTask_0cx1y0g">
-        <dc:Bounds x="364" y="158" width="100" height="80" />
+        <dc:Bounds x="251" y="113" width="100" height="80" />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="ScriptTask_11y3uq6_di" bpmnElement="ScriptTask_11y3uq6">
-        <dc:Bounds x="959" y="158" width="100" height="80" />
+        <dc:Bounds x="959" y="113" width="100" height="80" />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="ScriptTask_0hixtxc_di" bpmnElement="ScriptTask_0hixtxc">
-        <dc:Bounds x="563" y="158" width="100" height="80" />
+        <dc:Bounds x="422" y="113" width="100" height="80" />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="CallActivity_1rkoyc5_di" bpmnElement="CallActivity_1rkoyc5">
-        <dc:Bounds x="782" y="158" width="100" height="80" />
+        <dc:Bounds x="782" y="113" width="100" height="80" />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNEdge id="SequenceFlow_03i6zhx_di" bpmnElement="SequenceFlow_03i6zhx">
-        <di:waypoint xsi:type="dc:Point" x="464" y="198" />
-        <di:waypoint xsi:type="dc:Point" x="563" y="198" />
+        <di:waypoint xsi:type="dc:Point" x="351" y="153" />
+        <di:waypoint xsi:type="dc:Point" x="422" y="153" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="468.5" y="177" width="90" height="12" />
-        </bpmndi:BPMNLabel>
-      </bpmndi:BPMNEdge>
-      <bpmndi:BPMNEdge id="SequenceFlow_1pdv4qj_di" bpmnElement="SequenceFlow_1pdv4qj">
-        <di:waypoint xsi:type="dc:Point" x="663" y="198" />
-        <di:waypoint xsi:type="dc:Point" x="782" y="198" />
-        <bpmndi:BPMNLabel>
-          <dc:Bounds x="677.5" y="177" width="90" height="12" />
+          <dc:Bounds x="341.5" y="132" width="90" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNEdge id="SequenceFlow_0xhbobd_di" bpmnElement="SequenceFlow_0xhbobd">
-        <di:waypoint xsi:type="dc:Point" x="882" y="198" />
-        <di:waypoint xsi:type="dc:Point" x="959" y="198" />
+        <di:waypoint xsi:type="dc:Point" x="882" y="153" />
+        <di:waypoint xsi:type="dc:Point" x="959" y="153" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="875.5" y="177" width="90" height="12" />
+          <dc:Bounds x="876" y="132" width="90" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNShape id="ExclusiveGateway_0mc34qe_di" bpmnElement="ExclusiveGateway_0mc34qe" isMarkerVisible="true">
-        <dc:Bounds x="639" y="352" width="50" height="50" />
+        <dc:Bounds x="639" y="377" width="50" height="50" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="622" y="324" width="85" height="24" />
+          <dc:Bounds x="622" y="349" width="85" height="24" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNShape>
       <bpmndi:BPMNEdge id="SequenceFlow_0az1n4y_di" bpmnElement="SequenceFlow_0az1n4y">
-        <di:waypoint xsi:type="dc:Point" x="247" y="198" />
-        <di:waypoint xsi:type="dc:Point" x="364" y="198" />
+        <di:waypoint xsi:type="dc:Point" x="207" y="153" />
+        <di:waypoint xsi:type="dc:Point" x="251" y="153" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="260.5" y="177" width="90" height="12" />
+          <dc:Bounds x="184" y="132" width="90" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNShape id="IntermediateCatchEvent_0m01dm3_di" bpmnElement="IntermediateCatchEvent_0m01dm3">
@@ -537,10 +570,10 @@ ddsi.preUpdateServiceOperationStatus(execution)]]></bpmn:script>
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNShape>
       <bpmndi:BPMNEdge id="SequenceFlow_0secadm_di" bpmnElement="SequenceFlow_0secadm">
-        <di:waypoint xsi:type="dc:Point" x="551" y="377" />
-        <di:waypoint xsi:type="dc:Point" x="639" y="377" />
+        <di:waypoint xsi:type="dc:Point" x="551" y="402" />
+        <di:waypoint xsi:type="dc:Point" x="639" y="402" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="550" y="356" width="90" height="12" />
+          <dc:Bounds x="550" y="381" width="90" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNEdge id="SequenceFlow_04qwbbf_di" bpmnElement="SequenceFlow_04qwbbf">
@@ -551,58 +584,58 @@ ddsi.preUpdateServiceOperationStatus(execution)]]></bpmn:script>
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNShape id="EndEvent_1jvqhkf_di" bpmnElement="EndEvent_1jvqhkf">
-        <dc:Bounds x="1192" y="359" width="36" height="36" />
+        <dc:Bounds x="1192" y="384" width="36" height="36" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="1200" y="404" width="19" height="12" />
+          <dc:Bounds x="1200" y="429" width="19" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="ScriptTask_16sgdqw_di" bpmnElement="ScriptTask_16sgdqw">
-        <dc:Bounds x="97" y="337" width="100" height="80" />
+        <dc:Bounds x="97" y="362" width="100" height="80" />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="ServiceTask_0qjpd5v_di" bpmnElement="ServiceTask_0qjpd5v">
-        <dc:Bounds x="274" y="337" width="100" height="80" />
+        <dc:Bounds x="274" y="362" width="100" height="80" />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNEdge id="SequenceFlow_1e3vtyq_di" bpmnElement="SequenceFlow_1e3vtyq">
-        <di:waypoint xsi:type="dc:Point" x="197" y="377" />
-        <di:waypoint xsi:type="dc:Point" x="274" y="377" />
+        <di:waypoint xsi:type="dc:Point" x="197" y="402" />
+        <di:waypoint xsi:type="dc:Point" x="274" y="402" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="235.5" y="356" width="0" height="12" />
+          <dc:Bounds x="191" y="381" width="90" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNEdge id="SequenceFlow_12dou7o_di" bpmnElement="SequenceFlow_12dou7o">
-        <di:waypoint xsi:type="dc:Point" x="374" y="377" />
-        <di:waypoint xsi:type="dc:Point" x="451" y="377" />
+        <di:waypoint xsi:type="dc:Point" x="374" y="402" />
+        <di:waypoint xsi:type="dc:Point" x="451" y="402" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="412.5" y="356" width="0" height="12" />
+          <dc:Bounds x="368" y="381" width="90" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNShape id="ServiceTask_0mj3kf2_di" bpmnElement="ServiceTask_0mj3kf2">
-        <dc:Bounds x="959" y="337" width="100" height="80" />
+        <dc:Bounds x="959" y="362" width="100" height="80" />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="IntermediateThrowEvent_08mk8h9_di" bpmnElement="IntermediateThrowEvent_08mk8h9">
-        <dc:Bounds x="1192" y="180" width="36" height="36" />
+        <dc:Bounds x="1192" y="135" width="36" height="36" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="1175" y="220" width="86" height="24" />
+          <dc:Bounds x="1175" y="175" width="86" height="24" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNShape>
       <bpmndi:BPMNEdge id="SequenceFlow_0t7zinj_di" bpmnElement="SequenceFlow_0t7zinj">
-        <di:waypoint xsi:type="dc:Point" x="1059" y="198" />
-        <di:waypoint xsi:type="dc:Point" x="1192" y="198" />
+        <di:waypoint xsi:type="dc:Point" x="1059" y="153" />
+        <di:waypoint xsi:type="dc:Point" x="1192" y="153" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="1125.5" y="177" width="0" height="12" />
+          <dc:Bounds x="1081" y="132" width="90" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNShape id="IntermediateCatchEvent_14w7v9s_di" bpmnElement="IntermediateCatchEvent_14w7v9s">
-        <dc:Bounds x="-6" y="359" width="36" height="36" />
+        <dc:Bounds x="-6" y="384" width="36" height="36" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="-29" y="421" width="88" height="24" />
+          <dc:Bounds x="-29" y="446" width="88" height="24" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNShape>
       <bpmndi:BPMNEdge id="SequenceFlow_1bddzne_di" bpmnElement="SequenceFlow_1bddzne">
-        <di:waypoint xsi:type="dc:Point" x="30" y="377" />
-        <di:waypoint xsi:type="dc:Point" x="97" y="377" />
+        <di:waypoint xsi:type="dc:Point" x="30" y="402" />
+        <di:waypoint xsi:type="dc:Point" x="97" y="402" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="63.5" y="356" width="0" height="12" />
+          <dc:Bounds x="19" y="381" width="90" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNShape id="ScriptTask_14kqo0r_di" bpmnElement="ScriptTask_14kqo0r">
@@ -626,42 +659,96 @@ ddsi.preUpdateServiceOperationStatus(execution)]]></bpmn:script>
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNShape id="ScriptTask_04a0t3p_di" bpmnElement="ScriptTask_04a0t3p">
-        <dc:Bounds x="782" y="337" width="100" height="80" />
+        <dc:Bounds x="782" y="362" width="100" height="80" />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNEdge id="SequenceFlow_1wzk6tu_di" bpmnElement="SequenceFlow_1wzk6tu">
-        <di:waypoint xsi:type="dc:Point" x="882" y="377" />
-        <di:waypoint xsi:type="dc:Point" x="959" y="377" />
+        <di:waypoint xsi:type="dc:Point" x="882" y="402" />
+        <di:waypoint xsi:type="dc:Point" x="959" y="402" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="920.5" y="356" width="0" height="12" />
+          <dc:Bounds x="876" y="381" width="90" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNShape id="IntermediateThrowEvent_1k72hze_di" bpmnElement="IntermediateThrowEvent_1k72hze">
-        <dc:Bounds x="646" y="447" width="36" height="36" />
+        <dc:Bounds x="646" y="472" width="36" height="36" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="631" y="487" width="76" height="12" />
+          <dc:Bounds x="631" y="512" width="76" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNShape>
       <bpmndi:BPMNEdge id="SequenceFlow_0kvl23y_di" bpmnElement="SequenceFlow_0kvl23y">
-        <di:waypoint xsi:type="dc:Point" x="1059" y="377" />
-        <di:waypoint xsi:type="dc:Point" x="1192" y="377" />
+        <di:waypoint xsi:type="dc:Point" x="1059" y="402" />
+        <di:waypoint xsi:type="dc:Point" x="1192" y="402" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="1125.5" y="356" width="0" height="12" />
+          <dc:Bounds x="1081" y="381" width="90" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNEdge id="SequenceFlow_0zmd4rt_di" bpmnElement="SequenceFlow_0zmd4rt">
-        <di:waypoint xsi:type="dc:Point" x="664" y="402" />
-        <di:waypoint xsi:type="dc:Point" x="664" y="447" />
+        <di:waypoint xsi:type="dc:Point" x="664" y="427" />
+        <di:waypoint xsi:type="dc:Point" x="664" y="472" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="670" y="419" width="19" height="12" />
+          <dc:Bounds x="670" y="444" width="19" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNEdge id="SequenceFlow_1n8h3zt_di" bpmnElement="SequenceFlow_1n8h3zt">
-        <di:waypoint xsi:type="dc:Point" x="689" y="377" />
-        <di:waypoint xsi:type="dc:Point" x="782" y="377" />
+        <di:waypoint xsi:type="dc:Point" x="689" y="402" />
+        <di:waypoint xsi:type="dc:Point" x="782" y="402" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="729" y="356" width="14" height="12" />
+          <dc:Bounds x="729" y="381" width="14" height="12" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
+      <bpmndi:BPMNShape id="ExclusiveGateway_0o2r7np_di" bpmnElement="ExclusiveGateway_0o2r7np" isMarkerVisible="true">
+        <dc:Bounds x="628.6452095808384" y="128.09730538922156" width="50" height="50" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="611" y="182" width="88" height="24" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNEdge id="SequenceFlow_16jngfs_di" bpmnElement="SequenceFlow_16jngfs">
+        <di:waypoint xsi:type="dc:Point" x="522" y="153" />
+        <di:waypoint xsi:type="dc:Point" x="629" y="153" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="575.5" y="132" width="0" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
+      <bpmndi:BPMNEdge id="SequenceFlow_1bvnbfu_di" bpmnElement="SequenceFlow_1bvnbfu">
+        <di:waypoint xsi:type="dc:Point" x="679" y="153" />
+        <di:waypoint xsi:type="dc:Point" x="782" y="153" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="724" y="132" width="14" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
+      <bpmndi:BPMNEdge id="SequenceFlow_1po82kn_di" bpmnElement="SequenceFlow_1po82kn">
+        <di:waypoint xsi:type="dc:Point" x="654" y="178" />
+        <di:waypoint xsi:type="dc:Point" x="654" y="267" />
+        <di:waypoint xsi:type="dc:Point" x="782" y="267" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="660" y="217" width="19" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
+      <bpmndi:BPMNShape id="CallActivity_0vnoaee_di" bpmnElement="Task_1ktxr5y">
+        <dc:Bounds x="782" y="227" width="100" height="80" />
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNEdge id="SequenceFlow_0gqpsvb_di" bpmnElement="SequenceFlow_0gqpsvb">
+        <di:waypoint xsi:type="dc:Point" x="882" y="267" />
+        <di:waypoint xsi:type="dc:Point" x="959" y="267" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="920.5" y="246" width="0" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
+      <bpmndi:BPMNShape id="IntermediateThrowEvent_01jy2z3_di" bpmnElement="IntermediateThrowEvent_01jy2z3">
+        <dc:Bounds x="1192" y="249" width="36" height="36" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="1175" y="289" width="86" height="24" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNEdge id="SequenceFlow_0qe8uv2_di" bpmnElement="SequenceFlow_0qe8uv2">
+        <di:waypoint xsi:type="dc:Point" x="1059" y="267" />
+        <di:waypoint xsi:type="dc:Point" x="1192" y="267" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="1125.5" y="246" width="0" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
+      <bpmndi:BPMNShape id="ScriptTask_179xmbe_di" bpmnElement="Task_1xbq4e3">
+        <dc:Bounds x="959" y="227" width="100" height="80" />
+      </bpmndi:BPMNShape>
     </bpmndi:BPMNPlane>
   </bpmndi:BPMNDiagram>
 </bpmn:definitions>
diff --git a/bpmn/so-bpmn-infrastructure-flows/src/main/resources/subprocess/DoCompareServiceInstanceData.bpmn b/bpmn/so-bpmn-infrastructure-flows/src/main/resources/subprocess/DoCompareServiceInstanceData.bpmn
new file mode 100644 (file)
index 0000000..6e5032a
--- /dev/null
@@ -0,0 +1,241 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<bpmn2:definitions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:bpmn2="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:camunda="http://camunda.org/schema/1.0/bpmn" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:di="http://www.omg.org/spec/DD/20100524/DI" id="_MagIIMOUEeW8asg-vCEgWQ" targetNamespace="http://camunda.org/schema/1.0/bpmn" exporter="Camunda Modeler" exporterVersion="1.10.0" xsi:schemaLocation="http://www.omg.org/spec/BPMN/20100524/MODEL BPMN20.xsd">
+  <bpmn2:process id="DoCompareServiceInstanceData" name="DoCompareServiceInstanceData" isExecutable="true">
+    <bpmn2:scriptTask id="ScriptTask_04rn9mp" name="DoCompareServiceInstanceData" scriptFormat="groovy">
+      <bpmn2:incoming>SequenceFlow_1rebkae</bpmn2:incoming>
+      <bpmn2:outgoing>SequenceFlow_1lkpfe2</bpmn2:outgoing>
+      <bpmn2:script><![CDATA[import org.onap.so.bpmn.infrastructure.scripts.*
+def csi = new  DoCompareServiceInstanceData()
+csi.doCompareUuiRquestInput(execution)]]></bpmn2:script>
+    </bpmn2:scriptTask>
+    <bpmn2:sequenceFlow id="SequenceFlow_1rebkae" sourceRef="StartEvent_0jhv664" targetRef="ScriptTask_04rn9mp" />
+    <bpmn2:intermediateCatchEvent id="StartEvent_0jhv664" name="StartCompare">
+      <bpmn2:outgoing>SequenceFlow_1rebkae</bpmn2:outgoing>
+      <bpmn2:linkEventDefinition name="StartCompare" />
+    </bpmn2:intermediateCatchEvent>
+    <bpmn2:endEvent id="EndEvent_0x8im5g">
+      <bpmn2:incoming>SequenceFlow_1lkpfe2</bpmn2:incoming>
+    </bpmn2:endEvent>
+    <bpmn2:sequenceFlow id="SequenceFlow_1lkpfe2" sourceRef="ScriptTask_04rn9mp" targetRef="EndEvent_0x8im5g" />
+    <bpmn2:subProcess id="SubProcess_0roysbg" name="Sub-process for UnexpectedErrors" triggeredByEvent="true">
+      <bpmn2:startEvent id="StartEvent_0xtpw6j">
+        <bpmn2:outgoing>SequenceFlow_19sogyb</bpmn2:outgoing>
+        <bpmn2:errorEventDefinition />
+      </bpmn2:startEvent>
+      <bpmn2:endEvent id="EndEvent_05a2pr9">
+        <bpmn2:incoming>SequenceFlow_17mr4jl</bpmn2:incoming>
+      </bpmn2:endEvent>
+      <bpmn2:scriptTask id="ScriptTask_0xk9fk3" name="Log / Print Unexpected Error" scriptFormat="groovy">
+        <bpmn2:incoming>SequenceFlow_19sogyb</bpmn2:incoming>
+        <bpmn2:outgoing>SequenceFlow_17mr4jl</bpmn2:outgoing>
+        <bpmn2:script><![CDATA[import org.onap.so.bpmn.common.scripts.*
+ExceptionUtil ex = new ExceptionUtil()
+ex.processJavaException(execution)]]></bpmn2:script>
+      </bpmn2:scriptTask>
+      <bpmn2:sequenceFlow id="SequenceFlow_19sogyb" name="" sourceRef="StartEvent_0xtpw6j" targetRef="ScriptTask_0xk9fk3" />
+      <bpmn2:sequenceFlow id="SequenceFlow_17mr4jl" name="" sourceRef="ScriptTask_0xk9fk3" targetRef="EndEvent_05a2pr9" />
+    </bpmn2:subProcess>
+    <bpmn2:intermediateThrowEvent id="IntermediateThrowEvent_0se5nzs" name="GoTo Decompose_Service_Original">
+      <bpmn2:incoming>SequenceFlow_1o9916j</bpmn2:incoming>
+      <bpmn2:linkEventDefinition name="Decompose_Service_Original" />
+    </bpmn2:intermediateThrowEvent>
+    <bpmn2:intermediateThrowEvent id="IntermediateThrowEvent_0b436w1" name="GoTo StartCompare">
+      <bpmn2:incoming>SequenceFlow_08zjjzw</bpmn2:incoming>
+      <bpmn2:linkEventDefinition name="StartCompare" />
+    </bpmn2:intermediateThrowEvent>
+    <bpmn2:scriptTask id="ScriptTask_1d9qb54" name="PostProcess&#10;Decompose&#10;Service&#10;" scriptFormat="groovy">
+      <bpmn2:incoming>SequenceFlow_1wudpuj</bpmn2:incoming>
+      <bpmn2:outgoing>SequenceFlow_08zjjzw</bpmn2:outgoing>
+      <bpmn2:script><![CDATA[import org.onap.so.bpmn.infrastructure.scripts.*
+def dcsi= new DoCompareServiceInstanceData()
+dcsi.processDecomposition_Original(execution)]]></bpmn2:script>
+    </bpmn2:scriptTask>
+    <bpmn2:callActivity id="CallActivity_1fc56sd" name="Call Decompose Service" calledElement="DecomposeService">
+      <bpmn2:extensionElements>
+        <camunda:in source="msoRequestId" target="msoRequestId" />
+        <camunda:in source="serviceInstanceId" target="serviceInstanceId" />
+        <camunda:in source="serviceModelInfo_Original" target="serviceModelInfo" />
+        <camunda:in source="isDebugLogEnabled" target="isDebugLogEnabled" />
+        <camunda:out source="serviceDecomposition" target="serviceDecomposition" />
+        <camunda:out source="WorkflowException" target="WorkflowException" />
+      </bpmn2:extensionElements>
+      <bpmn2:incoming>SequenceFlow_04ciw70</bpmn2:incoming>
+      <bpmn2:outgoing>SequenceFlow_1wudpuj</bpmn2:outgoing>
+    </bpmn2:callActivity>
+    <bpmn2:scriptTask id="ScriptTask_1i06996" name="Prepare&#10;Decompose&#10;Service&#10;" scriptFormat="groovy">
+      <bpmn2:incoming>SequenceFlow_1fgkvpr</bpmn2:incoming>
+      <bpmn2:outgoing>SequenceFlow_04ciw70</bpmn2:outgoing>
+      <bpmn2:script><![CDATA[import org.onap.so.bpmn.infrastructure.scripts.*
+def dcsi= new DoCompareServiceInstanceData()
+dcsi.prepareDecomposeService_Original(execution)]]></bpmn2:script>
+    </bpmn2:scriptTask>
+    <bpmn2:intermediateCatchEvent id="IntermediateCatchEvent_1m9q0j7" name="Decompose_Service_Original">
+      <bpmn2:outgoing>SequenceFlow_1fgkvpr</bpmn2:outgoing>
+      <bpmn2:linkEventDefinition name="Decompose_Service_Original" />
+    </bpmn2:intermediateCatchEvent>
+    <bpmn2:sequenceFlow id="SequenceFlow_08zjjzw" sourceRef="ScriptTask_1d9qb54" targetRef="IntermediateThrowEvent_0b436w1" />
+    <bpmn2:sequenceFlow id="SequenceFlow_1wudpuj" sourceRef="CallActivity_1fc56sd" targetRef="ScriptTask_1d9qb54" />
+    <bpmn2:sequenceFlow id="SequenceFlow_04ciw70" sourceRef="ScriptTask_1i06996" targetRef="CallActivity_1fc56sd" />
+    <bpmn2:sequenceFlow id="SequenceFlow_1fgkvpr" sourceRef="IntermediateCatchEvent_1m9q0j7" targetRef="ScriptTask_1i06996" />
+    <bpmn2:startEvent id="StartEvent_13da9hl" name="Start Flow">
+      <bpmn2:outgoing>SequenceFlow_1chfao3</bpmn2:outgoing>
+    </bpmn2:startEvent>
+    <bpmn2:scriptTask id="ScriptTask_0nie46r" name="PreProcess Incoming Request" scriptFormat="groovy">
+      <bpmn2:incoming>SequenceFlow_1chfao3</bpmn2:incoming>
+      <bpmn2:outgoing>SequenceFlow_1o9916j</bpmn2:outgoing>
+      <bpmn2:script><![CDATA[import org.onap.so.bpmn.infrastructure.scripts.*
+def dcsi = new DoCompareServiceInstanceData()
+dcsi.preProcessRequest(execution)
+]]></bpmn2:script>
+    </bpmn2:scriptTask>
+    <bpmn2:sequenceFlow id="SequenceFlow_1chfao3" name="" sourceRef="StartEvent_13da9hl" targetRef="ScriptTask_0nie46r" />
+    <bpmn2:sequenceFlow id="SequenceFlow_1o9916j" sourceRef="ScriptTask_0nie46r" targetRef="IntermediateThrowEvent_0se5nzs" />
+  </bpmn2:process>
+  <bpmn2:error id="Error_2" name="MSOWorkflowException" errorCode="MSOWorkflowException" />
+  <bpmn2:error id="Error_1" name="java.lang.Exception" errorCode="java.lang.Exception" />
+  <bpmndi:BPMNDiagram id="BPMNDiagram_1">
+    <bpmndi:BPMNPlane id="BPMNPlane_1" bpmnElement="DoCompareServiceInstanceData">
+      <bpmndi:BPMNShape id="ScriptTask_04rn9mp_di" bpmnElement="ScriptTask_04rn9mp">
+        <dc:Bounds x="426" y="426" width="100" height="80" />
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNEdge id="SequenceFlow_1rebkae_di" bpmnElement="SequenceFlow_1rebkae">
+        <di:waypoint xsi:type="dc:Point" x="10" y="466" />
+        <di:waypoint xsi:type="dc:Point" x="426" y="466" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="173" y="445" width="90" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
+      <bpmndi:BPMNShape id="IntermediateCatchEvent_05z1jyy_di" bpmnElement="StartEvent_0jhv664">
+        <dc:Bounds x="-26" y="448" width="36" height="36" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="-42" y="488" width="68" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNShape id="EndEvent_0x8im5g_di" bpmnElement="EndEvent_0x8im5g">
+        <dc:Bounds x="1040" y="448" width="36" height="36" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="1013" y="488" width="90" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNEdge id="SequenceFlow_1lkpfe2_di" bpmnElement="SequenceFlow_1lkpfe2">
+        <di:waypoint xsi:type="dc:Point" x="526" y="466" />
+        <di:waypoint xsi:type="dc:Point" x="1040" y="466" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="738" y="445" width="90" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
+      <bpmndi:BPMNShape id="SubProcess_0roysbg_di" bpmnElement="SubProcess_0roysbg" isExpanded="true">
+        <dc:Bounds x="221" y="751" width="467" height="193" />
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNShape id="StartEvent_0xtpw6j_di" bpmnElement="StartEvent_0xtpw6j">
+        <dc:Bounds x="289" y="818" width="36" height="36" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="172" y="859" width="90" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNShape id="EndEvent_05a2pr9_di" bpmnElement="EndEvent_05a2pr9">
+        <dc:Bounds x="582" y="818" width="36" height="36" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="465" y="859" width="90" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNShape id="ScriptTask_0xk9fk3_di" bpmnElement="ScriptTask_0xk9fk3">
+        <dc:Bounds x="393" y="796" width="100" height="80" />
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNEdge id="SequenceFlow_19sogyb_di" bpmnElement="SequenceFlow_19sogyb">
+        <di:waypoint xsi:type="dc:Point" x="325" y="836" />
+        <di:waypoint xsi:type="dc:Point" x="393" y="836" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="224" y="821" width="90" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
+      <bpmndi:BPMNEdge id="SequenceFlow_17mr4jl_di" bpmnElement="SequenceFlow_17mr4jl">
+        <di:waypoint xsi:type="dc:Point" x="493" y="836" />
+        <di:waypoint xsi:type="dc:Point" x="582" y="836" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="405" y="821" width="90" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
+      <bpmndi:BPMNShape id="IntermediateThrowEvent_0se5nzs_di" bpmnElement="IntermediateThrowEvent_0se5nzs">
+        <dc:Bounds x="1047" y="83" width="36" height="36" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="1021" y="124" width="88" height="36" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNShape id="IntermediateThrowEvent_0b436w1_di" bpmnElement="IntermediateThrowEvent_0b436w1">
+        <dc:Bounds x="1047" y="311" width="36" height="36" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="1032" y="352" width="68" height="24" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNShape id="ScriptTask_1d9qb54_di" bpmnElement="ScriptTask_1d9qb54">
+        <dc:Bounds x="711" y="290" width="100" height="80" />
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNShape id="CallActivity_1fc56sd_di" bpmnElement="CallActivity_1fc56sd">
+        <dc:Bounds x="426" y="290" width="100" height="80" />
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNShape id="ScriptTask_1i06996_di" bpmnElement="ScriptTask_1i06996">
+        <dc:Bounds x="144" y="290" width="100" height="80" />
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNShape id="IntermediateCatchEvent_1m9q0j7_di" bpmnElement="IntermediateCatchEvent_1m9q0j7">
+        <dc:Bounds x="-26" y="312" width="36" height="36" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="-50" y="348" width="88" height="24" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNEdge id="SequenceFlow_08zjjzw_di" bpmnElement="SequenceFlow_08zjjzw">
+        <di:waypoint xsi:type="dc:Point" x="811" y="330" />
+        <di:waypoint xsi:type="dc:Point" x="1047" y="329" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="929" y="308.5" width="0" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
+      <bpmndi:BPMNEdge id="SequenceFlow_1wudpuj_di" bpmnElement="SequenceFlow_1wudpuj">
+        <di:waypoint xsi:type="dc:Point" x="526" y="330" />
+        <di:waypoint xsi:type="dc:Point" x="711" y="330" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="618.5" y="309" width="0" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
+      <bpmndi:BPMNEdge id="SequenceFlow_04ciw70_di" bpmnElement="SequenceFlow_04ciw70">
+        <di:waypoint xsi:type="dc:Point" x="244" y="330" />
+        <di:waypoint xsi:type="dc:Point" x="426" y="330" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="245" y="309" width="0" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
+      <bpmndi:BPMNEdge id="SequenceFlow_1fgkvpr_di" bpmnElement="SequenceFlow_1fgkvpr">
+        <di:waypoint xsi:type="dc:Point" x="10" y="330" />
+        <di:waypoint xsi:type="dc:Point" x="144" y="330" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="-13" y="309" width="0" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
+      <bpmndi:BPMNShape id="StartEvent_13da9hl_di" bpmnElement="StartEvent_13da9hl">
+        <dc:Bounds x="-20" y="83" width="36" height="36" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="-26" y="124" width="50" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNShape id="ScriptTask_0nie46r_di" bpmnElement="ScriptTask_0nie46r">
+        <dc:Bounds x="340" y="61" width="100" height="80" />
+      </bpmndi:BPMNShape>
+      <bpmndi:BPMNEdge id="SequenceFlow_1chfao3_di" bpmnElement="SequenceFlow_1chfao3">
+        <di:waypoint xsi:type="dc:Point" x="16" y="101" />
+        <di:waypoint xsi:type="dc:Point" x="181" y="101" />
+        <di:waypoint xsi:type="dc:Point" x="181" y="101" />
+        <di:waypoint xsi:type="dc:Point" x="340" y="101" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="196" y="95" width="0" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
+      <bpmndi:BPMNEdge id="SequenceFlow_1o9916j_di" bpmnElement="SequenceFlow_1o9916j">
+        <di:waypoint xsi:type="dc:Point" x="440" y="101" />
+        <di:waypoint xsi:type="dc:Point" x="1047" y="101" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="743.5" y="80" width="0" height="12" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
+    </bpmndi:BPMNPlane>
+  </bpmndi:BPMNDiagram>
+</bpmn2:definitions>
index 785db75..002e382 100644 (file)
@@ -186,6 +186,7 @@ dcsi.preProcessAAIPUT(execution)]]></bpmn2:script>
         <camunda:in source="operationType" target="operationType" />
         <camunda:in source="operationId" target="operationId" />
         <camunda:in source="serviceDecomposition_Original" target="serviceDecomposition" />
+        <camunda:in source="uuiRequest-del" target="uuiRequest-del" />
       </bpmn2:extensionElements>
       <bpmn2:incoming>SequenceFlow_0ur34hv</bpmn2:incoming>
       <bpmn2:outgoing>SequenceFlow_0w4t4ao</bpmn2:outgoing>
index abab08b..b0517ac 100644 (file)
@@ -1,16 +1,21 @@
-/*
+/*-
+ * ============LICENSE_START=======================================================
+ *  Copyright (C) 2019 Nordix Foundation.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
  *
- * ============LICENSE_START======================================================= Copyright (C) 2019 Nordix
- * Foundation. ================================================================================ Licensed under the
- * Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may
- * obtain a copy of the License at
+ *      http://www.apache.org/licenses/LICENSE-2.0
  *
- * http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
- * either express or implied. See the License for the specific language governing permissions and limitations under the
- * License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
  *
- * SPDX-License-Identifier: Apache-2.0 ============LICENSE_END=========================================================
+ * SPDX-License-Identifier: Apache-2.0
+ * ============LICENSE_END=========================================================
  */
 
 package org.onap.so.bpmn.infrastructure.process;
@@ -25,10 +30,8 @@ import static com.github.tomakehurst.wiremock.client.WireMock.urlPathMatching;
 import static org.assertj.core.api.Assertions.fail;
 import static org.camunda.bpm.engine.test.assertions.bpmn.BpmnAwareAssertions.assertThat;
 import com.google.protobuf.Struct;
-import com.google.protobuf.Value;
 import java.io.IOException;
 import java.util.List;
-import java.util.Map;
 import java.util.UUID;
 import org.camunda.bpm.engine.runtime.Execution;
 import org.camunda.bpm.engine.runtime.ProcessInstance;
@@ -114,6 +117,7 @@ public class CreateVcpeResCustServiceSimplifiedTest extends BaseBPMNTest {
 
         if (!execution.isSuspended() && !execution.isEnded()) {
             try {
+
                 runtimeService.signal(execution.getId());
             } catch (Exception e) {
                 logger.info(e.getMessage(), e);
index c6ed1cc..968723c 100644 (file)
@@ -22,7 +22,6 @@ package org.onap.so.bpmn.infrastructure.sdnc.tasks;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotEquals;
-import static org.junit.Assert.assertNull;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.doReturn;
@@ -95,8 +94,6 @@ public class SDNCUnassignTasksTest extends BaseTaskTest {
         assertEquals(SDNCTopology.SERVICE, sdncRequest.getTopology());
     }
 
-
-
     @Test
     public void unassignServiceInstanceExceptionTest() throws Exception {
         expectedException.expect(BpmnError.class);
@@ -115,8 +112,6 @@ public class SDNCUnassignTasksTest extends BaseTaskTest {
         assertEquals(SDNCTopology.VFMODULE, sdncRequest.getTopology());
     }
 
-
-
     @Test
     public void unassignVfModuleExceptionTest() throws Exception {
         expectedException.expect(BpmnError.class);
@@ -136,7 +131,6 @@ public class SDNCUnassignTasksTest extends BaseTaskTest {
         assertEquals(SDNCTopology.VNF, sdncRequest.getTopology());
     }
 
-
     @Test
     public void unassignVnfExceptionTest() throws Exception {
         expectedException.expect(BpmnError.class);
index bc4f389..c480bdf 100644 (file)
  */
 package org.onap.so.apihandlerinfra;
 
-import java.nio.file.Files;
-import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
 import javax.transaction.Transactional;
 import javax.ws.rs.GET;
 import javax.ws.rs.Path;
@@ -32,7 +35,19 @@ import org.onap.so.apihandler.common.ErrorNumbers;
 import org.onap.so.apihandler.common.ResponseBuilder;
 import org.onap.so.apihandlerinfra.exceptions.ValidateException;
 import org.onap.so.apihandlerinfra.logging.ErrorLoggerInfo;
+import org.onap.so.apihandlerinfra.workflowspecificationbeans.ActivitySequence;
+import org.onap.so.apihandlerinfra.workflowspecificationbeans.ArtifactInfo;
+import org.onap.so.apihandlerinfra.workflowspecificationbeans.Validation;
+import org.onap.so.apihandlerinfra.workflowspecificationbeans.WorkflowInputParameter;
+import org.onap.so.apihandlerinfra.workflowspecificationbeans.WorkflowSpecification;
+import org.onap.so.apihandlerinfra.workflowspecificationbeans.WorkflowSpecificationList;
 import org.onap.so.apihandlerinfra.workflowspecificationbeans.WorkflowSpecifications;
+import org.onap.so.db.catalog.beans.ActivitySpec;
+import org.onap.so.db.catalog.beans.ActivitySpecUserParameters;
+import org.onap.so.db.catalog.beans.UserParameters;
+import org.onap.so.db.catalog.beans.Workflow;
+import org.onap.so.db.catalog.beans.WorkflowActivitySpecSequence;
+import org.onap.so.db.catalog.client.CatalogDbClient;
 import org.onap.so.logger.ErrorCode;
 import org.onap.so.logger.MessageEnum;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -51,11 +66,17 @@ public class WorkflowSpecificationsHandler {
     @Autowired
     private ResponseBuilder builder;
 
+    @Autowired
+    private CatalogDbClient catalogDbClient;
+
+    private static final String ARTIFACT_TYPE_WORKFLOW = "workflow";
+
     @Path("/{version:[vV]1}/workflows")
     @GET
     @ApiOperation(value = "Finds Workflow Specifications", response = Response.class)
     @Transactional
-    public Response queryFilters(@QueryParam("vnfModelVersionId") String vnfModelVersionId,
+
+    public Response queryWorkflowSpecifications(@QueryParam("vnfModelVersionId") String vnfModelVersionId,
             @PathParam("version") String version) throws Exception {
 
         String apiVersion = version.substring(1);
@@ -63,10 +84,8 @@ public class WorkflowSpecificationsHandler {
         ObjectMapper mapper1 = new ObjectMapper();
         mapper1.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
 
-        // Replace with Catalog DB Query
-        WorkflowSpecifications workflowSpecifications = mapper1.readValue(
-                new String(Files.readAllBytes(Paths.get("src/test/resources/__files/WorkflowSpecifications.json"))),
-                WorkflowSpecifications.class);
+        List<Workflow> workflows = catalogDbClient.findWorkflowByModelUUID(vnfModelVersionId);
+        WorkflowSpecifications workflowSpecifications = mapWorkflowsToWorkflowSpecifications(workflows);
 
         String jsonResponse = null;
         try {
@@ -85,4 +104,119 @@ public class WorkflowSpecificationsHandler {
 
         return builder.buildResponse(HttpStatus.SC_OK, "", jsonResponse, apiVersion);
     }
+
+    protected WorkflowSpecifications mapWorkflowsToWorkflowSpecifications(List<Workflow> workflows) {
+        if (workflows == null || workflows.size() == 0) {
+            return null;
+        }
+        WorkflowSpecifications workflowSpecifications = new WorkflowSpecifications();
+        List<WorkflowSpecificationList> workflowSpecificationList = new ArrayList<WorkflowSpecificationList>();
+
+        for (Workflow workflow : workflows) {
+            WorkflowSpecificationList workflowSpecificationListItem = new WorkflowSpecificationList();
+            WorkflowSpecification workflowSpecification = new WorkflowSpecification();
+            workflowSpecification.setArtifactInfo(buildArtifactInfo(workflow));
+            workflowSpecification.setActivitySequence(buildActivitySequence(workflow));
+            workflowSpecification.setWorkflowInputParameters(buildWorkflowInputParameters(workflow));
+            workflowSpecificationListItem.setWorkflowSpecification(workflowSpecification);
+            workflowSpecificationList.add(workflowSpecificationListItem);
+        }
+        workflowSpecifications.setWorkflowSpecificationList(workflowSpecificationList);
+        return workflowSpecifications;
+    }
+
+    private ArtifactInfo buildArtifactInfo(Workflow workflow) {
+        ArtifactInfo artifactInfo = new ArtifactInfo();
+        artifactInfo.setArtifactType(ARTIFACT_TYPE_WORKFLOW);
+        artifactInfo.setArtifactUuid(workflow.getArtifactUUID());
+        artifactInfo.setArtifactName(workflow.getArtifactName());
+        if (workflow.getVersion() != null) {
+            artifactInfo.setArtifactVersion(workflow.getVersion().toString());
+        }
+        artifactInfo.setArtifactDescription(workflow.getDescription());
+        artifactInfo.setWorkflowName(workflow.getName());
+        artifactInfo.setOperationName(workflow.getOperationName());
+        artifactInfo.setWorkflowSource(workflow.getSource());
+        artifactInfo.setWorkflowResourceTarget(workflow.getResourceTarget());
+        return artifactInfo;
+    }
+
+    private List<ActivitySequence> buildActivitySequence(Workflow workflow) {
+        List<WorkflowActivitySpecSequence> workflowActivitySpecSequences = workflow.getWorkflowActivitySpecSequence();
+        if (workflowActivitySpecSequences == null || workflowActivitySpecSequences.size() == 0) {
+            return null;
+        }
+        List<ActivitySequence> activitySequences = new ArrayList<ActivitySequence>();
+        for (WorkflowActivitySpecSequence workflowActivitySpecSequence : workflowActivitySpecSequences) {
+            if (workflowActivitySpecSequence != null) {
+                ActivitySpec activitySpec = workflowActivitySpecSequence.getActivitySpec();
+                if (activitySpec != null) {
+                    ActivitySequence activitySequence = new ActivitySequence();
+                    activitySequence.setName(activitySpec.getName());
+                    activitySequence.setDescription(activitySpec.getDescription());
+                    activitySequences.add(activitySequence);
+                }
+            }
+        }
+        return activitySequences;
+    }
+
+    private List<WorkflowInputParameter> buildWorkflowInputParameters(Workflow workflow) {
+        List<WorkflowActivitySpecSequence> workflowActivitySpecSequences = workflow.getWorkflowActivitySpecSequence();
+        if (workflowActivitySpecSequences == null || workflowActivitySpecSequences.size() == 0) {
+            return null;
+        }
+        Map<String, WorkflowInputParameter> workflowInputParameterMap = new HashMap<String, WorkflowInputParameter>();
+        for (WorkflowActivitySpecSequence workflowActivitySpecSequence : workflowActivitySpecSequences) {
+            if (workflowActivitySpecSequence != null) {
+                ActivitySpec activitySpec = workflowActivitySpecSequence.getActivitySpec();
+                if (activitySpec != null) {
+                    List<ActivitySpecUserParameters> activitySpecUserParameters =
+                            activitySpec.getActivitySpecUserParameters();
+                    if (activitySpecUserParameters != null && activitySpecUserParameters.size() != 0) {
+                        for (ActivitySpecUserParameters activitySpecUserParameter : activitySpecUserParameters) {
+                            UserParameters userParameter = activitySpecUserParameter.getUserParameters();
+                            if (userParameter != null) {
+                                WorkflowInputParameter workflowInputParameter =
+                                        buildWorkflowInputParameter(userParameter);
+                                workflowInputParameterMap.put(userParameter.getName(), workflowInputParameter);
+                            }
+                        }
+                    }
+                }
+            }
+        }
+
+        if (workflowInputParameterMap.size() == 0) {
+            return null;
+        }
+        List<WorkflowInputParameter> workflowInputParameterList =
+                workflowInputParameterMap.values().stream().collect(Collectors.toList());
+        return workflowInputParameterList;
+    }
+
+    private WorkflowInputParameter buildWorkflowInputParameter(UserParameters userParameter) {
+        WorkflowInputParameter workflowInputParameter = new WorkflowInputParameter();
+        workflowInputParameter.setLabel(userParameter.getLabel());
+        workflowInputParameter.setInputType(userParameter.getType());
+        workflowInputParameter.setRequired(userParameter.getIsRequried());
+        workflowInputParameter.setSoFieldName(userParameter.getName());
+        workflowInputParameter.setSoPayloadLocation(userParameter.getPayloadLocation());
+        workflowInputParameter.setValidation(buildValidationList(userParameter));
+        return workflowInputParameter;
+    }
+
+    private List<Validation> buildValidationList(UserParameters userParameter) {
+        List<Validation> validationList = null;
+        if (userParameter.getMaxLength() != null || userParameter.getAllowableChars() != null) {
+            validationList = new ArrayList<Validation>();
+            Validation validation = new Validation();
+            if (userParameter.getMaxLength() != null) {
+                validation.setMaxLength(userParameter.getMaxLength().toString());
+            }
+            validation.setAllowableChars(userParameter.getAllowableChars());
+            validationList.add(validation);
+        }
+        return validationList;
+    }
 }
index 7678de1..48abeac 100644 (file)
 
 package org.onap.so.apihandlerinfra;
 
+import static com.github.tomakehurst.wiremock.client.WireMock.aResponse;
+import static com.github.tomakehurst.wiremock.client.WireMock.get;
+import static com.github.tomakehurst.wiremock.client.WireMock.urlMatching;
 import static com.shazam.shazamcrest.matcher.Matchers.sameBeanAs;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertThat;
+import java.io.File;
 import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Paths;
 import java.text.ParseException;
+import java.util.ArrayList;
+import java.util.List;
 import javax.ws.rs.core.MediaType;
 import javax.ws.rs.core.Response;
 import org.json.JSONException;
 import org.junit.Test;
+import org.onap.so.apihandlerinfra.workflowspecificationbeans.WorkflowInputParameter;
 import org.onap.so.apihandlerinfra.workflowspecificationbeans.WorkflowSpecifications;
+import org.onap.so.db.catalog.beans.ActivitySpec;
+import org.onap.so.db.catalog.beans.ActivitySpecUserParameters;
+import org.onap.so.db.catalog.beans.UserParameters;
+import org.onap.so.db.catalog.beans.Workflow;
+import org.onap.so.db.catalog.beans.WorkflowActivitySpecSequence;
+import org.skyscreamer.jsonassert.JSONAssert;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Value;
 import org.springframework.http.HttpEntity;
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.HttpMethod;
 import org.springframework.http.ResponseEntity;
+import org.springframework.util.ResourceUtils;
 import org.springframework.web.util.UriComponentsBuilder;
 import com.fasterxml.jackson.core.JsonParseException;
 import com.fasterxml.jackson.databind.DeserializationFeature;
@@ -43,11 +59,16 @@ import com.fasterxml.jackson.databind.JsonMappingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 
 public class WorkflowSpecificationsHandlerTest extends BaseTest {
+    @Autowired
+    WorkflowSpecificationsHandler workflowSpecificationsHandler;
+
+    @Value("${wiremock.server.port}")
+    private String wiremockPort;
 
     private final String basePath = "onap/so/infra/workflowSpecifications/v1/workflows";
 
     @Test
-    public void getTasksTestByOriginalRequestId()
+    public void queryWorkflowSpecifications_Test_Success()
             throws ParseException, JSONException, JsonParseException, JsonMappingException, IOException {
 
         HttpHeaders headers = new HttpHeaders();
@@ -55,26 +76,191 @@ public class WorkflowSpecificationsHandlerTest extends BaseTest {
         headers.set("Content-Type", MediaType.APPLICATION_JSON);
         HttpEntity<String> entity = new HttpEntity<String>(null, headers);
 
+        wireMockServer.stubFor(get(urlMatching(
+                "/workflow/search/findWorkflowByModelUUID[?]vnfResourceModelUUID=b5fa707a-f55a-11e7-a796-005056856d52"))
+                        .willReturn(aResponse().withHeader(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON)
+                                .withBody(getWiremockResponseForCatalogdb("WorkflowSpecificationsQuery_Response.json"))
+                                .withStatus(org.apache.http.HttpStatus.SC_OK)));
+
+        wireMockServer.stubFor(get(urlMatching("/workflow/1/workflowActivitySpecSequence"))
+                .willReturn(aResponse().withHeader(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON)
+                        .withBody(getWiremockResponseForCatalogdb("WorkflowActivitySpecSequence_Response.json"))
+                        .withStatus(org.apache.http.HttpStatus.SC_OK)));
+
         UriComponentsBuilder builder = UriComponentsBuilder.fromHttpUrl(createURLWithPort(basePath))
                 .queryParam("vnfModelVersionId", "b5fa707a-f55a-11e7-a796-005056856d52");
 
         ResponseEntity<String> response =
                 restTemplate.exchange(builder.toUriString(), HttpMethod.GET, entity, String.class);
 
-        ObjectMapper mapper = new ObjectMapper();
+        assertEquals(Response.Status.OK.getStatusCode(), response.getStatusCode().value());
 
+        ObjectMapper mapper = new ObjectMapper();
         mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
 
         WorkflowSpecifications expectedResponse = mapper.readValue(
-                new String(Files.readAllBytes(Paths.get("src/test/resources/__files/WorkflowSpecifications.json"))),
+                new String(Files
+                        .readAllBytes(Paths.get("src/test/resources/__files/catalogdb/WorkflowSpecifications.json"))),
                 WorkflowSpecifications.class);
+        WorkflowSpecifications realResponse = mapper.readValue(response.getBody(), WorkflowSpecifications.class);
 
         assertEquals(Response.Status.OK.getStatusCode(), response.getStatusCode().value());
-        WorkflowSpecifications realResponse = mapper.readValue(response.getBody(), WorkflowSpecifications.class);
-        assertThat(realResponse, sameBeanAs(expectedResponse));
+        assertThat(expectedResponse, sameBeanAs(realResponse));
         assertEquals("application/json", response.getHeaders().get(HttpHeaders.CONTENT_TYPE).get(0));
         assertEquals("0", response.getHeaders().get("X-MinorVersion").get(0));
         assertEquals("0", response.getHeaders().get("X-PatchVersion").get(0));
         assertEquals("1.0.0", response.getHeaders().get("X-LatestVersion").get(0));
     }
+
+    @Test
+    public void mapWorkflowsToWorkflowSpecifications_Test_Success() throws Exception {
+        List<Workflow> workflows = new ArrayList<Workflow>();
+        Workflow workflow = new Workflow();
+        workflow.setArtifactUUID("ab6478e4-ea33-3346-ac12-ab121484a333");
+        workflow.setArtifactName("inPlaceSoftwareUpdate-1_0.bpmn");
+        workflow.setVersion(1.0);
+        workflow.setDescription("xyz xyz");
+        workflow.setName("inPlaceSoftwareUpdate");
+        workflow.setOperationName("inPlaceSoftwareUpdate");
+        workflow.setSource("sdc");
+        workflow.setResourceTarget("vnf");
+
+        UserParameters userParameter1 = new UserParameters();
+        userParameter1.setLabel("Operations Timeout");
+        userParameter1.setType("text");
+        userParameter1.setIsRequried(true);
+        userParameter1.setMaxLength(50);
+        userParameter1.setAllowableChars("someRegEx");
+        userParameter1.setName("operations_timeout");
+        userParameter1.setPayloadLocation("userParams");
+
+        UserParameters userParameter2 = new UserParameters();
+        userParameter2.setLabel("Existing Software Version");
+        userParameter2.setType("text");
+        userParameter2.setIsRequried(true);
+        userParameter2.setMaxLength(50);
+        userParameter2.setAllowableChars("someRegEx");
+        userParameter2.setName("existing_software_version");
+        userParameter2.setPayloadLocation("userParams");
+
+        UserParameters userParameter3 = new UserParameters();
+        userParameter3.setLabel("Cloud Owner");
+        userParameter3.setType("text");
+        userParameter3.setIsRequried(true);
+        userParameter3.setMaxLength(7);
+        userParameter3.setAllowableChars("someRegEx");
+        userParameter3.setName("cloudOwner");
+        userParameter3.setPayloadLocation("cloudConfiguration");
+
+        UserParameters userParameter4 = new UserParameters();
+        userParameter4.setLabel("Tenant/Project ID");
+        userParameter4.setType("text");
+        userParameter4.setIsRequried(true);
+        userParameter4.setMaxLength(36);
+        userParameter4.setAllowableChars("someRegEx");
+        userParameter4.setName("tenantId");
+        userParameter4.setPayloadLocation("cloudConfiguration");
+
+        UserParameters userParameter5 = new UserParameters();
+        userParameter5.setLabel("New Software Version");
+        userParameter5.setType("text");
+        userParameter5.setIsRequried(true);
+        userParameter5.setMaxLength(50);
+        userParameter5.setAllowableChars("someRegEx");
+        userParameter5.setName("new_software_version");
+        userParameter5.setPayloadLocation("userParams");
+
+        UserParameters userParameter6 = new UserParameters();
+        userParameter6.setLabel("Cloud Region ID");
+        userParameter6.setType("text");
+        userParameter6.setIsRequried(true);
+        userParameter6.setMaxLength(7);
+        userParameter6.setAllowableChars("someRegEx");
+        userParameter6.setName("lcpCloudRegionId");
+        userParameter6.setPayloadLocation("cloudConfiguration");
+
+
+        List<ActivitySpecUserParameters> activitySpecUserParameters = new ArrayList<ActivitySpecUserParameters>();
+
+        ActivitySpecUserParameters activitySpecUserParameter1 = new ActivitySpecUserParameters();
+        activitySpecUserParameter1.setUserParameters(userParameter1);
+        activitySpecUserParameters.add(activitySpecUserParameter1);
+
+        ActivitySpecUserParameters activitySpecUserParameter2 = new ActivitySpecUserParameters();
+        activitySpecUserParameter2.setUserParameters(userParameter2);
+        activitySpecUserParameters.add(activitySpecUserParameter2);
+
+        ActivitySpecUserParameters activitySpecUserParameter3 = new ActivitySpecUserParameters();
+        activitySpecUserParameter3.setUserParameters(userParameter3);
+        activitySpecUserParameters.add(activitySpecUserParameter3);
+
+
+        ActivitySpecUserParameters activitySpecUserParameter4 = new ActivitySpecUserParameters();
+        activitySpecUserParameter4.setUserParameters(userParameter4);
+        activitySpecUserParameters.add(activitySpecUserParameter4);
+
+        ActivitySpecUserParameters activitySpecUserParameter5 = new ActivitySpecUserParameters();
+        activitySpecUserParameter5.setUserParameters(userParameter5);
+        activitySpecUserParameters.add(activitySpecUserParameter5);
+
+        ActivitySpecUserParameters activitySpecUserParameter6 = new ActivitySpecUserParameters();
+        activitySpecUserParameter6.setUserParameters(userParameter6);
+        activitySpecUserParameters.add(activitySpecUserParameter6);
+
+        List<WorkflowActivitySpecSequence> workflowActivitySpecSequences =
+                new ArrayList<WorkflowActivitySpecSequence>();
+
+        ActivitySpec activitySpec1 = new ActivitySpec();
+        activitySpec1.setName("VNFQuiesceTrafficActivity");
+        activitySpec1.setDescription("Activity to QuiesceTraffic on VNF");
+        activitySpec1.setActivitySpecUserParameters(activitySpecUserParameters);
+        WorkflowActivitySpecSequence workflowActivitySpecSequence1 = new WorkflowActivitySpecSequence();
+        workflowActivitySpecSequence1.setActivitySpec(activitySpec1);
+        workflowActivitySpecSequences.add(workflowActivitySpecSequence1);
+
+        ActivitySpec activitySpec2 = new ActivitySpec();
+        activitySpec2.setName("VNFHealthCheckActivity");
+        activitySpec2.setDescription("Activity to HealthCheck VNF");
+        activitySpec2.setActivitySpecUserParameters(activitySpecUserParameters);
+        WorkflowActivitySpecSequence workflowActivitySpecSequence2 = new WorkflowActivitySpecSequence();
+        workflowActivitySpecSequence2.setActivitySpec(activitySpec2);
+        workflowActivitySpecSequences.add(workflowActivitySpecSequence2);
+
+        ActivitySpec activitySpec3 = new ActivitySpec();
+        activitySpec3.setName("FlowCompleteActivity");
+        activitySpec3.setDescription("Activity to Complete the BPMN Flow");
+        activitySpec3.setActivitySpecUserParameters(activitySpecUserParameters);
+        WorkflowActivitySpecSequence workflowActivitySpecSequence3 = new WorkflowActivitySpecSequence();
+        workflowActivitySpecSequence3.setActivitySpec(activitySpec3);
+        workflowActivitySpecSequences.add(workflowActivitySpecSequence3);
+
+        workflow.setWorkflowActivitySpecSequence(workflowActivitySpecSequences);
+        workflows.add(workflow);
+
+        WorkflowSpecifications workflowSpecifications =
+                workflowSpecificationsHandler.mapWorkflowsToWorkflowSpecifications(workflows);
+        ObjectMapper mapper = new ObjectMapper();
+
+        mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
+        String workflowSpecificationsJson = mapper.writeValueAsString(workflowSpecifications);
+        WorkflowSpecifications expectedResult = mapper.readValue(
+                new String(Files
+                        .readAllBytes(Paths.get("src/test/resources/__files/catalogdb/WorkflowSpecifications.json"))),
+                WorkflowSpecifications.class);
+        String expectedResultJson = mapper.writeValueAsString(expectedResult);
+
+        JSONAssert.assertEquals(expectedResultJson, workflowSpecificationsJson, false);
+        assertThat(expectedResult, sameBeanAs(workflowSpecifications).ignoring(WorkflowInputParameter.class));
+    }
+
+    private String getWiremockResponseForCatalogdb(String file) {
+        try {
+            File resource = ResourceUtils.getFile("classpath:__files/catalogdb/" + file);
+            return new String(Files.readAllBytes(resource.toPath())).replaceAll("localhost:8090",
+                    "localhost:" + wiremockPort);
+        } catch (IOException e) {
+            e.printStackTrace();
+            return null;
+        }
+    }
 }
diff --git a/mso-api-handlers/mso-api-handler-infra/src/test/resources/__files/catalogdb/WorkflowActivitySpecSequence_Response.json b/mso-api-handlers/mso-api-handler-infra/src/test/resources/__files/catalogdb/WorkflowActivitySpecSequence_Response.json
new file mode 100644 (file)
index 0000000..3192865
--- /dev/null
@@ -0,0 +1,432 @@
+{
+       "_embedded": {
+       
+    "workflowActivitySpecSequence": [
+      {
+        "activitySpecId": null,
+        "workflowId": null,
+        "activitySpec": {
+          "name": "VNFQuiesceTrafficActivity",
+          "description": "Activity to QuiesceTraffic on VNF",
+          "version": null,
+          "created": null,
+          "workflowActivitySpecSequence": null,
+          "activitySpecActivitySpecCategories": null,
+          "activitySpecUserParameters": [
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "operations_timeout",
+                "payloadLocation": "userParams",
+                "label": "Operations Timeout",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "existing_software_version",
+                "payloadLocation": "userParams",
+                "label": "Existing Software Version",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "cloudOwner",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Cloud Owner",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 7,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "tenantId",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Tenant/Project ID",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 36,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "new_software_version",
+                "payloadLocation": "userParams",
+                "label": "New Software Version",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "lcpCloudRegionId",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Cloud Region ID",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 7,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            }
+          ],
+          "activitySpecActivitySpecParameters": null,
+          "id": null
+        },
+        "workflow": null,
+        "id": null,
+        "_links": {
+    "self": {
+      "href": "http://localhost:8090/workflow/search/findWorkflowByModelUUID?vnfResourceModelUUID=b5fa707a-f55a-11e7-a796-005056856d52"
+    },    
+    "workflowActivitySpecSequence": {
+      "href": "http://localhost:8090/workflow/b5fa707a-f55a-11e7-a796-005056856d52/workflowActivitySpecSequence"
+    }
+  
+  }
+        
+      },
+      {
+        "activitySpecId": null,
+        "workflowId": null,
+        "activitySpec": {
+          "name": "VNFHealthCheckActivity",
+          "description": "Activity to HealthCheck VNF",
+          "version": null,
+          "created": null,
+          "workflowActivitySpecSequence": null,
+          "activitySpecActivitySpecCategories": null,
+          "activitySpecUserParameters": [
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "operations_timeout",
+                "payloadLocation": "userParams",
+                "label": "Operations Timeout",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "existing_software_version",
+                "payloadLocation": "userParams",
+                "label": "Existing Software Version",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "cloudOwner",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Cloud Owner",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 7,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "tenantId",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Tenant/Project ID",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 36,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "new_software_version",
+                "payloadLocation": "userParams",
+                "label": "New Software Version",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "lcpCloudRegionId",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Cloud Region ID",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 7,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            }
+          ],
+          "activitySpecActivitySpecParameters": null,
+          "id": null
+        },
+        "workflow": null,
+        "id": null,
+        "_links": {
+    "self": {
+      "href": "http://localhost:8090/workflow/search/findWorkflowByModelUUID?vnfResourceModelUUID=b5fa707a-f55a-11e7-a796-005056856d52"
+    },    
+    "workflowActivitySpecSequence": {
+      "href": "http://localhost:8090/workflow/b5fa707a-f55a-11e7-a796-005056856d52/workflowActivitySpecSequence"
+    }
+  
+  }
+      },
+      {
+        "activitySpecId": null,
+        "workflowId": null,
+        "activitySpec": {
+          "name": "FlowCompleteActivity",
+          "description": "Activity to Complete the BPMN Flow",
+          "version": null,
+          "created": null,
+          "workflowActivitySpecSequence": null,
+          "activitySpecActivitySpecCategories": null,
+          "activitySpecUserParameters": [
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "operations_timeout",
+                "payloadLocation": "userParams",
+                "label": "Operations Timeout",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "existing_software_version",
+                "payloadLocation": "userParams",
+                "label": "Existing Software Version",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "cloudOwner",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Cloud Owner",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 7,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "tenantId",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Tenant/Project ID",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 36,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "new_software_version",
+                "payloadLocation": "userParams",
+                "label": "New Software Version",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "lcpCloudRegionId",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Cloud Region ID",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 7,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            }
+          ],
+          "activitySpecActivitySpecParameters": null,
+          "id": null
+        },
+        "workflow": null,
+        "id": null,
+        "_links": {
+    "self": {
+      "href": "http://localhost:8090/workflow/search/findWorkflowByModelUUID?vnfResourceModelUUID=b5fa707a-f55a-11e7-a796-005056856d52"
+    },    
+    "workflowActivitySpecSequence": {
+      "href": "http://localhost:8090/workflow/b5fa707a-f55a-11e7-a796-005056856d52/workflowActivitySpecSequence"
+    }
+  
+  }
+      }
+    ]
+  
+}
+}
\ No newline at end of file
           }
         ],
         "workflowInputParameters": [
-          {
-            "label": "Cloud Owner",
+               {
+            "label": "Operations Timeout",
             "inputType": "text",
             "required": true,
             "validation": [
               {
-                "maxLength": "7",
+                "maxLength": "50",
                 "allowableChars": "someRegEx"
               }
             ],
-            "soFieldName": "cloudOwner",
-            "soPayloadLocation": "cloudConfiguration"
-          },
+            "soFieldName": "operations_timeout",
+            "soPayloadLocation": "userParams"
+          },             
           {
-            "label": "Cloud Region ID",
+            "label": "Existing Software Version",
             "inputType": "text",
             "required": true,
             "validation": [
               {
-                "maxLength": "7",
+                "maxLength": "50",
                 "allowableChars": "someRegEx"
               }
             ],
-            "soFieldName": "lcpCloudRegionId",
-            "soPayloadLocation": "cloudConfiguration"
-          },
+            "soFieldName": "existing_software_version",
+            "soPayloadLocation": "userParams"
+          },   
           {
-            "label": "Tenant/Project ID",
+            "label": "Cloud Owner",
             "inputType": "text",
             "required": true,
             "validation": [
               {
-                "maxLength": "36",
+                "maxLength": "7",
                 "allowableChars": "someRegEx"
               }
             ],
-            "soFieldName": "tenantId",
+            "soFieldName": "cloudOwner",
             "soPayloadLocation": "cloudConfiguration"
-          },
+          },          
           {
-            "label": "Operations Timeout",
+            "label": "Tenant/Project ID",
             "inputType": "text",
             "required": true,
             "validation": [
               {
-                "maxLength": "50",
+                "maxLength": "36",
                 "allowableChars": "someRegEx"
               }
             ],
-            "soFieldName": "operations_timeout",
-            "soPayloadLocation": "userParams"
-          },
+            "soFieldName": "tenantId",
+            "soPayloadLocation": "cloudConfiguration"
+          },         
           {
-            "label": "Existing Software Version",
+            "label": "New Software Version",
             "inputType": "text",
             "required": true,
             "validation": [
                 "allowableChars": "someRegEx"
               }
             ],
-            "soFieldName": "existing_software_version",
+            "soFieldName": "new_software_version",
             "soPayloadLocation": "userParams"
           },
-          {
-            "label": "New Software Version",
+           {
+            "label": "Cloud Region ID",
             "inputType": "text",
             "required": true,
             "validation": [
               {
-                "maxLength": "50",
+                "maxLength": "7",
                 "allowableChars": "someRegEx"
               }
             ],
-            "soFieldName": "new_software_version",
-            "soPayloadLocation": "userParams"
-          }
+            "soFieldName": "lcpCloudRegionId",
+            "soPayloadLocation": "cloudConfiguration"
+          }      
         ]
       }
-    },
-    {
-      "workflowSpecification": {}
     }
   ]
 }
diff --git a/mso-api-handlers/mso-api-handler-infra/src/test/resources/__files/catalogdb/WorkflowSpecificationsQuery_Response.json b/mso-api-handlers/mso-api-handler-infra/src/test/resources/__files/catalogdb/WorkflowSpecificationsQuery_Response.json
new file mode 100644 (file)
index 0000000..c123656
--- /dev/null
@@ -0,0 +1,468 @@
+{
+       "_embedded": {
+       "workflows" :[
+  {
+    "artifactUUID": "ab6478e4-ea33-3346-ac12-ab121484a333",
+    "artifactName": "inPlaceSoftwareUpdate-1_0.bpmn",
+    "name": "inPlaceSoftwareUpdate",
+    "operationName": "inPlaceSoftwareUpdate",
+    "version": 1,
+    "description": "xyz xyz",
+    "body": null,
+    "resourceTarget": "vnf",
+    "source": "sdc",
+    "timeoutMinutes": null,
+    "artifactChecksum": null,
+    "created": null,
+    "vnfResourceWorkflow": null,
+    "workflowActivitySpecSequence": [
+      {
+        "activitySpecId": null,
+        "workflowId": null,
+        "activitySpec": {
+          "name": "VNFQuiesceTrafficActivity",
+          "description": "Activity to QuiesceTraffic on VNF",
+          "version": null,
+          "created": null,
+          "workflowActivitySpecSequence": null,
+          "activitySpecActivitySpecCategories": null,
+          "activitySpecUserParameters": [
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "operations_timeout",
+                "payloadLocation": "userParams",
+                "label": "Operations Timeout",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "existing_software_version",
+                "payloadLocation": "userParams",
+                "label": "Existing Software Version",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "cloudOwner",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Cloud Owner",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 7,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "tenantId",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Tenant/Project ID",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 36,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "new_software_version",
+                "payloadLocation": "userParams",
+                "label": "New Software Version",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "lcpCloudRegionId",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Cloud Region ID",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 7,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            }
+          ],
+          "activitySpecActivitySpecParameters": null,
+          "id": null
+        },
+        "workflow": null,
+        "id": null,
+        "_links": {
+    "self": {
+      "href": "http://localhost:8090/workflow/search/findWorkflowByModelUUID[?]vnfResourceModelUUID=b5fa707a-f55a-11e7-a796-005056856d52"
+    },    
+    "workflowActivitySpecSequence": {
+      "href": "http://localhost:8090/workflow/b5fa707a-f55a-11e7-a796-005056856d52/workflowActivitySpecSequence"
+    }
+  
+  }
+        
+      },
+      {
+        "activitySpecId": null,
+        "workflowId": null,
+        "activitySpec": {
+          "name": "VNFHealthCheckActivity",
+          "description": "Activity to HealthCheck VNF",
+          "version": null,
+          "created": null,
+          "workflowActivitySpecSequence": null,
+          "activitySpecActivitySpecCategories": null,
+          "activitySpecUserParameters": [
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "operations_timeout",
+                "payloadLocation": "userParams",
+                "label": "Operations Timeout",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "existing_software_version",
+                "payloadLocation": "userParams",
+                "label": "Existing Software Version",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "cloudOwner",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Cloud Owner",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 7,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "tenantId",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Tenant/Project ID",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 36,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "new_software_version",
+                "payloadLocation": "userParams",
+                "label": "New Software Version",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "lcpCloudRegionId",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Cloud Region ID",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 7,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            }
+          ],
+          "activitySpecActivitySpecParameters": null,
+          "id": null
+        },
+        "workflow": null,
+        "id": null,
+        "_links": {
+    "self": {
+      "href": "http://localhost:8090/workflow/search/findWorkflowByModelUUID?vnfResourceModelUUID=b5fa707a-f55a-11e7-a796-005056856d52"
+    },    
+    "workflowActivitySpecSequence": {
+      "href": "http://localhost:8090/workflow/b5fa707a-f55a-11e7-a796-005056856d52/workflowActivitySpecSequence"
+    }
+  
+  }
+      },
+      {
+        "activitySpecId": null,
+        "workflowId": null,
+        "activitySpec": {
+          "name": "FlowCompleteActivity",
+          "description": "Activity to Complete the BPMN Flow",
+          "version": null,
+          "created": null,
+          "workflowActivitySpecSequence": null,
+          "activitySpecActivitySpecCategories": null,
+          "activitySpecUserParameters": [
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "operations_timeout",
+                "payloadLocation": "userParams",
+                "label": "Operations Timeout",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "existing_software_version",
+                "payloadLocation": "userParams",
+                "label": "Existing Software Version",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "cloudOwner",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Cloud Owner",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 7,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "tenantId",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Tenant/Project ID",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 36,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "new_software_version",
+                "payloadLocation": "userParams",
+                "label": "New Software Version",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 50,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            },
+            {
+              "activitySpecId": null,
+              "userParametersId": null,
+              "activitySpec": null,
+              "userParameters": {
+                "name": "lcpCloudRegionId",
+                "payloadLocation": "cloudConfiguration",
+                "label": "Cloud Region ID",
+                "type": "text",
+                "description": null,
+                "isRequried": true,
+                "maxLength": 7,
+                "allowableChars": "someRegEx",
+                "created": null,
+                "activitySpecUserParameters": null,
+                "id": null
+              },
+              "id": null
+            }
+          ],
+          "activitySpecActivitySpecParameters": null,
+          "id": null
+        },
+        "workflow": null,
+        "id": null,
+        "_links": {
+    "self": {
+      "href": "http://localhost:8090/workflow/search/findWorkflowByModelUUID?vnfResourceModelUUID=b5fa707a-f55a-11e7-a796-005056856d52"
+    },    
+    "workflowActivitySpecSequence": {
+      "href": "http://localhost:8090/workflow/b5fa707a-f55a-11e7-a796-005056856d52/workflowActivitySpecSequence"
+    }
+  
+  }
+      }
+    ],
+    "id": null,
+  "_links": {
+    "self": {
+      "href": "http://localhost:8090/workflow/search/findWorkflowByModelUUID?vnfResourceModelUUID=b5fa707a-f55a-11e7-a796-005056856d52"
+    },    
+    "workflowActivitySpecSequence": {
+      "href": "http://localhost:8090/workflow/1/workflowActivitySpecSequence"
+    }
+    
+   }
+  
+  }
+]
+},
+"_links": {
+    "self": {
+      "href": "http://localhost:8090/workflow/search/findWorkflowByModelUUID?vnfResourceModelUUID=b5fa707a-f55a-11e7-a796-005056856d52"
+    },    
+    "workflowActivitySpecSequence": {
+      "href": "http://localhost:8090/workflow/b5fa707a-f55a-11e7-a796-005056856d52/workflowActivitySpecSequence"
+    }
+  
+  }
+}
\ No newline at end of file
index f75ccf0..a2ca4a3 100644 (file)
@@ -190,6 +190,7 @@ public class CatalogDbClient {
     private String findServiceByServiceInstanceId = "/findServiceByServiceInstanceId";
     private String findPnfResourceCustomizationByModelUuid = "/findPnfResourceCustomizationByModelUuid";
     private String findWorkflowByArtifactUUID = "/findByArtifactUUID";
+    private String findWorkflowByModelUUID = "/findWorkflowByModelUUID";
 
     private String serviceURI;
     private String vfModuleURI;
@@ -330,6 +331,7 @@ public class CatalogDbClient {
                 endpoint + PNF_RESOURCE_CUSTOMIZATION + SEARCH + findPnfResourceCustomizationByModelUuid;
 
         findWorkflowByArtifactUUID = endpoint + WORKFLOW + SEARCH + findWorkflowByArtifactUUID;
+        findWorkflowByModelUUID = endpoint + WORKFLOW + SEARCH + findWorkflowByModelUUID;
 
         serviceURI = endpoint + SERVICE + URI_SEPARATOR;
         vfModuleURI = endpoint + VFMODULE + URI_SEPARATOR;
@@ -872,4 +874,9 @@ public class CatalogDbClient {
         return this.getSingleResource(workflowClient, getUri(UriBuilder.fromUri(findWorkflowByArtifactUUID)
                 .queryParam(ARTIFACT_UUID, artifactUUID).build().toString()));
     }
+
+    public List<Workflow> findWorkflowByModelUUID(String vnfResourceModelUUID) {
+        return this.getMultipleResources(workflowClient, getUri(UriBuilder.fromUri(findWorkflowByModelUUID)
+                .queryParam(VNF_RESOURCE_MODEL_UUID, vnfResourceModelUUID).build().toString()));
+    }
 }
index b73896a..fb5f202 100644 (file)
 
 package org.onap.so.db.catalog.data.repository;
 
+import java.util.List;
 import org.onap.so.db.catalog.beans.Workflow;
 import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.data.jpa.repository.Query;
+import org.springframework.data.repository.query.Param;
 import org.springframework.data.rest.core.annotation.RepositoryRestResource;
 
 @RepositoryRestResource(collectionResourceRel = "workflow", path = "workflow")
 public interface WorkflowRepository extends JpaRepository<Workflow, String> {
+
     Workflow findByArtifactUUID(String artifactUUID);
+
+    /**
+     * Used to fetch the @{link Workflow} by the Model UUID.
+     *
+     * This operation is required by {@link org.onap.so.db.catalog.client.CatalogDbClient} to provide Workflow based on
+     * model UUID without projection.
+     *
+     * @param vnfResourceModelUUIDmodel UUID
+     * @return List of Workflow
+     */
+    @Query(value = "select b.* from vnf_resource_to_workflow a join workflow b where a.WORKFLOW_ID = b.ID and a.VNF_RESOURCE_MODEL_UUID = ?1",
+            nativeQuery = true)
+    List<Workflow> findWorkflowByModelUUID(String vnfResourceModelUUID);
 }
index d541627..4f31e4b 100644 (file)
@@ -18,12 +18,10 @@ import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
 import java.util.List;
+import org.junit.Assert;
 import org.junit.Test;
 import org.onap.so.db.catalog.BaseTest;
-import org.onap.so.db.catalog.beans.PnfResource;
-import org.onap.so.db.catalog.beans.PnfResourceCustomization;
 import org.onap.so.db.catalog.beans.Workflow;
-import org.onap.so.db.catalog.exceptions.NoEntityFoundException;
 import org.springframework.beans.factory.annotation.Autowired;
 
 public class WorkflowRepositoryTest extends BaseTest {
@@ -38,4 +36,14 @@ public class WorkflowRepositoryTest extends BaseTest {
         assertEquals("artifactName", "testingWorkflow", workflow.getArtifactName());
     }
 
+    @Test
+    public void findByVnfResourceModelUUIDTest() throws Exception {
+        List<Workflow> workflows = workflowRepository.findWorkflowByModelUUID("ff2ae348-214a-11e7-93ae-92361f002671");
+
+        Assert.assertTrue(workflows != null);
+        Assert.assertTrue(workflows.size() != 0);
+
+        Assert.assertTrue("testingWorkflow".equals(workflows.get(0).getArtifactName()));
+    }
+
 }
index ade183e..825b541 100644 (file)
@@ -741,3 +741,12 @@ insert into pnf_resource_customization_to_service(service_model_uuid, resource_m
 
 insert into workflow(artifact_uuid, artifact_name, name, operation_name, version, description, body, resource_target, source) values
 ('5b0c4322-643d-4c9f-b184-4516049e99b1', 'testingWorkflow', 'testingWorkflow', 'create', 1, 'Test Workflow', null, 'vnf', 'sdc');
+
+insert into vnf_resource_to_workflow(vnf_resource_model_uuid, workflow_id) values
+('ff2ae348-214a-11e7-93ae-92361f002671', '1');
+
+insert into activity_spec(name, description, version) values
+('testActivity1', 'Test Activity 1', 1);
+
+insert into workflow_activity_spec_sequence(workflow_id, activity_spec_id, seq_no) values
+(1, 1, 1);
index d5a73b0..92979f4 100644 (file)
@@ -1234,6 +1234,138 @@ CREATE TABLE IF NOT EXISTS `vnf_resource_to_workflow` (
   CONSTRAINT `fk_vnf_resource_to_workflow__workflow1` FOREIGN KEY (`WORKFLOW_ID`) REFERENCES `workflow` (`ID`) ON DELETE CASCADE ON UPDATE CASCADE
 ) ENGINE=InnoDB DEFAULT CHARSET=latin1;
 
+CREATE TABLE IF NOT EXISTS `activity_spec` (
+  `ID` INT(11) NOT NULL AUTO_INCREMENT,
+  `NAME` VARCHAR(200) NOT NULL,
+  `DESCRIPTION` VARCHAR(1200) NOT NULL,
+  `VERSION` DOUBLE NOT NULL,
+  `CREATION_TIMESTAMP` DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
+  PRIMARY KEY (`ID`),
+  UNIQUE INDEX `UK_activity_spec` (`NAME` ASC, `VERSION` ASC))
+ENGINE = InnoDB
+DEFAULT CHARACTER SET = latin1;
+
+CREATE TABLE IF NOT EXISTS `user_parameters` (
+  `ID` INT(11) NOT NULL AUTO_INCREMENT,
+  `NAME` VARCHAR(200) NOT NULL,
+  `PAYLOAD_LOCATION` VARCHAR(500) NULL,
+  `LABEL` VARCHAR(200) NOT NULL,
+  `TYPE` VARCHAR(200) NOT NULL,
+  `DESCRIPTION` VARCHAR(1200) NULL,
+  `IS_REQUIRED` TINYINT(1) NOT NULL,
+  `MAX_LENGTH` INT(11) NULL,
+  `ALLOWABLE_CHARS` VARCHAR(200) NULL,
+  `CREATION_TIMESTAMP` DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
+  PRIMARY KEY (`ID`),
+  UNIQUE INDEX `UK_user_parameters` (`NAME` ASC))
+ENGINE = InnoDB
+DEFAULT CHARACTER SET = latin1;
+
+CREATE TABLE IF NOT EXISTS `workflow_activity_spec_sequence` (
+  `ID` INT(11) NOT NULL AUTO_INCREMENT,
+  `WORKFLOW_ID` INT(11) NOT NULL,
+  `ACTIVITY_SPEC_ID` INT(11) NOT NULL,
+  `SEQ_NO` INT(11) NOT NULL,
+  PRIMARY KEY (`ID`),
+  UNIQUE INDEX `UK_workflow_activity_spec_sequence` (`WORKFLOW_ID` ASC, `ACTIVITY_SPEC_ID` ASC, `SEQ_NO` ASC),
+  INDEX `fk_workflow_activity_spec_sequence__activity_spec_idx` (`ACTIVITY_SPEC_ID` ASC),
+  INDEX `fk_workflow_activity_spec_sequence__workflow_actifact_uuid_idx` (`WORKFLOW_ID` ASC),
+  CONSTRAINT `fk_workflow_activity_spec_sequence__activity_spec1`
+    FOREIGN KEY (`ACTIVITY_SPEC_ID`)
+    REFERENCES `activity_spec` (`ID`)
+    ON DELETE CASCADE
+    ON UPDATE CASCADE,
+  CONSTRAINT `fk_workflow_activity_spec_sequence__workflow1`
+    FOREIGN KEY (`WORKFLOW_ID`)
+    REFERENCES `workflow` (`ID`)
+    ON DELETE CASCADE
+    ON UPDATE CASCADE)
+ENGINE = InnoDB
+DEFAULT CHARACTER SET = latin1;
+
+CREATE TABLE IF NOT EXISTS `activity_spec_parameters` (
+  `ID` INT(11) NOT NULL AUTO_INCREMENT,
+  `NAME` VARCHAR(200) NOT NULL,
+  `TYPE` VARCHAR(200) NOT NULL,
+  `DIRECTION` VARCHAR(200) NULL,
+  `DESCRIPTION` VARCHAR(1200) NULL,
+  `CREATION_TIMESTAMP` DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
+  PRIMARY KEY (`ID`),
+  UNIQUE INDEX `UK_activity_spec_parameters` (`NAME` ASC, `DIRECTION` ASC))
+ENGINE = InnoDB
+DEFAULT CHARACTER SET = latin1;
+
+CREATE TABLE IF NOT EXISTS `activity_spec_categories` (
+  `ID` INT(11) NOT NULL,
+  `NAME` VARCHAR(200) NOT NULL,
+  PRIMARY KEY (`ID`),
+  UNIQUE INDEX `UK_activity_spec_categories` (`NAME` ASC))
+ENGINE = InnoDB
+DEFAULT CHARACTER SET = latin1;
+
+CREATE TABLE IF NOT EXISTS `activity_spec_to_activity_spec_categories` (
+  `ID` INT(11) NOT NULL,
+  `ACTIVITY_SPEC_ID` INT(11) NOT NULL,
+  `ACTIVITY_SPEC_CATEGORIES_ID` INT(11) NOT NULL,
+  PRIMARY KEY (`ID`),
+  UNIQUE INDEX `UK_activity_spec_to_activity_spec_categories` (`ACTIVITY_SPEC_ID` ASC, `ACTIVITY_SPEC_CATEGORIES_ID` ASC),
+  INDEX `fk_activity_spec_to_activity_spec_categories__activity_spec_idx` (`ACTIVITY_SPEC_CATEGORIES_ID` ASC),
+  INDEX `fk_activity_spec_to_activity_spec_categories__activity_spec_idx1` (`ACTIVITY_SPEC_ID` ASC),
+  CONSTRAINT `fk_activity_spec_to_activity_spec_categories__activity_spec1`
+    FOREIGN KEY (`ACTIVITY_SPEC_ID`)
+    REFERENCES `activity_spec` (`ID`)
+    ON DELETE CASCADE
+    ON UPDATE CASCADE,
+  CONSTRAINT `fk_activity_spec_to_activity_spec_categories__activity_spec_c1`
+    FOREIGN KEY (`ACTIVITY_SPEC_CATEGORIES_ID`)
+    REFERENCES `activity_spec_categories` (`ID`)
+    ON DELETE CASCADE
+    ON UPDATE CASCADE)
+ENGINE = InnoDB
+DEFAULT CHARACTER SET = latin1;
+
+CREATE TABLE IF NOT EXISTS `activity_spec_to_activity_spec_parameters` (
+  `ID` INT(11) NOT NULL AUTO_INCREMENT,
+  `ACTIVITY_SPEC_ID` INT(11) NOT NULL,
+  `ACTIVITY_SPEC_PARAMETERS_ID` INT(11) NOT NULL,
+  PRIMARY KEY (`ID`),
+  INDEX `fk_activity_spec_to_activity_spec_params__act_sp_param_id_idx` (`ACTIVITY_SPEC_PARAMETERS_ID` ASC),
+  UNIQUE INDEX `UK_activity_spec_to_activity_spec_parameters` (`ACTIVITY_SPEC_ID` ASC, `ACTIVITY_SPEC_PARAMETERS_ID` ASC),
+  INDEX `fk_activity_spec_to_activity_spec_parameters__act_spec_id_idx` (`ACTIVITY_SPEC_ID` ASC),
+  CONSTRAINT `fk_activity_spec_to_activity_spec_parameters__activity_spec_1`
+    FOREIGN KEY (`ACTIVITY_SPEC_ID`)
+    REFERENCES `activity_spec` (`ID`)
+    ON DELETE CASCADE
+    ON UPDATE CASCADE,
+  CONSTRAINT `fk_activity_spec_to_activity_spec_parameters__activ_spec_param1`
+    FOREIGN KEY (`ACTIVITY_SPEC_PARAMETERS_ID`)
+    REFERENCES `activity_spec_parameters` (`ID`)
+    ON DELETE CASCADE
+    ON UPDATE CASCADE)
+ENGINE = InnoDB
+DEFAULT CHARACTER SET = latin1;
+
+CREATE TABLE IF NOT EXISTS `activity_spec_to_user_parameters` (
+  `ID` INT(11) NOT NULL,
+  `ACTIVITY_SPEC_ID` INT(11) NOT NULL,
+  `USER_PARAMETERS_ID` INT(11) NOT NULL,
+  PRIMARY KEY (`ID`),
+  UNIQUE INDEX `UK_activity_spec_to_user_parameters` (`ACTIVITY_SPEC_ID` ASC, `USER_PARAMETERS_ID` ASC),
+  INDEX `fk_activity_spec_to_user_parameters__user_parameters1_idx` (`USER_PARAMETERS_ID` ASC),
+  INDEX `fk_activity_spec_to_user_parameters__activity_spec1_idx` (`ACTIVITY_SPEC_ID` ASC),
+  CONSTRAINT `fk_activity_spec_to_user_parameters__activity_spec1`
+    FOREIGN KEY (`ACTIVITY_SPEC_ID`)
+    REFERENCES `activity_spec` (`ID`)
+    ON DELETE CASCADE
+    ON UPDATE CASCADE,
+  CONSTRAINT `fk_activity_spec_to_user_parameters__user_parameters1`
+    FOREIGN KEY (`USER_PARAMETERS_ID`)
+    REFERENCES `user_parameters` (`ID`)
+    ON DELETE CASCADE
+    ON UPDATE CASCADE)
+ENGINE = InnoDB
+DEFAULT CHARACTER SET = latin1;
+