Fix sonar issues 21/11921/2
authorsurya-huawei <a.u.surya@huawei.com>
Tue, 12 Sep 2017 10:20:07 +0000 (15:50 +0530)
committerSURYA A U <a.u.surya@huawei.com>
Wed, 13 Sep 2017 09:47:42 +0000 (09:47 +0000)
few major issues in dblib module

Issue-Id: CCSDK-87
Change-Id: I6bc1fe2cf04cec0a5ad3bfb65bc3a10e5f488eea
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
dblib/provider/src/main/java/org/onap/ccsdk/sli/core/dblib/DBLIBResourceProvider.java
dblib/provider/src/main/java/org/onap/ccsdk/sli/core/dblib/TerminatingCachedDataSource.java

index 201cc40..c7f7600 100644 (file)
@@ -24,7 +24,6 @@ import com.google.common.annotations.VisibleForTesting;
 
 import java.io.File;
 import java.io.FileInputStream;
-import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.util.Optional;
 import java.util.Properties;
@@ -35,10 +34,6 @@ import org.onap.ccsdk.sli.core.dblib.propertiesfileresolver.DblibEnvVarFileResol
 import org.onap.ccsdk.sli.core.dblib.propertiesfileresolver.DblibJREFileResolver;
 import org.onap.ccsdk.sli.core.dblib.propertiesfileresolver.DblibKarafRootFileResolver;
 import org.onap.ccsdk.sli.core.dblib.propertiesfileresolver.DblibPropertiesFileResolver;
-import org.osgi.framework.BundleContext;
-import org.osgi.framework.FrameworkUtil;
-import org.osgi.framework.ServiceReference;
-import org.osgi.framework.ServiceRegistration;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
index 127e6d3..b4d1ef6 100644 (file)
@@ -33,38 +33,47 @@ public class TerminatingCachedDataSource extends CachedDataSource implements SQL
                super(jdbcElem);
        }
 
+       @Override
        protected void configure(BaseDBConfiguration jdbcElem) throws DBConfigException {
                // no action
        }
 
+       @Override
        public long getInterval() {
                return 1000;
        }
 
+       @Override
        public long getInitialDelay() {
                return 1000;
        }
 
+       @Override
        public long getExpectedCompletionTime() {
                return 50;
        }
 
+       @Override
        public void setExpectedCompletionTime(long value) {
                
        }
 
+       @Override
        public void setInterval(long value) {
                
        }
 
+       @Override
        public void setInitialDelay(long value) {
                
        }
 
+       @Override
        public long getUnprocessedFailoverThreshold() {
                return 3;
        }
 
+       @Override
        public void setUnprocessedFailoverThreshold(long value) {
                
        }
@@ -74,6 +83,7 @@ public class TerminatingCachedDataSource extends CachedDataSource implements SQL
                return 0;
        }
 
+       @Override
        public Logger getParentLogger() throws SQLFeatureNotSupportedException {
                // TODO Auto-generated method stub
                return null;