replace Thread sleep with Awaitility

- use '{}' for logger msg
- sonar suggest using use libraries
  Awaitility for asynchroneous testing

Issue-ID: POLICY-2616
Change-Id: I09828cdb9467235403f299c6419e8560ca21aefd
Signed-off-by: Taka Cho <takamune.cho@att.com>

diff --git a/feature-server-pool/src/test/java/org/onap/policy/drools/serverpool/AdapterImpl.java b/feature-server-pool/src/test/java/org/onap/policy/drools/serverpool/AdapterImpl.java
index 789dfe6..044067a 100644 (file)
--- a/feature-server-pool/src/test/java/org/onap/policy/drools/serverpool/AdapterImpl.java
+++ b/feature-server-pool/src/test/java/org/onap/policy/drools/serverpool/AdapterImpl.java
@@ -175,7 +175,7 @@ public class AdapterImpl extends Adapter {
             for (int i = 0; i < Bucket.BUCKETCOUNT; i += 1) {
                 Bucket bucket = Bucket.getBucket(i);
                 while (bucket.getOwner() == null) {
-                    Thread.sleep(Math.min(endTime - System.currentTimeMillis(), 100L));
+                    await().atMost(Math.min(endTime - System.currentTimeMillis(), 100L), TimeUnit.MILLISECONDS);
                 }
             }
         } catch (IllegalArgumentException e) {

diff --git a/feature-server-pool/src/test/java/org/onap/policy/drools/serverpooltest/Test1.java b/feature-server-pool/src/test/java/org/onap/policy/drools/serverpooltest/Test1.java
index 436cf77..fe52578 100644 (file)
--- a/feature-server-pool/src/test/java/org/onap/policy/drools/serverpooltest/Test1.java
+++ b/feature-server-pool/src/test/java/org/onap/policy/drools/serverpooltest/Test1.java
@@ -181,9 +181,7 @@ public class Test1 {
         UUID leaderUuid = firstAdapter.getLeader().getUuid();
         for (Adapter adapter : Adapter.adapters) {
             UUID uuid = adapter.getLeader().getUuid();
-            assertTrue(adapter.toString() + " has UUID " + uuid
-                       + " (expected UUID " + leaderUuid + ")",
-                       uuid.equals(leaderUuid));
+            assertEquals(adapter.toString(), leaderUuid, uuid);
         }
     }