Fix input for SDNC resource creaation

Fix version id and model name.
Fix input param for sdnc resource request.

Change-Id: I6ade488aec061c9bf4dc0cd04e124896a71571be
Issue-ID: SO-422
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>

diff --git a/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/resource/ResourceRequestBuilder.java b/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/resource/ResourceRequestBuilder.java
index 9aa1793..c72cc71 100644 (file)
--- a/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/resource/ResourceRequestBuilder.java
+++ b/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/resource/ResourceRequestBuilder.java
@@ -22,6 +22,7 @@ package org.openecomp.mso.bpmn.common.resource;
 
 import java.io.File;
 import java.io.IOException;
+import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.LinkedHashMap;
 import java.util.List;
@@ -120,7 +121,7 @@ public class ResourceRequestBuilder {
             throws SdcToscaParserException {
 
         Map<String, Object> resouceRequest = new HashMap<>();
-
+        List<Map<String, Object>> param = new ArrayList<>();
         String csarpath = null;
         try {
             csarpath = getCsarFromUuid(serviceUuid);
@@ -144,9 +145,13 @@ public class ResourceRequestBuilder {
                 Property property = resourceProperties.get(key);
 
                 Object value = getValue(property.getValue(), serviceInputs, serInput);
-                resouceRequest.put(key, value);
+                HashMap<String, Object> parameter = new HashMap<>();
+                parameter.put("name", key);
+                parameter.put("value", value);
+                param.add(parameter);
             }
         }
+        resouceRequest.put("param", param);
         return resouceRequest;
     }
 

diff --git a/bpmn/MSOInfrastructureBPMN/src/main/groovy/org/openecomp/mso/bpmn/infrastructure/scripts/CreateSDNCNetworkResource.groovy b/bpmn/MSOInfrastructureBPMN/src/main/groovy/org/openecomp/mso/bpmn/infrastructure/scripts/CreateSDNCNetworkResource.groovy
index 5eda2cc..62458ec 100644 (file)
--- a/bpmn/MSOInfrastructureBPMN/src/main/groovy/org/openecomp/mso/bpmn/infrastructure/scripts/CreateSDNCNetworkResource.groovy
+++ b/bpmn/MSOInfrastructureBPMN/src/main/groovy/org/openecomp/mso/bpmn/infrastructure/scripts/CreateSDNCNetworkResource.groovy
@@ -18,7 +18,10 @@
  * ============LICENSE_END=========================================================\r
  */\r
 \r
-package org.openecomp.mso.bpmn.infrastructure.scripts;\r
+package org.openecomp.mso.bpmn.infrastructure.scripts\r
+\r
+import org.json.JSONObject\r
+import org.json.XML;\r
 \r
 import static org.apache.commons.lang3.StringUtils.*;\r
 import groovy.xml.XmlUtil\r
@@ -144,8 +147,8 @@ public class CreateSDNCNetworkResource extends AbstractServiceTaskProcessor {
             String serviceType = resourceInputObj.getServiceType()\r
             String serviceModelInvariantUuid = resourceInputObj.getServiceModelInfo().getModelInvariantUuid()\r
             String serviceModelUuid = resourceInputObj.getServiceModelInfo().getModelUuid()\r
-            String serviceModelVersion = resourceInputObj.getServiceModelInfo().getModelName()\r
-            String serviceModelName = resourceInputObj.getServiceModelInfo().getModelVersion()\r
+            String serviceModelVersion = resourceInputObj.getServiceModelInfo().getModelVersion()\r
+            String serviceModelName = resourceInputObj.getServiceModelInfo().getModelName()\r
             String globalCustomerId = resourceInputObj.getGlobalSubscriberId()\r
             String modelInvariantUuid = resourceInputObj.getResourceModelInfo().getModelInvariantUuid();\r
             String modelCustomizationUuid = resourceInputObj.getResourceModelInfo().getModelCustomizationUuid()\r
@@ -155,7 +158,7 @@ public class CreateSDNCNetworkResource extends AbstractServiceTaskProcessor {
             String resourceInputPrameters = resourceInputObj.getResourceParameters()\r
             String netowrkInputParametersJson = jsonUtil.getJsonValue(resourceInputPrameters, "requestInputs")\r
             //here convert json string to xml string\r
-            String netowrkInputParameters = jsonUtil.json2xml(netowrkInputParametersJson)\r
+            String netowrkInputParameters = XML.toString(new JSONObject(netowrkInputParametersJson))\r
             // 1. prepare assign topology via SDNC Adapter SUBFLOW call\r
             String sndcTopologyCreateRequest =\r
                     """<aetgt:SDNCAdapterWorkflowRequest xmlns:aetgt="http://org.openecomp/mso/workflow/schema/v1"\r
@@ -179,7 +182,7 @@ public class CreateSDNCNetworkResource extends AbstractServiceTaskProcessor {
                                         <order-version></order-version>\r
                                      </request-information>\r
                                      <service-information>\r
-                                        <service-id>${sdnc_service_id}</service-id>\r
+                                        <service-id>${serviceInstanceId}</service-id>\r
                                         <subscription-service-type>${serviceType}</subscription-service-type>\r
                                         <ecomp-model-information>\r
                                              <model-invariant-uuid>${serviceModelInvariantUuid}</model-invariant-uuid>\r