Swap StringBuffer with StringBuilder everywhere 61/32761/2
authorMunir Ahmad <munir.ahmad@bell.ca>
Sat, 24 Feb 2018 17:34:32 +0000 (12:34 -0500)
committerMunir Ahmad <munir.ahmad@bell.ca>
Sat, 24 Feb 2018 17:35:57 +0000 (12:35 -0500)
Change-Id: Ia1f8d3ebc4026179bf08cdb0bd71c4480b8481df
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
19 files changed:
adapters/mso-sdnc-adapter/src/main/java/org/openecomp/mso/adapters/sdnc/impl/SDNCRestClient.java
asdc-controller/src/main/java/org/openecomp/mso/asdc/client/ASDCGlobalController.java
asdc-controller/src/main/java/org/openecomp/mso/asdc/installer/ASDCElementInfo.java
asdc-controller/src/main/java/org/openecomp/mso/asdc/installer/BigDecimalVersion.java
asdc-controller/src/main/java/org/openecomp/mso/asdc/installer/heat/ToscaResourceInstaller.java
asdc-controller/src/main/java/org/openecomp/mso/asdc/installer/heat/VfResourceInstaller.java
asdc-controller/src/main/java/org/openecomp/mso/asdc/util/ASDCNotificationLogging.java
asdc-controller/src/main/java/org/openecomp/mso/asdc/util/NotificationLogging.java
bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/util/CryptoUtils.java
bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/HealthCheckHandler.java
bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/domain/ServiceDecomposition.java
bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/json/JsonUtils.java
common/src/main/java/org/openecomp/mso/properties/MsoJsonProperties.java
common/src/main/java/org/openecomp/mso/utils/CryptoUtils.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/AllottedResourceCustomization.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/VfModule.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/VnfComponentsRecipe.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/VnfRecipe.java
mso-catalog-db/src/main/java/org/openecomp/mso/db/catalog/beans/VnfResource.java

index 45d5944..55a2156 100644 (file)
@@ -142,7 +142,7 @@ public class SDNCRestClient implements Runnable {
                DataOutputStream out = null;
                BufferedReader in = null;
                SDNCResponse sdncResp = new SDNCResponse(rt.getReqId());
-               StringBuffer response = new StringBuffer();
+               StringBuilder response = new StringBuilder();
 
                msoLogger.info(MessageEnum.RA_SEND_REQUEST_SDNC, rt.toString(), "SDNC", "");
                msoLogger.debug("SDNC Request Body:\n" + sdncReqBody);
index c0056e0..251888e 100644 (file)
@@ -49,7 +49,7 @@ public class ASDCGlobalController {
        
                List<String> controllerNames = ASDCConfiguration.getAllDefinedControllers();
 
-               StringBuffer controllerListLog = new StringBuffer("List of controllers loaded:");
+               StringBuilder controllerListLog = new StringBuilder("List of controllers loaded:");
                for (String controllerName : controllerNames) {
                        controllers.put(controllerName, new ASDCController(controllerName));
                        controllerListLog.append(controllerName);
index 3c262c6..29144a9 100644 (file)
@@ -109,7 +109,7 @@ public class ASDCElementInfo {
         */
        @Override
        public final String toString() {
-               StringBuffer sb = new StringBuffer();
+               StringBuilder sb = new StringBuilder();
                List<String> aggregatedElements = new ArrayList<>();
                for (Entry<String, String> entry : this.getElementInfoMap().entrySet()) {
                        aggregatedElements.add(entry.getKey() + ": " + entry.getValue());
index 5547bb1..c2faf1c 100644 (file)
@@ -34,7 +34,7 @@ public class BigDecimalVersion {
     public static BigDecimal castAndCheckNotificationVersion(String version) {
        // Truncate the version if bad type
        String[] splitVersion = version.split("\\.");
-       StringBuffer newVersion = new StringBuffer();
+       StringBuilder newVersion = new StringBuilder();
        if (splitVersion.length > 1) {
                newVersion.append(splitVersion[0]);
                newVersion.append(".");
index b998be9..f22debc 100644 (file)
@@ -636,7 +636,7 @@ public class ToscaResourceInstaller {// implements IVfResourceInstaller {
                        return body; \r
                } \r
  \r
-               StringBuffer sb = new StringBuffer(body.length()); \r
+               StringBuilder sb = new StringBuilder(body.length());\r
  \r
                int currentIndex = 0; \r
                int startIndex = 0; \r
index bd20eb0..0ae58da 100644 (file)
@@ -631,7 +631,7 @@ public class VfResourceInstaller implements IVfResourceInstaller {
                        return body;
                }
 
-               StringBuffer sb = new StringBuffer(body.length());
+               StringBuilder sb = new StringBuilder(body.length());
 
                int currentIndex = 0;
                int startIndex = 0;
index 28f5dbd..a7ba013 100644 (file)
@@ -42,7 +42,7 @@ public class ASDCNotificationLogging {
                if (asdcNotification == null) {
                        return "NULL";
                }
-               StringBuffer buffer = new StringBuffer("ASDC Notification:");
+               StringBuilder buffer = new StringBuilder("ASDC Notification:");
                buffer.append(System.lineSeparator());
 
                buffer.append("DistributionID:");
@@ -96,7 +96,7 @@ public class ASDCNotificationLogging {
                }
                
 
-               StringBuffer buffer = new StringBuffer("CSAR Notification:");
+               StringBuilder buffer = new StringBuilder("CSAR Notification:");
                buffer.append(System.lineSeparator());
                buffer.append(System.lineSeparator());
                
@@ -286,7 +286,7 @@ public class ASDCNotificationLogging {
                        return null;
                }
 
-               StringBuffer buffer = new StringBuffer("VfModuleMetaData List:");
+               StringBuilder buffer = new StringBuilder("VfModuleMetaData List:");
                buffer.append(System.lineSeparator());
 
                buffer.append("{");
@@ -311,7 +311,7 @@ public class ASDCNotificationLogging {
                        return "NULL";
                }
 
-               StringBuffer buffer = new StringBuffer("VfModuleMetaData:");
+               StringBuilder buffer = new StringBuilder("VfModuleMetaData:");
                buffer.append(System.lineSeparator());
 
                buffer.append("VfModuleModelName:");
@@ -395,7 +395,7 @@ public class ASDCNotificationLogging {
                        return null;
                }
 
-               StringBuffer buffer = new StringBuffer();
+               StringBuilder buffer = new StringBuilder();
                buffer.append("{");
 
                for (IResourceInstance resourceInstanceElem:asdcNotification.getResources()) {
@@ -418,7 +418,7 @@ public class ASDCNotificationLogging {
                        return null;
                }
 
-               StringBuffer buffer = new StringBuffer("Resource Instance Info:");
+               StringBuilder buffer = new StringBuilder("Resource Instance Info:");
                buffer.append(System.lineSeparator());
 
                buffer.append("ResourceInstanceName:");
@@ -473,7 +473,7 @@ public class ASDCNotificationLogging {
                        return null;
                }
 
-               StringBuffer buffer = new StringBuffer();
+               StringBuilder buffer = new StringBuilder();
                buffer.append("{");
                for (IArtifactInfo artifactInfoElem:artifactsList) {
                        buffer.append(System.lineSeparator());
@@ -495,7 +495,7 @@ public class ASDCNotificationLogging {
                        return null;
                }
 
-               StringBuffer buffer = new StringBuffer("Service Artifacts Info:");
+               StringBuilder buffer = new StringBuilder("Service Artifacts Info:");
                buffer.append(System.lineSeparator());
 
                buffer.append("ArtifactName:");
index 9b38a50..126114d 100644 (file)
@@ -82,7 +82,7 @@ public class NotificationLogging implements InvocationHandler {
                        return "EMPTY"; // No declared methods in this class !!!
                }
                
-               StringBuffer buffer = new StringBuffer("ASDC Notification:");
+               StringBuilder buffer = new StringBuilder("ASDC Notification:");
                buffer.append(System.lineSeparator());
                
                for (Method m : declaredMethods) {
index 8d2b33c..5972c76 100644 (file)
@@ -75,7 +75,7 @@ public class CryptoUtils {
 \r
 \r
     private static String byteArrayToHexString(byte[] b){\r
-        StringBuffer sb = new StringBuffer(b.length * 2);\r
+        StringBuilder sb = new StringBuilder(b.length * 2);\r
         for (byte aB : b) {\r
             int v = aB & 0xff;\r
             if (v < 16) {\r
index 204d9e4..584ccda 100644 (file)
@@ -238,7 +238,7 @@ public class HealthCheckHandler  {
         BPMNLogger.debug(healthcheckDebugEnabled, "Post url is: " + url);
 
         //now create a soap request message as follows:
-        final StringBuffer payload = new StringBuffer();
+        final StringBuilder payload = new StringBuilder();
         payload.append("\n");
         payload.append("<soapenv:Envelope xmlns:soapenv=\"http://schemas.xmlsoap.org/soap/envelope/\" xmlns:req=\"" + adapterNamespace + "/requestsdb\">\n");
         payload.append("<soapenv:Header/>\n");
@@ -270,7 +270,7 @@ public class HealthCheckHandler  {
         BufferedReader rd = new BufferedReader(
                 new InputStreamReader(response.getEntity().getContent()));
 
-        StringBuffer result = new StringBuffer();
+        StringBuilder result = new StringBuilder();
         String line = "";
         while ((line = rd.readLine()) != null) {
             result.append(line);
index 0e985cc..f5283f4 100644 (file)
@@ -150,7 +150,7 @@ public class ServiceDecomposition extends JsonWrapper implements Serializable {
         */\r
        @JsonIgnore\r
        public String getServiceResourcesJsonString(){\r
-               StringBuffer serviceResourcesJsonStringBuffer = new StringBuffer();\r
+               StringBuilder serviceResourcesJsonStringBuffer = new StringBuilder();\r
                serviceResourcesJsonStringBuffer.append(listToJson((this.getServiceNetworks())));\r
                serviceResourcesJsonStringBuffer.append(listToJson((this.getServiceVnfs())));\r
                serviceResourcesJsonStringBuffer.append(listToJson((this.getServiceAllottedResources())));\r
index 640dc69..b47d73f 100644 (file)
@@ -122,7 +122,7 @@ public class JsonUtils {
         * @return String containing the XML translation\r
         */\r
        public static String toXMLString(Object obj, String tagName) throws JSONException {\r
-               StringBuffer strBuf = new StringBuffer();\r
+               StringBuilder strBuf = new StringBuilder();\r
                int i;\r
                JSONArray jsonArr;\r
                JSONObject jsonObj;\r
index c0997f3..cf69e1c 100644 (file)
@@ -159,7 +159,7 @@ public class MsoJsonProperties extends AbstractMsoProperties {
 
        @Override
        public String toString() {
-               StringBuffer response = new StringBuffer();
+               StringBuilder response = new StringBuilder();
                response.append("Config file " + propertiesFileName + "(Timer:" + automaticRefreshInMinutes + "mins):"
                                + System.getProperty("line.separator"));
                response.append(this.jsonRootNode.toString());
index 55fe69b..5d0ff5b 100644 (file)
@@ -72,7 +72,7 @@ public final class CryptoUtils {
     }
 
     public static String byteArrayToHexString (byte[] b) {
-        StringBuffer sb = new StringBuffer (b.length * 2);
+        StringBuilder sb = new StringBuilder(b.length * 2);
         for (byte aB : b) {
             int v = aB & 0xff;
             if (v < 16) {
index 66db7df..daeefcc 100644 (file)
@@ -131,7 +131,7 @@ public class AllottedResourceCustomization extends MavenLikeVersioning implement
 
        @Override
        public String toString () {
-               StringBuffer sb = new StringBuffer();
+               StringBuilder sb = new StringBuilder();
                sb.append("modelCustomizationUuid=");
                sb.append(this.modelCustomizationUuid);
                sb.append(",modelInstanceName=");
index fd2b6ff..cd2821a 100644 (file)
@@ -142,7 +142,7 @@ public class VfModule extends MavenLikeVersioning implements Serializable {
 
        @Override
        public String toString () {
-       StringBuffer buf = new StringBuffer();
+       StringBuilder buf = new StringBuilder();
 
        buf.append("VFModule:");
        buf.append("modelName=");
index 1e5f69c..42d6b82 100644 (file)
@@ -64,7 +64,7 @@ public class VnfComponentsRecipe extends Recipe implements Serializable {
 
        @Override
        public String toString () {
-               StringBuffer sb = new StringBuffer();
+               StringBuilder sb = new StringBuilder();
                sb.append(super.toString());
                sb.append (",vnfComponentParamXSD=" + vnfComponentParamXSD);
                sb.append (",serviceType=" + getServiceType ());
index 55bb33a..29e4b89 100644 (file)
@@ -56,7 +56,7 @@ public class VnfRecipe extends Recipe implements Serializable {
        
        @Override
        public String toString () {
-               StringBuffer sb = new StringBuffer();
+               StringBuilder sb = new StringBuilder();
                sb.append(super.toString());
                sb.append (",vnfParamXSD=" + vnfParamXSD);
                sb.append (",serviceType=" + getServiceType ());
index 7495015..37040d6 100644 (file)
@@ -240,7 +240,7 @@ public class VnfResource extends MavenLikeVersioning implements Serializable {
 
        @Override
        public String toString () {
-               StringBuffer buf = new StringBuffer();
+               StringBuilder buf = new StringBuilder();
 
                buf.append("VNF=");
                buf.append(",modelVersion=");