fixed sonar issues in ConfigureNodeExecutor.java

fixed sonar issues

Issue-ID: CCSDK-525
Change-Id: I14e357eeab5aaa2736f6c6492925e860e9029f80
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>

diff --git a/sli/provider-base/src/main/java/org/onap/ccsdk/sli/core/sli/provider/base/ConfigureNodeExecutor.java b/sli/provider-base/src/main/java/org/onap/ccsdk/sli/core/sli/provider/base/ConfigureNodeExecutor.java
index 7ffdfca..5d6a083 100644 (file)
--- a/sli/provider-base/src/main/java/org/onap/ccsdk/sli/core/sli/provider/base/ConfigureNodeExecutor.java
+++ b/sli/provider-base/src/main/java/org/onap/ccsdk/sli/core/sli/provider/base/ConfigureNodeExecutor.java
@@ -40,6 +40,8 @@ public class ConfigureNodeExecutor extends AbstractSvcLogicNodeExecutor {
        private static final Logger LOG = LoggerFactory
                        .getLogger(ConfigureNodeExecutor.class);
        private static final String CAUGHT_EXCEPTION_MSG="Caught exception from ";
+       private static final String ALREADY_ACTIVE= "already-active";
+       private static final String NOT_FOUND= "not-found";
 
        public SvcLogicNode execute(SvcLogicServiceBase svc, SvcLogicNode node,
                        SvcLogicContext ctx) throws SvcLogicException {
@@ -108,10 +110,10 @@ public class ConfigureNodeExecutor extends AbstractSvcLogicNodeExecutor {
                                                        case SUCCESS:
                                                                break;
                                                        case ALREADY_ACTIVE:
-                                                               outValue = "already-active";
+                                                               outValue = ALREADY_ACTIVE;
                                                                break;
                                                        case NOT_FOUND:
-                                                               outValue = "not-found";
+                                                               outValue = NOT_FOUND;
                                                                break;
                                                        case NOT_READY:
                                                                outValue = "not-ready";
@@ -134,10 +136,10 @@ public class ConfigureNodeExecutor extends AbstractSvcLogicNodeExecutor {
                                                        case SUCCESS:
                                                                break;
                                                        case ALREADY_ACTIVE:
-                                                               outValue = "already-active";
+                                                               outValue = ALREADY_ACTIVE;
                                                                break;
                                                        case NOT_FOUND:
-                                                               outValue = "not-found";
+                                                               outValue = NOT_FOUND;
                                                                break;
                                                        case NOT_READY:
                                                                outValue = "not-ready";
@@ -150,10 +152,10 @@ public class ConfigureNodeExecutor extends AbstractSvcLogicNodeExecutor {
                                        }
                                        break;
                                case ALREADY_ACTIVE:
-                                       outValue = "already-active";
+                                       outValue = ALREADY_ACTIVE;
                                        break;
                                case NOT_FOUND:
-                                       outValue = "not-found";
+                                       outValue = NOT_FOUND;
                                        break;
                                case NOT_READY:
                                        outValue = "not-ready";
@@ -177,10 +179,10 @@ public class ConfigureNodeExecutor extends AbstractSvcLogicNodeExecutor {
                                                        outValue = "success";
                                                        break;
                                                case ALREADY_ACTIVE:
-                                                       outValue = "already-active";
+                                                       outValue = ALREADY_ACTIVE;
                                                        break;
                                                case NOT_FOUND:
-                                                       outValue = "not-found";
+                                                       outValue = NOT_FOUND;
                                                        break;
                                                case NOT_READY:
                                                        outValue = "not-ready";
@@ -203,10 +205,10 @@ public class ConfigureNodeExecutor extends AbstractSvcLogicNodeExecutor {
                                                        outValue = "success";
                                                        break;
                                                case ALREADY_ACTIVE:
-                                                       outValue = "already-active";
+                                                       outValue = ALREADY_ACTIVE;
                                                        break;
                                                case NOT_FOUND:
-                                                       outValue = "not-found";
+                                                       outValue = NOT_FOUND;
                                                        break;
                                                case NOT_READY:
                                                        outValue = "not-ready";