fixed sonar issue in MsoNetworkAdapterAsyncImpl 55/65055/4
authorSandeep J <sandeejh@in.ibm.com>
Thu, 6 Sep 2018 18:42:16 +0000 (00:12 +0530)
committerByung-Woo Jun <byung-woo.jun@ericsson.com>
Mon, 10 Sep 2018 11:47:11 +0000 (11:47 +0000)
fixed sonar issue as detailed in SO-988

Issue-ID: SO-988
Change-Id: I66fcee5129fb749a887db2f6eab0f9fd2cdb1e36
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
adapters/mso-openstack-adapters/src/main/java/org/onap/so/adapters/network/MsoNetworkAdapterAsyncImpl.java

index de8aedc..2eeed77 100644 (file)
@@ -22,7 +22,7 @@
  */
 
 package org.onap.so.adapters.network;
-
 
 import java.net.MalformedURLException;
 import java.net.URL;
@@ -196,9 +196,9 @@ public class MsoNetworkAdapterAsyncImpl implements MsoNetworkAdapterAsync {
                                                   copyCreateSubnetIdMap (subnetIdMap),
                                                   copyNrb (networkRollback));
         } catch (Exception e) {
-            error = "Error sending createNetwork notification " + e.getMessage ();
-            LOGGER.error (MessageEnum.RA_CREATE_NETWORK_NOTIF_EXC, "", "", MsoLogger.ErrorCode.DataError, "Exception sending createNetwork notification", e);
-            alarmLogger.sendAlarm ("MsoInternalError", MsoAlarmLogger.CRITICAL, error);
+            error = CREATE_NETWORK_ERROR_MSG + e.getMessage ();
+            LOGGER.error (MessageEnum.RA_CREATE_NETWORK_NOTIF_EXC, "", "", MsoLogger.ErrorCode.DataError, CREATE_NETWORK_EXCEPTON_MSG, e);
+            alarmLogger.sendAlarm (MSO_INTERNAL_ERROR_MSG, MsoAlarmLogger.CRITICAL, error);
         }
         return;
     }