Return http 404 for wrong prefix, not 401 80/106080/1
authorBartek Grzybowski <b.grzybowski@partner.samsung.com>
Thu, 16 Apr 2020 08:35:48 +0000 (01:35 -0700)
committerBartek Grzybowski <b.grzybowski@partner.samsung.com>
Thu, 16 Apr 2020 08:35:48 +0000 (01:35 -0700)
The correct http code for wrong REST API url should
be http "404 Not Found", not "401 Unauthorized".

Change-Id: I78710fcd4c43926dbba3227c4099bf6239095f19
Issue-ID: INT-1529
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
test/mocks/prov-mns-provider/src/ProvMnSProvider.py

index e9d488e..da445e2 100644 (file)
@@ -83,10 +83,11 @@ class ServerHTTP(BaseHTTPRequestHandler):
                 print("Fail to get MOI object: "+'/' +className+'/'+idName)
                 self.send_response(406)
         else:
-            self.send_response(401)
             if prefix_check is True:
+                self.send_response(401)
                 response['error'] = {"errorInfo":"not Authorized"}
             else:
+                self.send_response(404)
                 response['error'] = {"errorInfo":"wrong prefix"}
         self.send_header("Content-type","application/json")
         self.end_headers()
@@ -151,10 +152,11 @@ class ServerHTTP(BaseHTTPRequestHandler):
                 print("Fail to modify MOI object: "+'/' +className+'/'+idName)
                 self.send_response(406)
         else:
-            self.send_response(401)
             if prefix_check is True:
+                self.send_response(401)
                 response['error'] = {"errorInfo":"not Authorized"}
             else:
+                self.send_response(404)
                 response['error'] = {"errorInfo":"wrong prefix"}
         self.send_header("Content-type","application/json")
         self.end_headers()
@@ -203,10 +205,11 @@ class ServerHTTP(BaseHTTPRequestHandler):
                 print("Fail to delete MOI object: "+'/' +className+'/'+idName)
                 self.send_response(406)
         else:
-            self.send_response(401)
             if prefix_check is True:
+                self.send_response(401)
                 response['error'] = {"errorInfo":"not Authorized"}
             else:
+                self.send_response(404)
                 response['error'] = {"errorInfo":"wrong prefix"}
         self.send_header("Content-type","application/json")
         self.end_headers()
@@ -252,10 +255,11 @@ class ServerHTTP(BaseHTTPRequestHandler):
                 print("Fail to create MOI object: "+'/' +className+'/'+idName)
                 self.send_response(406)
         else:
-            self.send_response(401)
             if prefix_check is True:
+                self.send_response(401)
                 response['error'] = {"errorInfo":"not Authorized"}
             else:
+                self.send_response(404)
                 response['error'] = {"errorInfo":"wrong prefix"}
         self.send_header("Content-type","application/json")
         self.end_headers()