Remove wait for welcome screen in UI tests 84/119484/2
authorandre.schmid <andre.schmid@est.tech>
Mon, 15 Mar 2021 17:52:43 +0000 (17:52 +0000)
committerChristophe Closset <christophe.closset@intl.att.com>
Thu, 18 Mar 2021 11:26:11 +0000 (11:26 +0000)
Remove unnecessary wait for the welcome screen after the login.
The welcome screen doesn't exist anymore.

Change-Id: Iddd57016fbb2a890029cd24b18a5fadc3c5ddb3d
Issue-ID: SDC-3522
Signed-off-by: andre.schmid <andre.schmid@est.tech>
integration-tests/src/test/java/org/onap/sdc/frontend/ci/tests/execute/setup/SetupCDTest.java

index c3afc0b..638f0b4 100644 (file)
@@ -334,27 +334,22 @@ public abstract class SetupCDTest extends DriverFactory {
         getWindowTest().setUser(credentials);
     }
 
-    private void goToHomePage(UserRoleEnum role) throws Exception {
-        final int gettingButtonTimeOut = 10;
+    private void goToHomePage(final UserRoleEnum role) {
+        if (UserRoleEnum.ADMIN.equals(role)) {
+            return;
+        }
         try {
             getWindowTest().setRefreshAttempts(getWindowTest().getRefreshAttempts() == 0 ? NUM_OF_ATTEMPTS_TO_REFTRESH : getWindowTest().getRefreshAttempts());
-            if (!role.equals(UserRoleEnum.ADMIN)) {
-
-                WebElement closeButton = GeneralUIUtils.getClickableButtonBy(By.className("sdc-welcome-close"), gettingButtonTimeOut);
-                if (closeButton != null) {
-                    closeButton.click();
-                }
-
-                if (!GeneralUIUtils.isElementVisibleByTestId(DataTestIdEnum.MainMenuButtons.HOME_BUTTON.getValue())) {
-                    restartBrowser(role);
-                }
+            if (!GeneralUIUtils.isElementVisibleByTestId(DataTestIdEnum.MainMenuButtons.HOME_BUTTON.getValue())) {
+                restartBrowser(role);
             }
-        } catch (Exception e) {
+        } catch (final Exception e) {
+            LOGGER.debug("An error has occurred while loading the home page", e);
             restartBrowser(role);
         }
     }
 
-    private void restartBrowser(UserRoleEnum role) throws Exception {
+    private void restartBrowser(UserRoleEnum role) {
         getWindowTest().setRefreshAttempts(getWindowTest().getRefreshAttempts() - 1);
         if (getWindowTest().getRefreshAttempts() <= 0) {
             System.out.println("ERR : Something is wrong with browser!");