Fix Sonar issues in sli/core module
authorsurya-huawei <a.u.surya@huawei.com>
Sun, 17 Sep 2017 17:23:41 +0000 (22:53 +0530)
committersurya-huawei <a.u.surya@huawei.com>
Sun, 17 Sep 2017 17:30:18 +0000 (23:00 +0530)
One major issue
* Use try with resources instead of try

Issue-Id: CCSDK-87
Change-Id: Ic30016f70ebc355f80a73c9e4632b7971d2b87be
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
sli/recording/src/main/java/org/onap/ccsdk/sli/core/sli/recording/FileRecorder.java

index 4a60de9..772906e 100644 (file)
@@ -82,7 +82,6 @@ public class FileRecorder implements SvcLogicRecorder {
                }
                
                File recordFile = new File(fileName);
-               PrintWriter recPrinter = null;
                FileWriter fileWriter = null;
                Date now = new Date();
 
@@ -94,10 +93,9 @@ public class FileRecorder implements SvcLogicRecorder {
                        record = record.replaceFirst("__TIMESTAMP__", dateFmt.format(now));
                }
                
-               try
+               try ( PrintWriter recPrinter = new PrintWriter(fileWriter = new
+                               FileWriter(recordFile, true)))
                {
-               
-                       recPrinter = new PrintWriter(fileWriter = new FileWriter(recordFile, true));
                        recPrinter.println(record);
                }
                catch (Exception e)
@@ -106,10 +104,6 @@ public class FileRecorder implements SvcLogicRecorder {
                }
                finally
                {
-                       if (recPrinter != null)
-                       {
-                               recPrinter.close();
-                       }
                        if (fileWriter != null)
                        {
                                try {