Increase code coverage

Issue-ID: SDC-3388
Signed-off-by: Edyta Krukowska <edyta.krukowska@nokia.com>
Change-Id: I4cf8c47bc05e550edb29399b25aa87d8f1d93ecf

diff --git a/sdc-distribution-client/src/test/java/org/onap/sdc/http/HttpClientFactoryTest.java b/sdc-distribution-client/src/test/java/org/onap/sdc/http/HttpClientFactoryTest.java
new file mode 100644 (file)
index 0000000..4594fb9
--- /dev/null
+++ b/sdc-distribution-client/src/test/java/org/onap/sdc/http/HttpClientFactoryTest.java
@@ -0,0 +1,86 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * sdc-distribution-client
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.onap.sdc.http;
+
+import org.apache.http.client.CredentialsProvider;
+import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
+import org.apache.http.impl.client.BasicCredentialsProvider;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClientBuilder;
+import org.junit.Test;
+import org.onap.sdc.utils.Pair;
+import org.onap.sdc.utils.TestConfiguration;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.when;
+
+
+public class HttpClientFactoryTest {
+
+    @Test
+    public void shouldReturnSSLConnection(){
+        TestConfiguration config = spy(new TestConfiguration());
+        HttpClientFactory httpClientFactory = new HttpClientFactory(config);
+        when(config.activateServerTLSAuth()).thenReturn(true);
+        when(config.getKeyStorePath()).thenReturn("src/test/resources/asdc-client.jks");
+        when(config.getKeyStorePassword()).thenReturn("Aa123456");
+        Pair<String, CloseableHttpClient> client =  httpClientFactory.createInstance();
+        SSLConnectionSocketFactory sslsf = spy(SSLConnectionSocketFactory.getSocketFactory());
+        CredentialsProvider credsProvider = new BasicCredentialsProvider();
+        CloseableHttpClient expectedHttpClient = HttpClientBuilder.create().
+                setDefaultCredentialsProvider(credsProvider).
+                setSSLSocketFactory(sslsf).
+                build();
+        Pair<String, CloseableHttpClient> expectedClient = new Pair<>("https://", expectedHttpClient);
+        assertNotNull(client);
+        assertEquals(expectedClient.getFirst(), client.getFirst());
+    }
+
+    @Test
+    public void shouldReturnSSLConnectionWithHttp(){
+        TestConfiguration config = spy(new TestConfiguration());
+        HttpClientFactory httpClientFactory = new HttpClientFactory(config);
+        when(config.activateServerTLSAuth()).thenReturn(false);
+        when(config.isUseHttpsWithSDC()).thenReturn(false);
+        Pair<String, CloseableHttpClient> client =  httpClientFactory.createInstance();
+        SSLConnectionSocketFactory sslsf = spy(SSLConnectionSocketFactory.getSocketFactory());
+        CredentialsProvider credsProvider = new BasicCredentialsProvider();
+        CloseableHttpClient expectedHttpClient = HttpClientBuilder.create().
+                setDefaultCredentialsProvider(credsProvider).
+                setSSLSocketFactory(sslsf).
+                build();
+        Pair<String, CloseableHttpClient> expectedClient = new Pair<>("http://", expectedHttpClient);
+        assertNotNull(client);
+        assertEquals(expectedClient.getFirst(), client.getFirst());
+    }
+
+    @Test (expected = HttpAsdcClientException.class)
+    public void shouldReturnSSLConnectionError() throws HttpAsdcClientException{
+        TestConfiguration config = spy(new TestConfiguration());
+        HttpClientFactory httpClientFactory = new HttpClientFactory(config);
+        when(config.activateServerTLSAuth()).thenReturn(true);
+        when(config.getKeyStorePath()).thenReturn("src/test/resources/dummy.jks");
+        when(config.getKeyStorePassword()).thenReturn("Aa123456");
+        httpClientFactory.createInstance();
+    }
+
+}
\ No newline at end of file

diff --git a/sdc-distribution-client/src/test/resources/asdc-client.jks b/sdc-distribution-client/src/test/resources/asdc-client.jks
new file mode 100644 (file)
index 0000000..eb0a0d3
Binary files /dev/null and b/sdc-distribution-client/src/test/resources/asdc-client.jks differ