Fix some major sonar issues

*Use collection.isEmpty() instead of collection.size
*Remove unnecessary commented line
 This is done for increasing code readability
*Pass the string object directly
 Instead of wrapping the returned object and
 creating a new object, passing the object itself will save
 memory

Issue-Id: SO-118
Change-Id: I24c15e9270ec3422d35d3910a8aff9fcf8d632d9
Signed-off-by: surya-huawei <a.u.surya@huawei.com>

diff --git a/adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/BpelRestClient.java b/adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/BpelRestClient.java
index b7ab504..6c571f3 100644 (file)
--- a/adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/BpelRestClient.java
+++ b/adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/BpelRestClient.java
@@ -166,7 +166,7 @@ public class BpelRestClient {
        }
 
        public String getRetryList() {
-               if (retryList.size() == 0)
+               if (retryList.isEmpty())
                        return "";
                String t = retryList.toString();
                return t.substring(1, t.length()-1);

diff --git a/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java b/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java
index a4f1046..77e5b85 100644 (file)
--- a/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java
+++ b/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java
@@ -234,7 +234,6 @@ public class BpelRestClient {
        }
        private void debug(String m) {
                LOGGER.debug(m);
-//             System.err.println(m);
        }
        private void sendOne(final String toBpelStr, final String bpelUrl, final boolean isxml) {
                LOGGER.debug("Sending to BPEL server: "+bpelUrl);

diff --git a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java
index a73eec5..cd23991 100644 (file)
--- a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java
+++ b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java
@@ -60,7 +60,7 @@ public class BPELRestClient extends RequestClient {
                                                                 CommonConstants.ENCRYPTION_KEY);
                 if (userCredentials != null) {
                     post.addHeader ("Authorization",
-                                    "Basic " + new String (DatatypeConverter.printBase64Binary (userCredentials.getBytes ())));
+                                    "Basic " + DatatypeConverter.printBase64Binary (userCredentials.getBytes ()));
                 }
             }
         }