[SDC-139] Check the validity of input parameter 13/6013/2
authorDave Chen <wei.d.chen@intel.com>
Wed, 19 Jul 2017 04:49:24 +0000 (12:49 +0800)
committerDave Chen <wei.d.chen@intel.com>
Mon, 24 Jul 2017 04:22:13 +0000 (12:22 +0800)
Change-Id: Ib0a5826f7d472b77413360e0161cb3e3ec776431
Signed-off-by: Dave Chen <wei.d.chen@intel.com>
src/main/java/org/openecomp/sdc/tosca/parser/impl/SdcCsarHelperImpl.java

index eae0aac..3b87986 100644 (file)
@@ -798,8 +798,14 @@ public class SdcCsarHelperImpl implements ISdcCsarHelper {
 
     //Assumed to be unique property for the list
     private NodeTemplate getNodeTemplateByCustomizationUuid(List<NodeTemplate> nodeTemplates, String customizationId) {
-        Optional<NodeTemplate> findFirst = nodeTemplates.stream().filter(x -> (x.getMetaData() != null && customizationId.equals(x.getMetaData().getValue(PROPERTY_NAME_CUSTOMIZATIONUUID)))).findFirst();
-        return findFirst.isPresent() ? findFirst.get() : null;
+       if (customizationId != null) {
+            Optional<NodeTemplate> findFirst = nodeTemplates.stream().filter(x -> (x.getMetaData() != null && customizationId.equals(x.getMetaData().getValue(PROPERTY_NAME_CUSTOMIZATIONUUID)))).findFirst();
+            return findFirst.isPresent() ? findFirst.get() : null;
+        }
+        else {
+            log.error("getNodeTemplateByCustomizationUuid - customizationId is null");
+            return null;
+        }
     }
 
     private Object processProperties(String[] split, LinkedHashMap<String, Property> properties) {