Fix Sonar issues ResourceBaseValidator

Fixed few reported sonar issues.
One sonar issue is ignored as it would involve change
in method signature of public method

Change-Id: Ib0c97ebce5b05dcc0e7dd3d46f25557cc51c31d8
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>

diff --git a/openecomp-be/lib/openecomp-sdc-validation-lib/openecomp-sdc-validation-sdk/src/main/java/org/openecomp/sdc/validation/base/ResourceBaseValidator.java b/openecomp-be/lib/openecomp-sdc-validation-lib/openecomp-sdc-validation-sdk/src/main/java/org/openecomp/sdc/validation/base/ResourceBaseValidator.java
index 68c1b74..5013283 100644 (file)
--- a/openecomp-be/lib/openecomp-sdc-validation-lib/openecomp-sdc-validation-sdk/src/main/java/org/openecomp/sdc/validation/base/ResourceBaseValidator.java
+++ b/openecomp-be/lib/openecomp-sdc-validation-lib/openecomp-sdc-validation-sdk/src/main/java/org/openecomp/sdc/validation/base/ResourceBaseValidator.java
@@ -34,11 +34,11 @@ import java.util.Objects;
 public class ResourceBaseValidator implements Validator {
 
   protected Map<String, ImplementationConfiguration> resourceTypeToImpl = new HashMap<>();
-  private static Logger logger = (Logger) LoggerFactory.getLogger(ResourceBaseValidator.class);
+  private static Logger logger = LoggerFactory.getLogger(ResourceBaseValidator.class);
   private static final ErrorMessageCode ERROR_CODE_RBV_1 = new ErrorMessageCode("RBV1");
   private static final ErrorMessageCode ERROR_CODE_RBV_2 = new ErrorMessageCode("RBV2");
 
-
+@Override
   public void init(Map<String, Object> properties) {
     if (MapUtils.isEmpty(properties)) {
       return;
@@ -156,8 +156,8 @@ public class ResourceBaseValidator implements Validator {
     implementationConfiguration.setImplementationClass(
         valueAsMap.get(ConfigConstants.Impl_Class).toString());
     if (valueAsMap.containsKey(ConfigConstants.Enable)) {
-      implementationConfiguration.setEnable((Boolean.
-          valueOf(valueAsMap.get(ConfigConstants.Enable).toString())));
+      implementationConfiguration.setEnable(Boolean.
+          valueOf(valueAsMap.get(ConfigConstants.Enable).toString()));
     }
 
     return implementationConfiguration;