Add flag for modern UI

Issue-ID: VID-544
Change-Id: Iad79353ff9f55416d87b5bef56e38dd01357003b
Signed-off-by: Rina Roi <rina.roi@intl.att.com>

diff --git a/vid-app-common/src/main/java/org/onap/vid/properties/Features.java b/vid-app-common/src/main/java/org/onap/vid/properties/Features.java
index c96efe6..bc3c6c8 100644 (file)
--- a/vid-app-common/src/main/java/org/onap/vid/properties/Features.java
+++ b/vid-app-common/src/main/java/org/onap/vid/properties/Features.java
@@ -48,6 +48,7 @@ public enum Features implements Feature {
     FLAG_ASYNC_ALACARTE_VFMODULE,
     FLAG_SUPPLEMENTARY_FILE,
     FLAG_EXP_ANY_ALACARTE_NEW_INSTANTIATION_UI,
+    FLAG_ENABLE_WEBPACK_MODERN_UI,
     FLAG_1810_CR_LET_SELECTING_COLLECTOR_TYPE_UNCONDITIONALLY,
     FLAG_1810_CR_ADD_CLOUD_OWNER_TO_MSO_REQUEST,
     FLAG_1810_CR_SOFT_DELETE_ALACARTE_VF_MODULE,

diff --git a/vid-app-common/src/main/webapp/WEB-INF/conf/dev.features.properties b/vid-app-common/src/main/webapp/WEB-INF/conf/dev.features.properties
index 123c15e..ae57a31 100644 (file)
--- a/vid-app-common/src/main/webapp/WEB-INF/conf/dev.features.properties
+++ b/vid-app-common/src/main/webapp/WEB-INF/conf/dev.features.properties
@@ -1,4 +1,4 @@
-FLAG_ASYNC_INSTANTIATION = true
+FLAG_ENABLE_WEBPACK_MODERN_UI = true
 FLAG_ASYNC_JOBS = true
 CREATE_INSTANCE_TEST = false
 EMPTY_DRAWING_BOARD_TEST = false

diff --git a/vid-app-common/src/main/webapp/WEB-INF/conf/onap.features.properties b/vid-app-common/src/main/webapp/WEB-INF/conf/onap.features.properties
index 23c5b25..adff111 100644 (file)
--- a/vid-app-common/src/main/webapp/WEB-INF/conf/onap.features.properties
+++ b/vid-app-common/src/main/webapp/WEB-INF/conf/onap.features.properties
@@ -19,7 +19,7 @@ FLAG_CREATE_ERROR_REPORTS = true
 # Modern UI (Drawing-Board; View/Edit)
 # - - - - - - - - - - - - - - - - - -
 FLAG_COLLECTION_RESOURCE_SUPPORT = false
-FLAG_ASYNC_INSTANTIATION = false
+FLAG_ENABLE_WEBPACK_MODERN_UI = false
 FLAG_ASYNC_JOBS = false
 EMPTY_DRAWING_BOARD_TEST = false
 FLAG_NETWORK_TO_ASYNC_INSTANTIATION = false

diff --git a/vid-app-common/src/main/webapp/app/vid/scripts/constants/componentConstants.js b/vid-app-common/src/main/webapp/app/vid/scripts/constants/componentConstants.js
index 3d6ed67..01b8e8a 100755 (executable)
--- a/vid-app-common/src/main/webapp/app/vid/scripts/constants/componentConstants.js
+++ b/vid-app-common/src/main/webapp/app/vid/scripts/constants/componentConstants.js
@@ -246,7 +246,7 @@ appDS2
     },
 
     FEATURE_FLAGS: {
-      FLAG_ASYNC_INSTANTIATION: "FLAG_ASYNC_INSTANTIATION",
+      FLAG_ENABLE_WEBPACK_MODERN_UI: "FLAG_ENABLE_WEBPACK_MODERN_UI",
       FLAG_NETWORK_TO_ASYNC_INSTANTIATION: "FLAG_NETWORK_TO_ASYNC_INSTANTIATION",
       FLAG_ADD_MSO_TESTAPI_FIELD: "FLAG_ADD_MSO_TESTAPI_FIELD",
       FLAG_SHOW_ASSIGNMENTS: "FLAG_SHOW_ASSIGNMENTS",

diff --git a/vid-app-common/src/main/webapp/app/vid/scripts/services/asdcService.js b/vid-app-common/src/main/webapp/app/vid/scripts/services/asdcService.js
index b9bab0e..eb3ea46 100755 (executable)
--- a/vid-app-common/src/main/webapp/app/vid/scripts/services/asdcService.js
+++ b/vid-app-common/src/main/webapp/app/vid/scripts/services/asdcService.js
@@ -22,8 +22,6 @@
 \r
 var AsdcService = function ($http, $log, PropertyService, UtilityService, VIDCONFIGURATION, COMPONENT, DataService, featureFlags) {\r
     var shouldExcludeMacroFromAsyncInstantiationFlow = function(serviceModel){\r
-        if (!featureFlags.isOn(COMPONENT.FEATURE_FLAGS.FLAG_ASYNC_INSTANTIATION))\r
-            return true;\r
         if (DataService.getE2EService())\r
             return true;\r
         if (!_.isEmpty(serviceModel.pnfs))\r
@@ -51,7 +49,8 @@ var AsdcService = function ($http, $log, PropertyService, UtilityService, VIDCON
         },\r
 \r
         shouldTakeTheDrawingBoardViewEdit: function(serviceModel) {\r
-            if (serviceModel.service.vidNotions\r
+            if (this.enableWebpackModernUi()\r
+                && serviceModel.service.vidNotions\r
                 && serviceModel.service.vidNotions.viewEditUI\r
                 && serviceModel.service.vidNotions.viewEditUI !== 'legacy'\r
             ) return true;\r
@@ -59,8 +58,14 @@ var AsdcService = function ($http, $log, PropertyService, UtilityService, VIDCON
             return false;\r
         },\r
 \r
+        enableWebpackModernUi: function(){\r
+            return featureFlags.isOn(COMPONENT.FEATURE_FLAGS.FLAG_ENABLE_WEBPACK_MODERN_UI);\r
+        },\r
+\r
         shouldTakeTheAsyncInstantiationFlow: function(serviceModel) {\r
-            // First of all, respect serviceModel.service.vidNotions.instantiationUI\r
+            if (!(this.enableWebpackModernUi()))\r
+                return false;\r
+            // Assuming positive flag - first of all, respect serviceModel.service.vidNotions.instantiationUI\r
             if (serviceModel.service.vidNotions\r
                 && serviceModel.service.vidNotions.instantiationUI\r
                 && serviceModel.service.vidNotions.instantiationUI !== 'legacy'\r

diff --git a/vid-automation/src/main/java/vid/automation/test/infra/Features.java b/vid-automation/src/main/java/vid/automation/test/infra/Features.java
index 40f3013..2cc790f 100644 (file)
--- a/vid-automation/src/main/java/vid/automation/test/infra/Features.java
+++ b/vid-automation/src/main/java/vid/automation/test/infra/Features.java
@@ -23,6 +23,7 @@ public enum Features implements Feature {
     FLAG_ASYNC_ALACARTE_VFMODULE,
     FLAG_SUPPLEMENTARY_FILE,
     FLAG_EXP_ANY_ALACARTE_NEW_INSTANTIATION_UI,
+    FLAG_ENABLE_WEBPACK_MODERN_UI,
     FLAG_1810_CR_LET_SELECTING_COLLECTOR_TYPE_UNCONDITIONALLY,
     FLAG_1810_CR_ADD_CLOUD_OWNER_TO_MSO_REQUEST,
     FLAG_1810_CR_SOFT_DELETE_ALACARTE_VF_MODULE,

diff --git a/vid-automation/src/main/java/vid/automation/test/test/NewServiceInstanceTest.java b/vid-automation/src/main/java/vid/automation/test/test/NewServiceInstanceTest.java
index 9b1956d..7e9dac4 100644 (file)
--- a/vid-automation/src/main/java/vid/automation/test/test/NewServiceInstanceTest.java
+++ b/vid-automation/src/main/java/vid/automation/test/test/NewServiceInstanceTest.java
@@ -56,6 +56,7 @@ import static vid.automation.test.services.SimulatorApi.registerExpectationFromP
 import static vid.automation.test.services.SimulatorApi.registerExpectationFromPresets;
 import static vid.automation.test.test.ALaCarteflowTest.AIC;
 
+@FeatureTogglingTest(FLAG_ENABLE_WEBPACK_MODERN_UI)
 public class NewServiceInstanceTest extends CreateInstanceDialogBaseTest {
 
     public static final String COMPLETED = "COMPLETED";

diff --git a/vid-automation/src/test/resources/features.properties b/vid-automation/src/test/resources/features.properties
index 782d289..7ab0785 100644 (file)
--- a/vid-automation/src/test/resources/features.properties
+++ b/vid-automation/src/test/resources/features.properties
@@ -16,6 +16,7 @@ FLAG_ASYNC_ALACARTE_VNF = true
 FLAG_ASYNC_ALACARTE_VFMODULE= true
 FLAG_SUPPLEMENTARY_FILE = true
 FLAG_EXP_ANY_ALACARTE_NEW_INSTANTIATION_UI=false
+FLAG_ENABLE_WEBPACK_MODERN_UI = false
 FLAG_1810_CR_ADD_CLOUD_OWNER_TO_MSO_REQUEST=true
 FLAG_1810_CR_LET_SELECTING_COLLECTOR_TYPE_UNCONDITIONALLY=true
 FLAG_1810_CR_SOFT_DELETE_ALACARTE_VF_MODULE = true

diff --git a/vid-webpack-master/cypress/support/jsonBuilders/mocks/jsons/flags.json b/vid-webpack-master/cypress/support/jsonBuilders/mocks/jsons/flags.json
index c4b8ef4..2451d1e 100644 (file)
--- a/vid-webpack-master/cypress/support/jsonBuilders/mocks/jsons/flags.json
+++ b/vid-webpack-master/cypress/support/jsonBuilders/mocks/jsons/flags.json
@@ -15,5 +15,6 @@
   "FLAG_1902_NEW_VIEW_EDIT": true,
   "FLAG_VF_MODULE_RESUME_STATUS_CREATE" : true,
   "FLAG_1906_COMPONENT_INFO": true,
-  "FLAG_1908_RESUME_MACRO_SERVICE": true
+  "FLAG_1908_RESUME_MACRO_SERVICE": true,
+  "FLAG_ENABLE_WEBPACK_MODERN_UI": true
 }

diff --git a/vid-webpack-master/src/app/drawingBoard/service-planning/objectsToTree/models/vrf/vrfModal/networkStep/network.step.service.spec.ts b/vid-webpack-master/src/app/drawingBoard/service-planning/objectsToTree/models/vrf/vrfModal/networkStep/network.step.service.spec.ts
index e06e4c9..c7c8d07 100644 (file)
--- a/vid-webpack-master/src/app/drawingBoard/service-planning/objectsToTree/models/vrf/vrfModal/networkStep/network.step.service.spec.ts
+++ b/vid-webpack-master/src/app/drawingBoard/service-planning/objectsToTree/models/vrf/vrfModal/networkStep/network.step.service.spec.ts
@@ -87,7 +87,7 @@ describe('Network step service', () => {
           "CREATE_INSTANCE_TEST": false,
           "EMPTY_DRAWING_BOARD_TEST": false,
           "FLAG_NETWORK_TO_ASYNC_INSTANTIATION": false,
-          "FLAG_ASYNC_INSTANTIATION": true,
+          "FLAG_ENABLE_WEBPACK_MODERN_UI": true,
           "FLAG_ASYNC_JOBS": true,
           "FLAG_ADD_MSO_TESTAPI_FIELD": true,
           "FLAG_UNASSIGN_SERVICE": false,