Fix Sonar NetworkDaoZusammenImpl

Fixed reported sonar issues

Change-Id: I2c401fd6b18a74d74096494ff7b15bc4d53df10e
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>

diff --git a/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/NetworkDaoZusammenImpl.java b/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/NetworkDaoZusammenImpl.java
index bccea3a..ba79fc4 100644 (file)
--- a/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/NetworkDaoZusammenImpl.java
+++ b/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/NetworkDaoZusammenImpl.java
@@ -37,7 +37,7 @@ public class NetworkDaoZusammenImpl implements NetworkDao {
 
   @Override
   public void registerVersioning(String versionableEntityType) {
-
+    // registerVersioning not implemented for NetworkDaoZusammenImpl
   }
 
   @Override
@@ -52,10 +52,9 @@ public class NetworkDaoZusammenImpl implements NetworkDao {
       return new ArrayList<>();
     }
 
-    ElementToNetworkConvertor convertor = new ElementToNetworkConvertor();
     return zusammenAdaptor.listElementsByName(context, elementContext, vspModel.get().getId(),
         ElementType.Networks.name()).stream()
-        .map(convertor::convert)
+        .map(new ElementToNetworkConvertor()::convert)
         .map(entity -> {
           entity.setVspId(network.getVspId());
           entity.setVersion(network.getVersion());