Sonar fix
Issue-ID: APPC-1554
Change-Id: I8ff882baf26e765b9b8bcf23bcc37b11a3567ded
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
* Copyright (C) 2017 Amdocs
* ================================================================================
* Modifications (C) 2019 Ericsson
* Copyright (C) 2017 Amdocs
* ================================================================================
* Modifications (C) 2019 Ericsson
+ * Modifications (C) 2019 IBM
* =============================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* =============================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
private static final String ATTR_VNFC_FUNC_CODE = "VNFC-FUNCTION-CODE";
private static final String ATTR_VSERVER_NAME = "vserver-name";
private static final String ATTR_VNF_ID = "vnf-id";
private static final String ATTR_VNFC_FUNC_CODE = "VNFC-FUNCTION-CODE";
private static final String ATTR_VSERVER_NAME = "vserver-name";
private static final String ATTR_VNF_ID = "vnf-id";
+ private static final String ATTR_VF_MODULE_ID = "vf-module-id";
private AAIClient aaiClient;
private AAIClient aaiClient;
//ConfigScaleOut - Do not process vms that are not associated with vfmodule id if vfmodule id is present
if (StringUtils.isNotBlank(vfModuleIdFromRequest)) {
//ConfigScaleOut - Do not process vms that are not associated with vfmodule id if vfmodule id is present
if (StringUtils.isNotBlank(vfModuleIdFromRequest)) {
- String vmVfModuleId = ctx.getAttribute(aaiRefKey + "vf-module-id");
+ String vmVfModuleId = ctx.getAttribute(aaiRefKey + ATTR_VF_MODULE_ID);
log.info("insertVnfcs():::vfModule for vm is=" + vmVfModuleId);
if (StringUtils.isBlank(vmVfModuleId) || !StringUtils
.equalsIgnoreCase(vmVfModuleId, vfModuleIdFromRequest)) {
log.info("insertVnfcs():::vfModule for vm is=" + vmVfModuleId);
if (StringUtils.isBlank(vmVfModuleId) || !StringUtils
.equalsIgnoreCase(vmVfModuleId, vfModuleIdFromRequest)) {
vnfcParams.put("relationship-list.relationship[2].relationship-data[1].relationship-key",
"vf-module.vf-module-id");
vnfcParams.put("relationship-list.relationship[2].relationship-data[1].relationship-value",
vnfcParams.put("relationship-list.relationship[2].relationship-data[1].relationship-key",
"vf-module.vf-module-id");
vnfcParams.put("relationship-list.relationship[2].relationship-data[1].relationship-value",
- ctx.getAttribute(aaiRefKey + "vf-module-id"));
+ ctx.getAttribute(aaiRefKey + ATTR_VF_MODULE_ID));
String ind = "tmp.vnfInfo.vm[" + i + "].";
String aaiFuncCode = ctx.getAttribute(ind + "vnfc-function-code");
String aaiGroupNotation = ctx.getAttribute(ind + "group-notation");
String ind = "tmp.vnfInfo.vm[" + i + "].";
String aaiFuncCode = ctx.getAttribute(ind + "vnfc-function-code");
String aaiGroupNotation = ctx.getAttribute(ind + "group-notation");
- String aaiVfModuleId = ctx.getAttribute(ind + "vf-module-id");
+ String aaiVfModuleId = ctx.getAttribute(ind + ATTR_VF_MODULE_ID);
log.info("getGroupNotationForExistigValue()::: vfModuleId=" + vfModuleId + ", aaiFuncCode=" + aaiFuncCode
+ ", aaiGroupNotation=" + aaiGroupNotation + ",aaiVfMOduleId=" + aaiVfModuleId);
log.info("getGroupNotationForExistigValue()::: vfModuleId=" + vfModuleId + ", aaiFuncCode=" + aaiFuncCode
+ ", aaiGroupNotation=" + aaiGroupNotation + ",aaiVfMOduleId=" + aaiVfModuleId);