Addressed the following issues:
- unused parameter in method call
- make constructor of abstract class protected instead of public
Issue-ID: POLICY-2905
Change-Id: I1e846b88246796f1ad5cee4a3bd296647732fd24
Signed-off-by: Jim Hahn <jrh3@att.com>
* @param config configuration for this operation
* @param propertyNames names of properties required by this operation
*/
* @param config configuration for this operation
* @param propertyNames names of properties required by this operation
*/
- public SoOperation(ControlLoopOperationParams params, HttpPollingConfig config, List<String> propertyNames) {
+ protected SoOperation(ControlLoopOperationParams params, HttpPollingConfig config, List<String> propertyNames) {
super(params, config, SoResponse.class, propertyNames);
this.modelCustomizationId = null;
super(params, config, SoResponse.class, propertyNames);
this.modelCustomizationId = null;
* @param propertyNames names of properties required by this operation
* @param targetEntityIds Target Entity information
*/
* @param propertyNames names of properties required by this operation
* @param targetEntityIds Target Entity information
*/
- public SoOperation(ControlLoopOperationParams params, HttpPollingConfig config, List<String> propertyNames,
+ protected SoOperation(ControlLoopOperationParams params, HttpPollingConfig config, List<String> propertyNames,
Map<String, String> targetEntityIds) {
super(params, config, SoResponse.class, propertyNames);
Map<String, String> targetEntityIds) {
super(params, config, SoResponse.class, propertyNames);
* IllegalArgumentException if the desired data item is not found.
*/
* IllegalArgumentException if the desired data item is not found.
*/
- protected GenericVnf getVnfItem(SoModelInfo soModelInfo) {
+ protected GenericVnf getVnfItem() {
return getRequiredProperty(OperationProperties.AAI_VNF, "generic VNF");
}
return getRequiredProperty(OperationProperties.AAI_VNF, "generic VNF");
}
*/
protected Pair<String, SoRequest> makeRequest() {
final SoModelInfo soModelInfo = prepareSoModelInfo();
*/
protected Pair<String, SoRequest> makeRequest() {
final SoModelInfo soModelInfo = prepareSoModelInfo();
- final GenericVnf vnfItem = getVnfItem(soModelInfo);
+ final GenericVnf vnfItem = getVnfItem();
final ServiceInstance vnfServiceItem = getServiceInstance();
final Tenant tenantItem = getDefaultTenant();
final CloudRegion cloudRegionItem = getDefaultCloudRegion();
final ServiceInstance vnfServiceItem = getServiceInstance();
final Tenant tenantItem = getDefaultTenant();
final CloudRegion cloudRegionItem = getDefaultCloudRegion();
*/
protected Pair<String, SoRequest> makeRequest() {
final SoModelInfo soModelInfo = prepareSoModelInfo();
*/
protected Pair<String, SoRequest> makeRequest() {
final SoModelInfo soModelInfo = prepareSoModelInfo();
- final GenericVnf vnfItem = getVnfItem(soModelInfo);
+ final GenericVnf vnfItem = getVnfItem();
final ServiceInstance vnfServiceItem = getServiceInstance();
final Tenant tenantItem = getDefaultTenant();
final CloudRegion cloudRegionItem = getDefaultCloudRegion();
final ServiceInstance vnfServiceItem = getServiceInstance();
final Tenant tenantItem = getDefaultTenant();
final CloudRegion cloudRegionItem = getDefaultCloudRegion();