summary |
shortlog |
log |
commit | commitdiff |
review |
tree
raw |
patch |
inline | side by side (from parent 1:
69fec3e)
few major issues
https://sonar.onap.org/dashboard/index?id=org.onap.ccsdk.sli.plugins%3Arestapi-call-node-provider%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fccsdk%2Fsli%2Fplugins%2Frestapicall%2FRestapiCallNode.java
Issue-ID: SDNC-75
Change-Id: Ida6ea182545bf57513bcd958519e3b50dfa004b2
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
if (retryCount < retryPolicy.getMaximumRetries() + 1) {
URI uri = new URI(paramMap.get("restapiUrl"));
String hostname = uri.getHost();
if (retryCount < retryPolicy.getMaximumRetries() + 1) {
URI uri = new URI(paramMap.get("restapiUrl"));
String hostname = uri.getHost();
- String retryString = retryPolicy.getNextHostName((uri.toString()));
+ String retryString = retryPolicy.getNextHostName(uri.toString());
URI uriTwo = new URI(retryString);
URI retryUri = UriBuilder.fromUri(uri).host(uriTwo.getHost()).port(uriTwo.getPort()).scheme(
uriTwo.getScheme()).build();
URI uriTwo = new URI(retryString);
URI retryUri = UriBuilder.fromUri(uri).host(uriTwo.getHost()).port(uriTwo.getPort()).scheme(
uriTwo.getScheme()).build();
p.responsePrefix = parseParam(paramMap, "responsePrefix", false, null);
p.listNameList = getListNameList(paramMap);
String skipSendingStr = paramMap.get("skipSending");
p.responsePrefix = parseParam(paramMap, "responsePrefix", false, null);
p.listNameList = getListNameList(paramMap);
String skipSendingStr = paramMap.get("skipSending");
- p.skipSending = skipSendingStr != null && skipSendingStr.equalsIgnoreCase("true");
+ p.skipSending = "true".equalsIgnoreCase(skipSendingStr);
p.convertResponse = Boolean.valueOf(parseParam(paramMap, "convertResponse", false, "true"));
p.trustStoreFileName = parseParam(paramMap, "trustStoreFileName", false, null);
p.trustStorePassword = parseParam(paramMap, "trustStorePassword", false, null);
p.convertResponse = Boolean.valueOf(parseParam(paramMap, "convertResponse", false, "true"));
p.trustStoreFileName = parseParam(paramMap, "trustStoreFileName", false, null);
p.trustStorePassword = parseParam(paramMap, "trustStorePassword", false, null);
protected Set<String> getListNameList(Map<String, String> paramMap) {
Set<String> ll = new HashSet<String>();
protected Set<String> getListNameList(Map<String, String> paramMap) {
Set<String> ll = new HashSet<String>();
- for (String key : paramMap.keySet())
- if (key.startsWith("listName"))
- ll.add(paramMap.get(key));
+ for (Map.Entry<String,String> entry : paramMap.entrySet())
+ if (entry.getKey().startsWith("listName"))
+ ll.add(entry.getValue());
}
protected void setFailureResponseStatus(SvcLogicContext ctx, String prefix, String errorMessage, HttpResponse r) {
}
protected void setFailureResponseStatus(SvcLogicContext ctx, String prefix, String errorMessage, HttpResponse r) {
- r = new HttpResponse();
- r.code = 500;
- r.message = errorMessage;
+ HttpResponse resp = new HttpResponse();
+ resp.code = 500;
+ resp.message = errorMessage;
String pp = prefix != null ? prefix + '.' : "";
String pp = prefix != null ? prefix + '.' : "";
- ctx.setAttribute(pp + "response-code", String.valueOf(r.code));
- ctx.setAttribute(pp + "response-message", r.message);
+ ctx.setAttribute(pp + "response-code", String.valueOf(resp.code));
+ ctx.setAttribute(pp + "response-message", resp.message);
}
protected void setResponseStatus(SvcLogicContext ctx, String prefix, HttpResponse r) {
}
protected void setResponseStatus(SvcLogicContext ctx, String prefix, HttpResponse r) {
String pp = p.responsePrefix != null ? p.responsePrefix + '.' : "";
String pp = p.responsePrefix != null ? p.responsePrefix + '.' : "";
if (p.templateFileName == null) {
log.info("No template file name specified. Using default UEB template: " + defaultUebTemplateFileName);
if (p.templateFileName == null) {
log.info("No template file name specified. Using default UEB template: " + defaultUebTemplateFileName);
p.rootVarName = parseParam(paramMap, "rootVarName", false, null);
p.responsePrefix = parseParam(paramMap, "responsePrefix", false, null);
String skipSendingStr = paramMap.get("skipSending");
p.rootVarName = parseParam(paramMap, "rootVarName", false, null);
p.responsePrefix = parseParam(paramMap, "responsePrefix", false, null);
String skipSendingStr = paramMap.get("skipSending");
- p.skipSending = skipSendingStr != null && skipSendingStr.equalsIgnoreCase("true");
+ p.skipSending = "true".equalsIgnoreCase(skipSendingStr);