https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#fileUuids=AV3BnsdG5bp_wwmIVCEu|resolved=false|severities=MAJOR
Issue-Id:SO-118
Change-Id: I9ce4b3cb4c5acc5d19183dc278e4907aae221443
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
String resourceType = vfResourceStructure.getResourceInstance().getResourceType();
String resourceCategory = vfResourceStructure.getResourceInstance().getCategory();
String resourceType = vfResourceStructure.getResourceInstance().getResourceType();
String resourceCategory = vfResourceStructure.getResourceInstance().getCategory();
- if(resourceType.equals("VF")){
+ if("VF".equals(resourceType)){
if(resourceCategory.equalsIgnoreCase("Allotted Resource")){
VfResourceInstaller.createAllottedResourceCustomization(vfResourceStructure);
if(resourceCategory.equalsIgnoreCase("Allotted Resource")){
VfResourceInstaller.createAllottedResourceCustomization(vfResourceStructure);
- if(resourceType.equals("VL")){
+ if("VL".equals(resourceType)){
VfResourceInstaller.createNetworkResourceCustomization(vfResourceStructure);
catalogDB.saveNetworkResourceCustomization(vfResourceStructure.getCatalogNetworkResourceCustomization());
}
VfResourceInstaller.createNetworkResourceCustomization(vfResourceStructure);
catalogDB.saveNetworkResourceCustomization(vfResourceStructure.getCatalogNetworkResourceCustomization());
}
catalogDB.saveService(vfResourceStructure.getCatalogService());
// Now that the service has been added we can populate the Service_to_AllottedResources table
catalogDB.saveService(vfResourceStructure.getCatalogService());
// Now that the service has been added we can populate the Service_to_AllottedResources table
- if(resourceType.equals("VF") && resourceCategory.equalsIgnoreCase("Allotted Resource")){
+ if("VF".equals(resourceType) && "Allotted Resource".equalsIgnoreCase(resourceCategory)){
catalogDB.saveServiceToAllottedResources(vfResourceStructure.getCatalogServiceToAllottedResources());
}
// Now that the service has been added we can populate the Service_to_Network table
catalogDB.saveServiceToAllottedResources(vfResourceStructure.getCatalogServiceToAllottedResources());
}
// Now that the service has been added we can populate the Service_to_Network table
- if(resourceType.equals("VL")){
+ if("VL".equals(resourceType)){
catalogDB.saveServiceToNetworks(vfResourceStructure.getCatalogServiceToNetworks());
}
catalogDB.saveServiceToNetworks(vfResourceStructure.getCatalogServiceToNetworks());
}
// heatTemplate.setAsdcResourceName(vfResourceStructure.getResourceInstance().getResourceName());
heatTemplate.setAsdcUuid(vfModuleArtifact.getArtifactInfo().getArtifactUUID());
// heatTemplate.setAsdcResourceName(vfResourceStructure.getResourceInstance().getResourceName());
heatTemplate.setAsdcUuid(vfModuleArtifact.getArtifactInfo().getArtifactUUID());
- List<String> typeList = new ArrayList<String>();
+ List<String> typeList = new ArrayList<>();
typeList.add(ASDCConfiguration.HEAT_NESTED);
typeList.add(ASDCConfiguration.HEAT_ARTIFACT);
typeList.add(ASDCConfiguration.HEAT_NESTED);
typeList.add(ASDCConfiguration.HEAT_ARTIFACT);
// TODO Set the label
// heatEnvironment.setAsdcLabel("Label");
// TODO Set the label
// heatEnvironment.setAsdcLabel("Label");
- List<String> typeList = new ArrayList<String>();
+ List<String> typeList = new ArrayList<>();
typeList.add(ASDCConfiguration.HEAT);
typeList.add(ASDCConfiguration.HEAT_VOL);
typeList.add(ASDCConfiguration.HEAT);
typeList.add(ASDCConfiguration.HEAT_VOL);