Using constant names instead of numbers
Removed an unused handler
Issue-ID: AAF-99
Change-Id: I16101576daee140acd40c3db906dd22289d71188
Signed-off-by: Kiran Kamineni <kiran.k.kamineni@intel.com>
"github.com/gorilla/mux"
"net/http"
"github.com/gorilla/mux"
"net/http"
err := json.NewDecoder(r.Body).Decode(&d)
if err != nil {
err := json.NewDecoder(r.Body).Decode(&d)
if err != nil {
- http.Error(w, err.Error(), 400)
+ http.Error(w, err.Error(), http.StatusBadRequest)
return
}
dom, err := h.secretBackend.CreateSecretDomain(d.Name)
if err != nil {
return
}
dom, err := h.secretBackend.CreateSecretDomain(d.Name)
if err != nil {
- http.Error(w, err.Error(), 500)
+ http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
err = json.NewEncoder(w).Encode(dom)
if err != nil {
return
}
err = json.NewEncoder(w).Encode(dom)
if err != nil {
- http.Error(w, err.Error(), 400)
+ http.Error(w, err.Error(), http.StatusInternalServerError)
-// getSecretDomainHandler returns list of secret domains
-func (h handler) getSecretDomainHandler(w http.ResponseWriter, r *http.Request) {
- vars := mux.Vars(r)
- domName := vars["domName"]
-
- fmt.Fprintf(w, "Got req %s", domName)
- //h.secretBackend.GetSecretDomain(domName)
- //encode data into json and return
-}
-
// deleteSecretDomainHandler deletes a secret domain with the name provided
func (h handler) deleteSecretDomainHandler(w http.ResponseWriter, r *http.Request) {
vars := mux.Vars(r)
// deleteSecretDomainHandler deletes a secret domain with the name provided
func (h handler) deleteSecretDomainHandler(w http.ResponseWriter, r *http.Request) {
vars := mux.Vars(r)
var b smsbackend.Secret
err := json.NewDecoder(r.Body).Decode(&b)
if err != nil {
var b smsbackend.Secret
err := json.NewDecoder(r.Body).Decode(&b)
if err != nil {
- http.Error(w, err.Error(), 400)
+ http.Error(w, err.Error(), http.StatusBadRequest)
return
}
err = h.secretBackend.CreateSecret(domName, b)
if err != nil {
return
}
err = h.secretBackend.CreateSecret(domName, b)
if err != nil {
- http.Error(w, err.Error(), 500)
+ http.Error(w, err.Error(), http.StatusInternalServerError)
sec, err := h.secretBackend.GetSecret(domName, secName)
if err != nil {
sec, err := h.secretBackend.GetSecret(domName, secName)
if err != nil {
- http.Error(w, err.Error(), 500)
+ http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
err = json.NewEncoder(w).Encode(sec)
if err != nil {
return
}
err = json.NewEncoder(w).Encode(sec)
if err != nil {
- http.Error(w, err.Error(), 400)
+ http.Error(w, err.Error(), http.StatusInternalServerError)
func (h handler) statusHandler(w http.ResponseWriter, r *http.Request) {
s, err := h.secretBackend.GetStatus()
if err != nil {
func (h handler) statusHandler(w http.ResponseWriter, r *http.Request) {
s, err := h.secretBackend.GetStatus()
if err != nil {
- http.Error(w, err.Error(), 500)
+ http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
status := backendStatus{Seal: s}
err = json.NewEncoder(w).Encode(status)
if err != nil {
return
}
status := backendStatus{Seal: s}
err = json.NewEncoder(w).Encode(status)
if err != nil {
- http.Error(w, err.Error(), 500)
+ http.Error(w, err.Error(), http.StatusInternalServerError)
router.HandleFunc("/v1/sms/init", h.initSMSHandler).Methods("POST")
router.HandleFunc("/v1/sms/domain", h.createSecretDomainHandler).Methods("POST")
router.HandleFunc("/v1/sms/init", h.initSMSHandler).Methods("POST")
router.HandleFunc("/v1/sms/domain", h.createSecretDomainHandler).Methods("POST")
- router.HandleFunc("/v1/sms/domain/{domName}", h.getSecretDomainHandler).Methods("GET")
router.HandleFunc("/v1/sms/domain/{domName}", h.deleteSecretDomainHandler).Methods("DELETE")
router.HandleFunc("/v1/sms/domain/{domName}/secret", h.createSecretHandler).Methods("POST")
router.HandleFunc("/v1/sms/domain/{domName}", h.deleteSecretDomainHandler).Methods("DELETE")
router.HandleFunc("/v1/sms/domain/{domName}/secret", h.createSecretHandler).Methods("POST")