https://sonar.onap.org/project/issues?id=org.onap.dmaap.datarouter%3Aparent&open=AWWU4OsgxOv3LmQdDYyE&resolved=false&severities=BLOCKER&types=BUG
Issue-ID: DMAAP-698
Change-Id: I1609a5c300e55f1eb8bd8b4966d456fb3905cc00
Signed-off-by: Amaresh Kumar <kamaresh@in.ibm.com>
public static void reload() {\r
Map<String, Integer> m = new HashMap<String, Integer>();\r
PreparedStatement ps = null;\r
public static void reload() {\r
Map<String, Integer> m = new HashMap<String, Integer>();\r
PreparedStatement ps = null;\r
try {\r
DB db = new DB();\r
@SuppressWarnings("resource")\r
Connection conn = db.getConnection();\r
String sql = "select NODEID, NAME from NODES";\r
ps = conn.prepareStatement(sql);\r
try {\r
DB db = new DB();\r
@SuppressWarnings("resource")\r
Connection conn = db.getConnection();\r
String sql = "select NODEID, NAME from NODES";\r
ps = conn.prepareStatement(sql);\r
- rs = ps.executeQuery();\r
- while (rs.next()) {\r
- int id = rs.getInt("NODEID");\r
- String name = rs.getString("NAME");\r
- m.put(name, id);\r
+ try(ResultSet rs = ps.executeQuery()) {\r
+ while (rs.next()) {\r
+ int id = rs.getInt("NODEID");\r
+ String name = rs.getString("NAME");\r
+ m.put(name, id);\r
+ }\r
ps.close();\r
db.release(conn);\r
} catch (SQLException e) {\r
ps.close();\r
db.release(conn);\r
} catch (SQLException e) {\r
if(ps!=null){\r
ps.close();\r
}\r
if(ps!=null){\r
ps.close();\r
}\r
- if(rs!=null){\r
- rs.close();\r
- }\r
-\r
} catch (SQLException e) {\r
intLogger.error("PROV0005 doInsert: " + e.getMessage(),e);\r
}\r
} catch (SQLException e) {\r
intLogger.error("PROV0005 doInsert: " + e.getMessage(),e);\r
}\r