Fix validation northbound cm handle searches 85/141385/2
authorToineSiebelink <toine.siebelink@est.tech>
Wed, 25 Jun 2025 12:22:38 +0000 (13:22 +0100)
committerToineSiebelink <toine.siebelink@est.tech>
Wed, 25 Jun 2025 13:48:00 +0000 (14:48 +0100)
commit35faa11f7e99a7a9e056d235a2ba57f6c71adbd9
treea4cadbabdb651b5e59ef892f8f79183eb68a54ff
parent30a77b69293810efec56e243caf04dadd7f8796f
Fix validation northbound cm handle searches

- Renamed related methods and Enum using terms north (client facing) and southbound (dmi) for more clarity
- Northbound Cm Handle search was using the wrong Enum for validation (this caused the issue)
- Grouped and ordered renamed methods in facade impl
- Enums also had the wrong values: unsupported values in one and missing values in the other
  (southbound can/should support all possible queries, no reason not too)
TODO (separate subtasks and commits)
- Update RTD documentation to properly describe options in each ifc
- Update Postman collection to have cleared separation between north and southbound interfaces

Issue-ID: CPS-2864
Change-Id: I6523b368e504b5e99dde794e7e716193d2cadf23
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
12 files changed:
cps-ncmp-rest/src/main/java/org/onap/cps/ncmp/rest/controller/NetworkCmProxyController.java
cps-ncmp-rest/src/main/java/org/onap/cps/ncmp/rest/controller/NetworkCmProxyInventoryController.java
cps-ncmp-rest/src/test/groovy/org/onap/cps/ncmp/rest/controller/NetworkCmProxyControllerSpec.groovy
cps-ncmp-rest/src/test/groovy/org/onap/cps/ncmp/rest/controller/NetworkCmProxyInventoryControllerSpec.groovy
cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/inventory/NetworkCmProxyInventoryFacade.java
cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/NetworkCmProxyInventoryFacadeImpl.java
cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/ParameterizedCmHandleQueryServiceImpl.java
cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/models/NorthboundCmHandleQuerySupportedConditions.java [moved from cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/models/CmHandleQueryConditions.java with 71% similarity]
cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/models/SouthboundCmHandleQuerySupportedConditions.java [moved from cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/models/InventoryQueryConditions.java with 67% similarity]
cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/impl/inventory/NetworkCmProxyInventoryFacadeSpec.groovy
cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/impl/inventory/models/NorthboundCmHandleQuerySupportedConditionsSpec.groovy [moved from cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/impl/inventory/models/CmHandleQueryConditionsSpec.groovy with 70% similarity]
cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/impl/inventory/models/SouthboundCmHandleQuerySupportedConditionsSpec.groovy [moved from cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/impl/inventory/models/InventoryQueryConditionsSpec.groovy with 63% similarity]