Fix issues missed by checkstyle 30/142930/1
authorToineSiebelink <toine.siebelink@est.tech>
Wed, 14 Jan 2026 16:29:40 +0000 (16:29 +0000)
committerToineSiebelink <toine.siebelink@est.tech>
Wed, 14 Jan 2026 17:17:32 +0000 (17:17 +0000)
commit06d701f833d791662bebb0ccfb8410008d537bc4
treea4caca0d5bc3bbf168a5964c0123907d42a93dd7
parenta68faa1d60214e17afb55fe31281e61c72a3b2d2
Fix issues missed by checkstyle

- Added a module in our checkstyle config to check for unused variable
  (very surprised this was never there)
- the missing finals in ProvMnSException were a false positive since there was a @NoArgsContructor
  (surprised Sonar didnt realize that)
- it was still a code smell though and I refactored the code so we didn't need the allArgsConstructor anymore (nor setters)
- also fixed valid warning on access level noArgsCosntructor (checkstyle never caught those before so that's ok)

Issue-ID: CPS-3128
Change-Id: I6acc5bd9bc6bd18f30a346e8049ce6ee456c580a
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
checkstyle/src/main/resources/cps-checkstyle/cps-java-style.xml
cps-ncmp-rest/src/main/java/org/onap/cps/ncmp/rest/controller/ProvMnSController.java
cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/exceptions/ProvMnSException.java
cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/provmns/ParameterHelper.java
cps-service/src/main/java/org/onap/cps/impl/CpsDataServiceImpl.java