Fix service registration for SDNC 97/10597/1
authorRyan Goulding <ryandgoulding@gmail.com>
Wed, 6 Sep 2017 15:47:00 +0000 (11:47 -0400)
committerRyan Goulding <ryandgoulding@gmail.com>
Wed, 6 Sep 2017 15:50:20 +0000 (11:50 -0400)
commit21788cc75a85a6e7b2097c5549957a38178a9197
tree2f1cc40eeaa5190f75a5022e9178178e997855a6
parentb6ad62d01b1045ff03c03aa05ee1beeaabc633c7
Fix service registration for SDNC

sliPluginUtils was using a BundleActivator for Service Instantiation, which
is prone to heisenbugs due to indeterminate service instantiation logic.  This
removes the BundleActivator and instantiates services using blueprint.

Since dme2.properties are parsed using Properties instead of using a
ManagedService, the decision was to just keep them immutable.

Future work may involve making instance variables private in DME2, since
currently Dme2Test performs direct member access on DME2 instance variables
which is considered bad practices (violates encapsulation).

Issue-Id: SDNC-54
Change-Id: Ib1155565e04e9a95d222bc4028a0845d9d81bd82
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
sliPluginUtils/provider/pom.xml
sliPluginUtils/provider/src/main/java/org/onap/ccsdk/sli/core/slipluginutils/DME2.java
sliPluginUtils/provider/src/main/java/org/onap/ccsdk/sli/core/slipluginutils/Dme2PropertiesProvider.java [new file with mode: 0644]
sliPluginUtils/provider/src/main/java/org/onap/ccsdk/sli/core/slipluginutils/SliPluginUtils.java
sliPluginUtils/provider/src/main/java/org/onap/ccsdk/sli/core/slipluginutils/SliPluginUtilsActivator.java [deleted file]
sliPluginUtils/provider/src/main/resources/org/opendaylight/blueprint/slipluginutils-blueprint.xml [new file with mode: 0644]
sliPluginUtils/provider/src/test/java/org/onap/ccsdk/sli/core/slipluginutils/Dme2Test.java