Code Review / portal.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: ba546e9) | patch
Sonar: Reduce cyclomatic complexity 79/88779/1
authorDominik Mizyn <d.mizyn@samsung.com>
Wed, 29 May 2019 10:22:27 +0000 (12:22 +0200)
committerDominik Mizyn <d.mizyn@samsung.com>
Wed, 29 May 2019 14:37:08 +0000 (16:37 +0200)
commit788e99d836a75badf45dce96358d184aa9e549f2
treed10fa98f8e0a162c2488f2d32bf67b280ad958d5tree | snapshot
parentba546e970d779a5e87a07b3058a85e1446c39129commit | diff
Sonar: Reduce cyclomatic complexity

Reduce the number of conditional operators for equals(). Improve
testEquals() to better cover this method.

This patch also:

* immediately returns expression instead of assigning it to the
  temporary variable "str",
* adds the "@Override" annotation above equals() method signature.

Issue-ID: PORTAL-595
Change-Id: I15f600acce873eb3f22cc405d06a50890c7e87c3
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/domain/EPUserApp.java diff | blob | history
ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/domain/EPUserAppTest.java diff | blob | history
ARCHIVED- 2022-02-15 at the request of the project