Code Review / policy / common.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: a56d392) | patch
Address sonar issues in ONAP-logging 70/105170/1
authorJim Hahn <jrh3@att.com>
Mon, 6 Apr 2020 16:17:11 +0000 (12:17 -0400)
committerJim Hahn <jrh3@att.com>
Mon, 6 Apr 2020 17:00:04 +0000 (13:00 -0400)
commit9f9131575d2e2b1002a3e108f7793a97fa7652ab
tree68400e6ac1fb32f01f8338803a7d72bdb41215b1tree | snapshot
parenta56d3929f2387252525577fb36f9e03933064b8fcommit | diff
Address sonar issues in ONAP-logging

Addressed the following sonar issues in ONAP-logging:
- use Map instead of ConcurrentHashMap
- remove unusued fields
- use Map.computeIfAbsent() instead of get()/put() pair
- readObject is unsafe
- use try-with-resources
- junit should assert something

Also removed some unused imports.

Issue-ID: POLICY-2305
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I3480a55da4d0e771f8083c97770a6c9707d871f7
Signed-off-by: Jim Hahn <jrh3@att.com>
common-logging/pom.xml diff | blob | history
common-logging/src/main/java/org/onap/policy/common/logging/eelf/EventTrackInfoHandler.java diff | blob | history
common-logging/src/main/java/org/onap/policy/common/logging/eelf/PolicyLogger.java diff | blob | history
common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/DisplayUtils.java diff | blob | history
common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/FlexLogger.java diff | blob | history
common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/Logger4J.java diff | blob | history
common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/PropertyUtil.java diff | blob | history
common-logging/src/test/java/org/onap/policy/common/logging/eelf/PolicyLoggerTest.java diff | blob | history
common-logging/src/test/java/org/onap/policy/common/logging/flexlogger/FlexLoggerTest.java diff | blob | history
common-logging/src/test/java/org/onap/policy/common/logging/flexlogger/Logger4JTest.java diff | blob | history
common-logging/src/test/java/org/onap/policy/common/logging/flexlogger/SystemOutLoggerTest.java diff | blob | history
Policy common shared modules