Code Review / policy / common.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: ea262e6) | patch
More sonar fixes in policy/common 28/89828/8
authorJim Hahn <jrh3@att.com>
Thu, 13 Jun 2019 16:34:17 +0000 (12:34 -0400)
committerJim Hahn <jrh3@att.com>
Thu, 13 Jun 2019 20:10:38 +0000 (16:10 -0400)
commitfe5d78724f723a451ddc0d7cc41d6fc60092b314
tree9913cc94014b3e99774e9ec5e39a7211046a765atree | snapshot
parentea262e6da52fd4da0733f02998f87aebaf502ddbcommit | diff
More sonar fixes in policy/common

Note: this does not increase code coverage, but should fix other
code issues.

Resolved cyclomatic complexity issue in ParameterValidationResult.
Refactored duplicate code in GroupValidationResult.
Removed IOException from NetworkUtil "throws".
Replaced null/empty string tests with StringUtils.isBlank().
Added @FunctionalInterface where needed.
Replaced anonymous classes with lambda expressions.
Replaced duplicate strings with a constant.
Added private constructors for utility classes.
Removed sleep() from tests.
Removed unused parameter from method call.
Made some protected methods private.
Compute integrity monitor's state-transition table once.
Use for-loop instead of iterator.
Moved constructors.
Fixed some checkstyle issues (tabs => spaces, trailing spaces).

Change-Id: I9a962ca45c4ff3f212c6014da799d06f07b232ef
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
22 files changed:
common-logging/src/main/java/org/onap/policy/common/logging/eelf/PolicyLogger.java diff | blob | history
common-parameters/src/main/java/org/onap/policy/common/parameters/CommonGroupValidationResult.java [new file with mode: 0644] blob
common-parameters/src/main/java/org/onap/policy/common/parameters/GroupMapValidationResult.java diff | blob | history
common-parameters/src/main/java/org/onap/policy/common/parameters/GroupValidationResult.java diff | blob | history
common-parameters/src/main/java/org/onap/policy/common/parameters/ParameterValidationResult.java diff | blob | history
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersL00.java diff | blob | history
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersL10.java diff | blob | history
common-parameters/src/test/resources/expectedValidationResults/TestParametersL0_2_Invalid.txt diff | blob | history
common-parameters/src/test/resources/expectedValidationResults/TestParametersL0_2_Observation.txt diff | blob | history
common-parameters/src/test/resources/expectedValidationResults/TestParametersL0_2_Warning.txt diff | blob | history
common-parameters/src/test/resources/expectedValidationResults/TestParametersL0_3_Invalid.txt diff | blob | history
common-parameters/src/test/resources/expectedValidationResults/TestParametersL0_3_Observation.txt diff | blob | history
common-parameters/src/test/resources/expectedValidationResults/TestParametersL0_3_Warning.txt diff | blob | history
integrity-audit/src/main/java/org/onap/policy/common/ia/AuditThread.java diff | blob | history
integrity-audit/src/main/java/org/onap/policy/common/ia/DbAudit.java diff | blob | history
integrity-monitor/src/main/java/org/onap/policy/common/im/StateTransition.java diff | blob | history
integrity-monitor/src/main/java/org/onap/policy/common/im/jmx/JmxAgentConnection.java diff | blob | history
integrity-monitor/src/main/java/org/onap/policy/common/im/jpa/StateManagementEntity.java diff | blob | history
integrity-monitor/src/main/resources/META-INF/persistence.xml diff | blob | history
integrity-monitor/src/test/resources/logback-test.xml diff | blob | history
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/http/server/test/HttpServerTest.java diff | blob | history
utils/src/main/java/org/onap/policy/common/utils/network/NetworkUtil.java diff | blob | history
Policy common shared modules