gerrit.onap Code Review - policy/clamp.git/commit

Code Review / policy / clamp.git / commit

author	danielhanrahan <daniel.hanrahan@est.tech>
	Tue, 17 Feb 2026 15:50:40 +0000 (15:50 +0000)
committer	danielhanrahan <daniel.hanrahan@est.tech>
	Wed, 18 Feb 2026 12:29:01 +0000 (12:29 +0000)
commit	888acd24e8852bdbda0eb7ab0b4992f710a4793a
tree	1a1a2a3622c3b8b1ac11fc5fd1af820f93a24eb7	tree \| snapshot
parent	f0c5cb0492cce96139c3a9b4dd2191743aa5e697	commit \| diff

Fix Pojo tests

There are a few tests using OpenPojo library, but many are broken:
- ToStringTester uses wrong regular expression, and has no tests
- Some tests incorrectly filter the packages, e.g. only including
test files instead of excluding them.

This commit introduces PojoTester with its own tests, and also
adds unit tests of ToStringTester.

Issue-ID: POLICY-5546
Change-Id: I94a8ea723f98e13bc14f4de9e82f1148234144ef
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>

21 files changed:

models/src/main/java/org/onap/policy/clamp/models/acm/messages/kafka/participant/ParticipantMessage.java		diff \| blob \| history
models/src/main/java/org/onap/policy/clamp/models/acm/persistence/concepts/JpaMessage.java		diff \| blob \| history
models/src/main/java/org/onap/policy/clamp/models/acm/persistence/concepts/StringToDocMessageConverter.java	[moved from models/src/main/java/org/onap/policy/clamp/models/acm/persistence/concepts/StringToDocMessage.java with 92% similarity]	diff \| blob \| history
models/src/test/java/org/onap/policy/clamp/models/acm/PojosTest.java	[new file with mode: 0644]	blob
models/src/test/java/org/onap/policy/clamp/models/acm/concepts/AutomationCompositionConceptPojosTest.java	[deleted file]	blob \| history
models/src/test/java/org/onap/policy/clamp/models/acm/messages/kafka/participant/ParticipantMessageTest.java		diff \| blob \| history
models/src/test/java/org/onap/policy/clamp/models/acm/messages/kafka/participant/ParticipantPojosTest.java	[deleted file]	blob \| history
models/src/test/java/org/onap/policy/clamp/models/acm/messages/rest/MessagesRestPojosTest.java	[deleted file]	blob \| history
models/src/test/java/org/onap/policy/clamp/models/acm/persistence/concepts/StringToDocMessageConverterTest.java	[moved from models/src/test/java/org/onap/policy/clamp/models/acm/persistence/concepts/StringToDocMessageTest.java with 93% similarity]	diff \| blob \| history
participant/participant-intermediary/src/test/java/org/onap/policy/clamp/acm/participant/intermediary/handler/ParticipantHandlerTest.java		diff \| blob \| history
policy-common/src/main/java/org/onap/policy/common/utils/test/PojoTester.java	[moved from models/src/test/java/org/onap/policy/clamp/models/acm/persistence/concepts/PojosTest.java with 55% similarity]	diff \| blob \| history
policy-common/src/main/java/org/onap/policy/common/utils/test/ToStringTester.java		diff \| blob \| history
policy-common/src/test/java/org/onap/policy/common/utils/test/PojoTesterTest.java	[new file with mode: 0644]	blob
policy-common/src/test/java/org/onap/policy/common/utils/test/ToStringTesterTest.java	[new file with mode: 0644]	blob
policy-common/src/test/java/org/onap/policy/common/utils/test/pojo/empty/NotAPojo.java	[new file with mode: 0644]	blob
policy-common/src/test/java/org/onap/policy/common/utils/test/pojo/invalid/InvalidPojo.java	[new file with mode: 0644]	blob
policy-common/src/test/java/org/onap/policy/common/utils/test/pojo/valid/ValidPojo.java	[new file with mode: 0644]	blob
policy-models/src/test/java/org/onap/policy/models/PojosTest.java	[new file with mode: 0644]	blob
policy-models/src/test/java/org/onap/policy/models/errors/concepts/TestModels.java	[deleted file]	blob \| history
policy-models/src/test/java/org/onap/policy/models/tosca/authorative/concepts/PojosTest.java	[deleted file]	blob \| history
policy-models/src/test/java/org/onap/policy/models/tosca/authorative/concepts/ToscaIdentifierTestBase.java		diff \| blob \| history

"policy-clamp"

RSS Atom