Code Review / cps.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: b56f69f) | patch
Remove CpsDataService dependency from DeltaReportExecutor 25/141625/7
authorArpit Singh <AS00745003@techmahindra.com>
Mon, 25 Aug 2025 14:26:02 +0000 (19:56 +0530)
committerArpit Singh <AS00745003@techmahindra.com>
Wed, 17 Sep 2025 13:17:46 +0000 (18:47 +0530)
commit206327fc6c91fccf46a2160e61e4e07ea82e6b24
treed996bb750c9128509bafa25b3efd72262639f131tree | snapshot
parentb56f69fa6d4f84fb5ab5f67305c8869a9d50044fcommit | diff
Remove CpsDataService dependency from DeltaReportExecutor

CpsDataService is injected as bean in DeltaReportExecutor, This is
causing a cyclic dependency impacting CPS-2523(in progress).

The cyclic dependency forming is as follows:
CpsDataServiceImpl->CpsDeltaServiceImpl->DeltaReportExecutor->CpsDataService

The solution implemented is for DeltaReportExecutor to directly call
CpsDataPersistenceService

Since the cps delta service does not depend on CpsDataService, the
data validation steps which were present in CpsDataService have been
implemented in CpsDeltaServiceImpl and DeltaReportExecutor.

Issue-ID: CPS-2964
Change-Id: I1eecee22f67139eda111948d8aafad62c17340e2
Signed-off-by: Arpit Singh <AS00745003@techmahindra.com>
cps-service/src/main/java/org/onap/cps/impl/CpsDeltaServiceImpl.java diff | blob | history
cps-service/src/main/java/org/onap/cps/utils/deltareport/DeltaReportExecutor.java diff | blob | history
cps-service/src/test/groovy/org/onap/cps/impl/CpsDeltaServiceImplSpec.groovy diff | blob | history
cps-service/src/test/groovy/org/onap/cps/utils/deltareport/DeltaReportExecutorSpec.groovy diff | blob | history
"cps"