gerrit.onap Code Review - policy/models.git/commit

Code Review / policy / models.git / commit

author	Jim Hahn <jrh3@att.com>
	Tue, 21 Jul 2020 13:55:38 +0000 (09:55 -0400)
committer	Jim Hahn <jrh3@att.com>
	Tue, 21 Jul 2020 20:25:53 +0000 (16:25 -0400)
commit	248a660d61fa03caa4710cf8cfe144eb245b807b
tree	9f7c9aa7fda6d9ab9977bf2398a0136a787dc62a	tree \| snapshot
parent	f203526d0f86d385976da394bd1f0f918e4445d9	commit \| diff

Fix some sonars in policy-models

Fixed the following sonar issues in some of the project directories:
- use assertNull, assertEquals, etc.
- swap assertEquals arguments
- extract a constant
- don't invoke toString() in logger calls
- TODOs
- generic types

Issue-ID: POLICY-2714
Change-Id: Id8803f9bf617ea9fc173a67b8606600709b55bdc
Signed-off-by: Jim Hahn <jrh3@att.com>

74 files changed:

models-interactions/model-actors/actor.aai/src/test/java/org/onap/policy/controlloop/actor/aai/AaiCustomQueryOperationTest.java		diff \| blob \| history
models-interactions/model-actors/actor.aai/src/test/java/org/onap/policy/controlloop/actor/aai/AaiGetOperationTest.java		diff \| blob \| history
models-interactions/model-actors/actor.aai/src/test/java/org/onap/policy/controlloop/actor/aai/AaiGetPnfOperationTest.java		diff \| blob \| history
models-interactions/model-actors/actor.aai/src/test/java/org/onap/policy/controlloop/actor/aai/AaiGetTenantOperationTest.java		diff \| blob \| history
models-interactions/model-actors/actor.aai/src/test/java/org/onap/policy/controlloop/actor/aai/AaiUtilTest.java		diff \| blob \| history
models-interactions/model-actors/actor.aai/src/test/java/org/onap/policy/controlloop/actor/aai/BasicAaiOperation.java		diff \| blob \| history
models-interactions/model-actors/actor.appc/src/test/java/org/onap/policy/controlloop/actor/appc/BasicAppcOperation.java		diff \| blob \| history
models-interactions/model-actors/actor.appclcm/src/test/java/org/onap/policy/controlloop/actor/appclcm/AppcLcmOperationTest.java		diff \| blob \| history
models-interactions/model-actors/actor.guard/src/test/java/org/onap/policy/controlloop/actor/guard/DecisionOperationTest.java		diff \| blob \| history
models-interactions/model-actors/actor.sdnc/src/test/java/org/onap/policy/controlloop/actor/sdnc/BasicSdncOperation.java		diff \| blob \| history
models-interactions/model-actors/actor.sdnr/src/test/java/org/onap/policy/controlloop/actor/sdnr/BasicSdnrOperation.java		diff \| blob \| history
models-interactions/model-actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/VfModuleDelete.java		diff \| blob \| history
models-interactions/model-actors/actor.so/src/test/java/org/onap/policy/controlloop/actor/so/BasicSoOperation.java		diff \| blob \| history
models-interactions/model-actors/actor.test/src/main/java/org/onap/policy/controlloop/actor/test/BasicBidirectionalTopicOperation.java		diff \| blob \| history
models-interactions/model-actors/actor.test/src/main/java/org/onap/policy/controlloop/actor/test/BasicHttpOperation.java		diff \| blob \| history
models-interactions/model-actors/actor.test/src/test/java/org/onap/policy/controlloop/actor/test/BasicBidirectionalTopicOperationTest.java		diff \| blob \| history
models-interactions/model-actors/actor.test/src/test/java/org/onap/policy/controlloop/actor/test/BasicHttpOperationTest.java		diff \| blob \| history
models-interactions/model-actors/actor.test/src/test/java/org/onap/policy/controlloop/actor/test/BasicOperationTest.java		diff \| blob \| history
models-interactions/model-actors/actor.vfc/src/test/java/org/onap/policy/controlloop/actor/vfc/BasicVfcOperation.java		diff \| blob \| history
models-interactions/model-actors/actorServiceProvider/src/main/java/org/onap/policy/controlloop/actorserviceprovider/parameters/HttpPollingActorParams.java		diff \| blob \| history
models-interactions/model-actors/actorServiceProvider/src/main/java/org/onap/policy/controlloop/actorserviceprovider/parameters/HttpPollingParams.java		diff \| blob \| history
models-interactions/model-actors/actorServiceProvider/src/main/java/org/onap/policy/controlloop/actorserviceprovider/pipeline/ListenerManager.java		diff \| blob \| history
models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/impl/BidirectionalTopicActorTest.java		diff \| blob \| history
models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/impl/BidirectionalTopicOperatorTest.java		diff \| blob \| history
models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/impl/HttpActorTest.java		diff \| blob \| history
models-interactions/model-impl/aai/src/main/java/org/onap/policy/aai/util/AaiException.java	[deleted file]	blob \| history
models-interactions/model-impl/aai/src/main/java/org/onap/policy/aai/util/Serialization.java		diff \| blob \| history
models-interactions/model-impl/aai/src/test/java/org/onap/policy/aai/util/AaiExceptionTest.java	[deleted file]	blob \| history
models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/CommonHeaderTest.java		diff \| blob \| history
models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/RequestTest.java		diff \| blob \| history
models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/ResponseStatusTest.java		diff \| blob \| history
models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/ResponseTest.java		diff \| blob \| history
models-interactions/model-impl/cds/src/main/java/org/onap/policy/cds/client/CdsProcessorHandler.java		diff \| blob \| history
models-interactions/model-impl/events/src/test/java/org/onap/policy/controlloop/ControlLoopOperationTest.java		diff \| blob \| history
models-interactions/model-impl/guard/src/test/java/org/onap/policy/guard/OperationsHistoryTest.java		diff \| blob \| history
models-interactions/model-impl/rest/src/test/java/org/onap/policy/rest/RestTest.java		diff \| blob \| history
models-interactions/model-impl/sdc/src/test/java/org/onap/policy/sdc/ResourceInstanceTest.java		diff \| blob \| history
models-interactions/model-impl/sdc/src/test/java/org/onap/policy/sdc/ResourceTest.java		diff \| blob \| history
models-interactions/model-impl/sdc/src/test/java/org/onap/policy/sdc/ServiceInstanceTest.java		diff \| blob \| history
models-interactions/model-impl/sdc/src/test/java/org/onap/policy/sdc/ServiceTest.java		diff \| blob \| history
models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciCommonHeaderTest.java		diff \| blob \| history
models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciRequestTest.java		diff \| blob \| history
models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciRequestWrapperTest.java		diff \| blob \| history
models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciResponseTest.java		diff \| blob \| history
models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciResponseWrapperTest.java		diff \| blob \| history
models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciStatusTest.java		diff \| blob \| history
models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciWrapperTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoAsyncRequestStatusTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoCloudConfigurationTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoInstanceReferencesTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoModelInfoTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoPolicyExceptionHolderTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoRelatedInstanceListElementTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoRelatedInstanceTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoRequestDetailsTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoRequestErrorTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoRequestParametersTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoRequestReferencesTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoRequestStatusTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoRequestTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoResponseTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoResponseWrapperTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoServiceExceptionHolderTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoSubscriberInfoTest.java		diff \| blob \| history
models-interactions/model-simulators/src/test/java/org/onap/policy/simulators/AaiSimulatorTest.java		diff \| blob \| history
models-interactions/model-simulators/src/test/java/org/onap/policy/simulators/VfcSimulatorTest.java		diff \| blob \| history
models-pdp/src/test/java/org/onap/policy/models/pdp/concepts/DeploymentGroupTest.java		diff \| blob \| history
models-pdp/src/test/java/org/onap/policy/models/pdp/concepts/PdpGroupTest.java		diff \| blob \| history
models-pdp/src/test/java/org/onap/policy/models/pdp/concepts/PdpUpdateTest.java		diff \| blob \| history
models-pdp/src/test/java/org/onap/policy/models/pdp/persistence/concepts/JpaPdpGroupTest.java		diff \| blob \| history
models-pdp/src/test/java/org/onap/policy/models/pdp/persistence/concepts/JpaPdpSubGroupTest.java		diff \| blob \| history
models-pdp/src/test/java/org/onap/policy/models/pdp/persistence/concepts/JpaPdpTest.java		diff \| blob \| history
models-sim/models-sim-dmaap/src/test/java/org/onap/policy/sim/dmaap/startstop/MainTest.java		diff \| blob \| history
models-sim/policy-models-sim-pdp/src/test/java/org/onap/policy/models/sim/pdp/TestPdpSimulatorMain.java		diff \| blob \| history

This repo will hold model code agnostic to PDP engines (Casablanca)

RSS Atom