new sonar issues in drools-applications 23/68423/3
authorJim Hahn <jrh3@att.com>
Fri, 21 Sep 2018 13:31:25 +0000 (09:31 -0400)
committerJim Hahn <jrh3@att.com>
Fri, 21 Sep 2018 14:12:52 +0000 (10:12 -0400)
commitd85e766c5538de762820132ac723d928f5a9bf89
tree738c4de12a3a261035bbb25199558a490d550d3e
parentfaf283066f186838665ed5c38c1ba8319041bc1c
new sonar issues in drools-applications

Don't return null lists from AAI.
Transient TargetLock.
Extract aai.url, et. al., constants.
Don't allocate extra unneeded variable.
Re-order fields in xacml attributes.
Extract "vserver" constant from simulator.
Replace thread sleep with join.

Change-Id: Iee1bd182862632af1f131cca5db5b526f5865b9f
Issue-ID: POLICY-1129
Signed-off-by: Jim Hahn <jrh3@att.com>
controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java
controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopEventManager.java
controlloop/common/guard/src/main/java/org/onap/policy/guard/PolicyGuardXacmlRequestAttributes.java
controlloop/common/model-impl/aai/src/main/java/org/onap/policy/aai/AaiNqResponseWrapper.java
controlloop/common/model-impl/aai/src/test/java/org/onap/policy/aai/AaiNqResponseWrapperTest.java
controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVfcManager.java
controlloop/common/simulators/src/main/java/org/onap/policy/simulators/AaiSimulatorJaxRs.java