gerrit.onap Code Review - policy/models.git/commit

Code Review / policy / models.git / commit

author	Jim Hahn <jrh3@att.com>
	Wed, 10 Feb 2021 21:17:10 +0000 (16:17 -0500)
committer	Jim Hahn <jrh3@att.com>
	Wed, 10 Feb 2021 22:17:34 +0000 (17:17 -0500)
commit	b7097d21c25a48c9d209548ac8afdc09b1679457
tree	ee7a911622c333818a9ac30f2cae68aee7eb6601	tree \| snapshot
parent	f04d89c55ab4dfa94dfed1cc9b65471d1d3140c5	commit \| diff

More sonars in models

Addressed the following:
- make constructors protected
- check exception type
- too many assertions
- remove annotation lists
- use "<>"
- reduce cognitive complexity
- extract constant
- multiple method calls in one assert
- don't use eq() in verify()
- indentation

Issue-ID: POLICY-2905
Change-Id: I25bb3951f781250e9cdfe8f5f3b80cb63e129184
Signed-off-by: Jim Hahn <jrh3@att.com>

38 files changed:

models-base/src/main/java/org/onap/policy/models/base/PfConcept.java		diff \| blob \| history
models-base/src/main/java/org/onap/policy/models/base/PfConceptContainer.java		diff \| blob \| history
models-base/src/main/java/org/onap/policy/models/base/PfKey.java		diff \| blob \| history
models-base/src/main/java/org/onap/policy/models/base/PfKeyImpl.java		diff \| blob \| history
models-base/src/main/java/org/onap/policy/models/base/PfModel.java		diff \| blob \| history
models-base/src/test/java/org/onap/policy/models/base/ValidatedTest.java		diff \| blob \| history
models-interactions/model-actors/actor.appc/src/main/java/org/onap/policy/controlloop/actor/appc/AppcOperation.java		diff \| blob \| history
models-interactions/model-actors/actor.sdnc/src/main/java/org/onap/policy/controlloop/actor/sdnc/SdncOperation.java		diff \| blob \| history
models-interactions/model-actors/actor.test/src/main/java/org/onap/policy/controlloop/actor/test/BasicBidirectionalTopicOperation.java		diff \| blob \| history
models-interactions/model-actors/actor.test/src/test/java/org/onap/policy/controlloop/actor/test/BasicActorTest.java		diff \| blob \| history
models-interactions/model-actors/actor.vfc/src/main/java/org/onap/policy/controlloop/actor/vfc/VfcOperation.java		diff \| blob \| history
models-interactions/model-actors/actorServiceProvider/src/main/java/org/onap/policy/controlloop/actorserviceprovider/impl/BidirectionalTopicOperation.java		diff \| blob \| history
models-interactions/model-actors/actorServiceProvider/src/main/java/org/onap/policy/controlloop/actorserviceprovider/impl/HttpOperation.java		diff \| blob \| history
models-interactions/model-actors/actorServiceProvider/src/main/java/org/onap/policy/controlloop/actorserviceprovider/impl/OperationPartial.java		diff \| blob \| history
models-interactions/model-actors/actorServiceProvider/src/main/java/org/onap/policy/controlloop/actorserviceprovider/impl/OperatorPartial.java		diff \| blob \| history
models-interactions/model-actors/actorServiceProvider/src/main/java/org/onap/policy/controlloop/actorserviceprovider/impl/StartConfigPartial.java		diff \| blob \| history
models-interactions/model-actors/actorServiceProvider/src/main/java/org/onap/policy/controlloop/actorserviceprovider/impl/TypedOperator.java		diff \| blob \| history
models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/OperationOutcomeTest.java		diff \| blob \| history
models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/impl/BidirectionalTopicOperationTest.java		diff \| blob \| history
models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/topic/BidirectionalTopicHandlerTest.java		diff \| blob \| history
models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/CommonHeaderTest.java		diff \| blob \| history
models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/RequestTest.java		diff \| blob \| history
models-interactions/model-impl/events/src/main/java/org/onap/policy/controlloop/ControlLoopEvent.java		diff \| blob \| history
models-interactions/model-impl/events/src/main/java/org/onap/policy/controlloop/ControlLoopNotification.java		diff \| blob \| history
models-interactions/model-impl/rest/src/test/java/org/onap/policy/rest/RestTest.java		diff \| blob \| history
models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciCommonHeaderTest.java		diff \| blob \| history
models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciWrapperTest.java		diff \| blob \| history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoRequestDetailsTest.java		diff \| blob \| history
models-provider/src/test/java/org/onap/policy/models/provider/impl/DatabasePolicyModelsProviderTest.java		diff \| blob \| history
models-tosca/src/main/java/org/onap/policy/models/tosca/authorative/concepts/ToscaEntityFilter.java		diff \| blob \| history
models-tosca/src/main/java/org/onap/policy/models/tosca/authorative/concepts/ToscaTypedEntityFilter.java		diff \| blob \| history
models-tosca/src/main/java/org/onap/policy/models/tosca/simple/concepts/JpaToscaConstraint.java		diff \| blob \| history
models-tosca/src/main/java/org/onap/policy/models/tosca/simple/concepts/JpaToscaEntityType.java		diff \| blob \| history
models-tosca/src/main/java/org/onap/policy/models/tosca/simple/concepts/JpaToscaNodeTemplate.java		diff \| blob \| history
models-tosca/src/main/java/org/onap/policy/models/tosca/simple/concepts/JpaToscaNodeType.java		diff \| blob \| history
models-tosca/src/main/java/org/onap/policy/models/tosca/simple/concepts/JpaToscaPolicy.java		diff \| blob \| history
models-tosca/src/main/java/org/onap/policy/models/tosca/simple/concepts/JpaToscaServiceTemplate.java		diff \| blob \| history
models-tosca/src/main/java/org/onap/policy/models/tosca/simple/concepts/JpaToscaTopologyTemplate.java		diff \| blob \| history

This repo will hold model code agnostic to PDP engines (Casablanca)

RSS Atom