Address sonar issues in common 10/105110/3
authorJim Hahn <jrh3@att.com>
Fri, 3 Apr 2020 13:44:26 +0000 (09:44 -0400)
committerJim Hahn <jrh3@att.com>
Mon, 6 Apr 2020 13:41:59 +0000 (09:41 -0400)
commita56d3929f2387252525577fb36f9e03933064b8f
tree4b671549b5f1c0513c31d77baa19821e422f41e7
parent7da3ddfa40de2f683a2d423d62b78a8d001108eb
Address sonar issues in common

Addressed the following sonar issues:
- missing assertion in junit test case
- disable sonars about setAccessible() as it's required for jackson
  emulation
- sleep in junit
- don't use wild-cards (e.g., "*") with java.util Pattern
  - use re2j instead of java.util Pattern
  - use String methods (e.g., startsWith())
- duplicate method bodies
- duplicate code in Coder classes
- string concatenation in logger calls
- UTF-8 encoding
- return primitive instead of boxed primitive
- add assertion to tests
  - renamed support methods from doTestXxx to verifyXxx
- cognitive complexity
- use AtomicRef instead of volatile
- use specific Functionals (e.g., IntConsumer)
- function always returns the same value
- serializable vs transient

Issue-ID: POLICY-2305
Change-Id: I08eb7aa495a80bdc1d26827ba17a7946c83b9828
Signed-off-by: Jim Hahn <jrh3@att.com>
48 files changed:
gson/src/main/java/org/onap/policy/common/gson/internal/Adapter.java
gson/src/main/java/org/onap/policy/common/gson/internal/FieldDeserializer.java
gson/src/main/java/org/onap/policy/common/gson/internal/FieldSerializer.java
gson/src/test/java/org/onap/policy/common/gson/MapDoubleAdapterFactoryTest.java
integrity-audit/src/main/java/org/onap/policy/common/ia/DbAudit.java
integrity-audit/src/test/java/org/onap/policy/common/ia/DefaultLoggingPatternTest.java
integrity-monitor/src/main/java/org/onap/policy/common/im/IntegrityMonitor.java
integrity-monitor/src/main/resources/logback.xml
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/TopicEndpointProxy.java
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/NoopTopicEndpoint.java
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineBusTopicSink.java
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/SingleThreadedBusTopicSource.java
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/http/server/RestServer.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusConsumerTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusPublisherTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicBaseTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineBusTopicSinkTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineDmaapTopicSinkTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineUebTopicSinkTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/SingleThreadedBusTopicSourceTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/SingleThreadedDmaapTopicSourceTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/SingleThreadedUebTopicSourceTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/TopicBaseTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/http/server/test/HttpServerTest.java
pom.xml
utils-test/pom.xml
utils-test/src/main/java/org/onap/policy/common/utils/gson/GsonTestUtils.java
utils-test/src/main/java/org/onap/policy/common/utils/test/ThrowablesTester.java
utils-test/src/main/java/org/onap/policy/common/utils/time/PseudoScheduledExecutorService.java
utils-test/src/main/java/org/onap/policy/common/utils/time/TestTimeMulti.java
utils-test/src/test/java/org/onap/policy/common/utils/test/log/logback/ExtractAppenderTest.java
utils/pom.xml
utils/src/main/java/org/onap/policy/common/utils/coder/StandardCoder.java
utils/src/main/java/org/onap/policy/common/utils/coder/StandardCoderInstantAsMillis.java
utils/src/main/java/org/onap/policy/common/utils/coder/StandardCoderObject.java
utils/src/main/java/org/onap/policy/common/utils/coder/StandardValCoder.java
utils/src/main/java/org/onap/policy/common/utils/coder/StandardYamlCoder.java
utils/src/main/java/org/onap/policy/common/utils/resources/ResourceUtils.java
utils/src/main/java/org/onap/policy/common/utils/resources/TextFileUtils.java
utils/src/main/java/org/onap/policy/common/utils/security/CryptoUtils.java
utils/src/main/java/org/onap/policy/common/utils/services/ServiceManager.java
utils/src/main/java/org/onap/policy/common/utils/validation/Version.java
utils/src/test/java/org/onap/policy/common/utils/properties/exception/PropertyAccessExceptionTest.java
utils/src/test/java/org/onap/policy/common/utils/properties/exception/PropertyAnnotationExceptionTest.java
utils/src/test/java/org/onap/policy/common/utils/properties/exception/PropertyExceptionTest.java
utils/src/test/java/org/onap/policy/common/utils/properties/exception/PropertyInvalidExceptionTest.java
utils/src/test/java/org/onap/policy/common/utils/properties/exception/PropertyMissingExceptionTest.java
utils/src/test/java/org/onap/policy/common/utils/properties/exception/SupportBasicPropertyExceptionTester.java