Fix sonar issue in vid-app-common 13/86113/2
authorParshad Patel <pars.patel@samsung.com>
Wed, 24 Apr 2019 05:19:43 +0000 (14:19 +0900)
committerParshad Patel <pars.patel@samsung.com>
Wed, 24 Apr 2019 07:51:22 +0000 (16:51 +0900)
commitfa628a20ef151d4b89302dd767f28415c774caf8
tree0fdf8444b9a12ecfe78bd91d64e0eb4bfe9bc823
parent22b961325bf83be59607b65b8e0117604834687b
Fix sonar issue in vid-app-common

Fix Either log or rethrow this exception
Fix "serviceInstanceId" is already a string, there's no need to call "toString()" on it
Fix Replace this if-then-else statement by a single return statement

Issue-ID: VID-464
Change-Id: I87652f6aeecf668757f668535377f2ff9a95a7cf
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
vid-app-common/src/main/java/org/onap/vid/services/ChangeManagementServiceImpl.java
vid-app-common/src/main/java/org/onap/vid/services/CloudOwnerServiceImpl.java
vid-app-common/src/main/java/org/onap/vid/services/RoleGenaratorServiceImpl.java