Apply simple sonar fixes 67/89767/2
authorJim Hahn <jrh3@att.com>
Wed, 12 Jun 2019 18:32:25 +0000 (14:32 -0400)
committerJim Hahn <jrh3@att.com>
Wed, 12 Jun 2019 21:36:59 +0000 (17:36 -0400)
commitea262e6da52fd4da0733f02998f87aebaf502ddb
treea7cded567521f0141f31d9f8c185eccdaf2a8979
parente671e9fa5d09ec696cb24aeefaf10ddbc7c705d7
Apply simple sonar fixes

Note: A number of these were identified, by SonarLint, in the Test
classes, which are not typically scanned by Sonar.

Removed unnecessary imports.
Removed unneeded "throws Xxx".
Replaced lambda with method references.
Replaced duplicate strings with constants.
Replaced try-fail-catch with assert-j methods to eliminate sonar
complaints about duplicate failure messages.
Added missing @Override annotations.
Use map.computeIfAbsent() where appropriate.
Also fixed some minor checkstyle issues.
Removed unneeded "volatile" declarations.
Replaced some if-else constructs with "?:" construct, per sonar.
Replaced Object.wait() with CountDownLatch.await(); according to sonar
(and javadocs), Object.wait() can return due to "spurious wakeups".
Fixed issue whereby CryptoUtilsTest wouldn't run in my Eclipse.

Change-Id: Ib6b71ed65662cfd6209400dac57ed69279bf29ec
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
59 files changed:
common-parameters/pom.xml
common-parameters/src/test/java/org/onap/policy/common/parameters/ExceptionTest.java
common-parameters/src/test/java/org/onap/policy/common/parameters/TestBeanValidationResult.java
common-parameters/src/test/java/org/onap/policy/common/parameters/TestJsonInput.java
common-parameters/src/test/java/org/onap/policy/common/parameters/TestParameterService.java
common-parameters/src/test/java/org/onap/policy/common/parameters/TestValidation.java
common-parameters/src/test/java/org/onap/policy/common/parameters/TestValidationErrors.java
common-parameters/src/test/java/org/onap/policy/common/parameters/TestValidationResults.java
common-parameters/src/test/java/org/onap/policy/common/parameters/TestYamlInput.java
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersL00.java
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersL10.java
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersLGeneric.java
gson/src/main/java/org/onap/policy/common/gson/internal/Adapter.java
gson/src/test/java/org/onap/policy/common/gson/JacksonExclusionStrategyTest.java
gson/src/test/java/org/onap/policy/common/gson/JacksonFieldAdapterFactoryTest.java
gson/src/test/java/org/onap/policy/common/gson/JacksonMethodAdapterFactoryTest.java
gson/src/test/java/org/onap/policy/common/gson/internal/AdapterTest.java
gson/src/test/java/org/onap/policy/common/gson/internal/AnyGetterSerializerTest.java
gson/src/test/java/org/onap/policy/common/gson/internal/AnySetterDeserializerTest.java
gson/src/test/java/org/onap/policy/common/gson/internal/ClassWalkerTest.java
gson/src/test/java/org/onap/policy/common/gson/internal/FieldDeserializerTest.java
gson/src/test/java/org/onap/policy/common/gson/internal/FieldSerializerTest.java
gson/src/test/java/org/onap/policy/common/gson/internal/JacksonTypeAdapterTest.java
gson/src/test/java/org/onap/policy/common/gson/internal/LifterTest.java
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/NoopTopicEndpoint.java
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/NoopTopicSink.java
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/NoopTopicSource.java
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusConsumer.java
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusPublisher.java
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/http/server/internal/JettyJerseyServer.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/BusTopicFactoryTestBase.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/DmaapTopicSinkFactoryTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/DmaapTopicSourceFactoryTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusConsumerTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusPublisherTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicBaseTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicParamsTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineBusTopicSinkTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineDmaapTopicSinkTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineUebTopicSinkTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/http/server/test/HttpClientTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/http/server/test/HttpServerTest.java
utils-test/src/main/java/org/onap/policy/common/utils/gson/GsonTestUtils.java
utils-test/src/test/java/org/onap/policy/common/utils/gson/GsonTestUtilsBuilderTest.java
utils-test/src/test/java/org/onap/policy/common/utils/io/SerializerTest.java
utils-test/src/test/java/org/onap/policy/common/utils/test/ConstructionErrorTest.java
utils-test/src/test/java/org/onap/policy/common/utils/test/ThrowablesTesterTest.java
utils-test/src/test/java/org/onap/policy/common/utils/test/log/logback/ExtractAppenderTest.java
utils/src/main/java/org/onap/policy/common/utils/security/CryptoUtils.java
utils/src/main/java/org/onap/policy/common/utils/services/Registry.java
utils/src/main/java/org/onap/policy/common/utils/validation/ParameterValidationUtils.java
utils/src/test/java/org/onap/policy/common/utils/jpa/EntityMgrCloserTest.java
utils/src/test/java/org/onap/policy/common/utils/jpa/EntityMgrFactoryCloserTest.java
utils/src/test/java/org/onap/policy/common/utils/jpa/EntityTransCloserTest.java
utils/src/test/java/org/onap/policy/common/utils/properties/BeanConfiguratorTest.java
utils/src/test/java/org/onap/policy/common/utils/resources/ResourceUtilsTest.java
utils/src/test/java/org/onap/policy/common/utils/security/CryptoUtilsTest.java
utils/src/test/java/org/onap/policy/common/utils/services/ServiceManagerTest.java
utils/src/test/java/org/onap/policy/common/utils/validation/AssertionsTest.java