Fix sonar issue with double compare 43/86543/2 1.4.0 4.0.0-ONAP
authorJim Hahn <jrh3@att.com>
Mon, 29 Apr 2019 15:43:05 +0000 (11:43 -0400)
committerJim Hahn <jrh3@att.com>
Mon, 29 Apr 2019 16:24:15 +0000 (12:24 -0400)
commit119fc53d7272184333b0a90fc911b988bc25d5a1
tree9ad07e0f17eb87c0bd74b7d83c34cbb26b45a582
parent5c0b134f3054415a10516732efff1f958e649c43
Fix sonar issue with double compare

The gson code to convert Double to Long/Integer use a direct comparison
of the original double with a long.  However, sonar does not like that
so changed the code to use the Double.compare() method instead.
Also fixed sonar issue with diamond operator.
Addressed some sonar issues in ServiceManager.
Addressed some sonar issues in Version.

Change-Id: I0959603918d251db671e87e12c295c6ec911f427
Issue-ID: POLICY-1707
Signed-off-by: Jim Hahn <jrh3@att.com>
gson/src/main/java/org/onap/policy/common/gson/MapDoubleAdapterFactory.java
utils/src/main/java/org/onap/policy/common/utils/services/ServiceManager.java
utils/src/main/java/org/onap/policy/common/utils/validation/Version.java