Sonar fix in MSOCommonBPMN 81/93381/4
authorParshad Patel <pars.patel@samsung.com>
Tue, 13 Aug 2019 04:38:06 +0000 (13:38 +0900)
committerLukasz Muszkieta <lukasz.muszkieta@nokia.com>
Fri, 16 Aug 2019 09:27:14 +0000 (09:27 +0000)
commitdfbc8abd0f1c151e34d07defbe0a5ff363fcf1f0
treea0e533fc3596ae82ed169f7dd752163210ff8ee8
parente536a1035d0f224de32f76a1226c772b8f8d7c01
Sonar fix in MSOCommonBPMN

Either log or rethrow this exception
Remove this useless assignment to local variable "serviceInstance"
Remove the declaration of thrown exception  which is a runtime exception
Move the string literal on the left side of this string comparison

Issue-ID: SO-1841
Change-Id: I24cdd3682eddd2e5ceb7e961477a61457ef91ab2
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
bpmn/MSOCommonBPMN/src/main/java/org/onap/so/bpmn/servicedecomposition/tasks/ExecuteBuildingBlockRainyDay.java
bpmn/MSOCommonBPMN/src/main/java/org/onap/so/bpmn/servicedecomposition/tasks/ExtractPojosForBB.java