Code Review / policy / drools-applications.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 72d5a23) | patch
Yet more sonar issues in drools-applications 23/68523/7
authorJoshua Reich <jreich@research.att.com>
Fri, 21 Sep 2018 23:44:25 +0000 (16:44 -0700)
committerJoshua Reich <jreich@research.att.com>
Thu, 27 Sep 2018 19:53:38 +0000 (12:53 -0700)
commitdaa096b8149e18e69e1344e01cf4627d7e0dede5
treec8dd5ea368d5ef615bb5e3780fcf751de4371c99tree | snapshot
parent72d5a239ff15617b2d218d3b8f3f8a2099007142commit | diff
Yet more sonar issues in drools-applications

removed unused imports and variable definitions
moved variable declarations above methods
refactored deeply nested if/while
removed code smell due to unecessary use of static keyword
moved string literals to left side of comparator
fixed logging of exceptions
immediately return expression instead of assigning it to the temporary variable

Change-Id: Idfd2a2bdf3c2f3bbfcb54a06b713d57bc867b3ab
Issue-ID: POLICY-1129
Signed-off-by: Joshua Reich <jreich@research.att.com>
controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopEventManager.java diff | blob | history
controlloop/common/guard/src/main/java/org/onap/policy/guard/PipEngineGetStatus.java diff | blob | history
controlloop/templates/template.demo.clc/src/main/java/org/onap/policy/guard/CallGuardTaskEmbedded.java diff | blob | history
controlloop/templates/template.demo.clc/src/main/java/org/onap/policy/guard/PolicyGuardXacmlHelperEmbedded.java diff | blob | history
Code for building policies/rules for the Drools PDP engine.