Fix sonar issues in integrity monitor 34/90334/4
authorJim Hahn <jrh3@att.com>
Fri, 21 Jun 2019 17:19:31 +0000 (13:19 -0400)
committerJim Hahn <jrh3@att.com>
Fri, 21 Jun 2019 21:19:09 +0000 (17:19 -0400)
commitd6aa3faba917b45e01f5001fe3a768feddedc798
tree077a51a89320f558f08b2d0512f6cf63450ae90d
parentc9392e1a126de54ae8a0e1f3316729e878115300
Fix sonar issues in integrity monitor

Used Eclipse Refactor->Extract Method to reduce cyclomatic
complexity.
Flattened nested FpManager class into IntegrityMonitor class.
Changed some strings to StringBuilder, where lots of concatenation
was being done.
Simplified some things by eliminating some try/catch blocks where
an exception can't actually (except may an out-of-memory exception).
Also addressed some sonar issues in the tests (e.g., use "<>" where
appropriate).
Eliminated some assertException methods, replacing them with assertj
methods.
Did not attempt to increase junit coverage.

Change-Id: I311acaffcd87f0cbbf382c06c7fa26177007abd5
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
12 files changed:
integrity-monitor/pom.xml
integrity-monitor/src/main/java/org/onap/policy/common/im/IntegrityMonitor.java
integrity-monitor/src/main/java/org/onap/policy/common/im/StateManagement.java
integrity-monitor/src/main/java/org/onap/policy/common/im/StateTransition.java
integrity-monitor/src/test/java/org/onap/policy/common/im/AllSeemsWellTest.java
integrity-monitor/src/test/java/org/onap/policy/common/im/ExceptionsTest.java
integrity-monitor/src/test/java/org/onap/policy/common/im/IntegrityMonitorTest.java
integrity-monitor/src/test/java/org/onap/policy/common/im/IntegrityMonitorTestBase.java
integrity-monitor/src/test/java/org/onap/policy/common/im/StateManagementEntityTest.java
integrity-monitor/src/test/java/org/onap/policy/common/im/StateManagementTest.java
integrity-monitor/src/test/java/org/onap/policy/common/im/StateTransitionTest.java
integrity-monitor/src/test/java/org/onap/policy/common/im/exceptions/EntityRetrievalExceptionTest.java