Code Review / so.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: b7f55f4) | patch
fix sonar critical bug 71/78571/1
authork.kazak <k.kazak@samsung.com>
Fri, 15 Feb 2019 16:27:08 +0000 (17:27 +0100)
committerk.kazak <k.kazak@samsung.com>
Fri, 15 Feb 2019 16:27:08 +0000 (17:27 +0100)
commitc9a28a8316cf3a19fcaa2f78cf92798a99139781
tree8bcc15b809538cae7244a551e0cfa55c64906af6tree | snapshot
parentb7f55f47a964351e7dc46d05af7f53f7da1c9ebacommit | diff
fix sonar critical bug

MsoHeatUtils: remove unnecessary heatClient check for null
1. sonar assumes that heatClient is nullable and NullPointer may be thrown in line 309
2. heatClient is never null: method creates a new object or throws Exception
MsoHeatUtilsTest: added tests for getHeatClient and createStack methods
BaseTest: made CloudIdentity and CloudSite getters protected for other tests to use them
StubOpenStack: added stubs for getStack and unsuccessful authorization
removed unused imports

Change-Id: Ie62c89f55d1894df48d9cc4d14760d36e96c4cb2
Issue-ID: SO-1516
Signed-off-by: k.kazak <k.kazak@samsung.com>
adapters/mso-adapter-utils/src/main/java/org/onap/so/openstack/utils/MsoHeatUtils.java diff | blob | history
adapters/mso-adapter-utils/src/test/java/org/onap/so/BaseTest.java diff | blob | history
adapters/mso-adapter-utils/src/test/java/org/onap/so/StubOpenStack.java diff | blob | history
adapters/mso-adapter-utils/src/test/java/org/onap/so/openstack/utils/MsoHeatUtilsTest.java diff | blob | history
Service Orchestrator