Code Review / policy / common.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 62463da) | patch
Fix sonar issues in integrity audit 06/90306/5
authorJim Hahn <jrh3@att.com>
Wed, 19 Jun 2019 21:31:24 +0000 (17:31 -0400)
committerJim Hahn <jrh3@att.com>
Fri, 21 Jun 2019 15:36:18 +0000 (11:36 -0400)
commitc9392e1a126de54ae8a0e1f3316729e878115300
tree5a371d53f5e6cf8bedbb4daf94f558844037fd7dtree | snapshot
parent62463da9961f7e524559b34766baf2dd469fa910commit | diff
Fix sonar issues in integrity audit

Mostly used Eclipse Refactor->Extract Method to reduce cyclomatic
complexity.  Also combined a few "if" statements to reduce nesting
levels.
Also addressed some sonar issues in the tests (e.g., use "<>" where
appropriate).
Did not attempt to increase junit coverage.

Change-Id: I9d6c1305ce455f0d64249b548d123bb9bf37292a
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
14 files changed:
integrity-audit/pom.xml diff | blob | history
integrity-audit/src/main/java/org/onap/policy/common/ia/AuditThread.java diff | blob | history
integrity-audit/src/main/java/org/onap/policy/common/ia/DbAudit.java diff | blob | history
integrity-audit/src/main/java/org/onap/policy/common/ia/DbDao.java diff | blob | history
integrity-audit/src/main/java/org/onap/policy/common/ia/IntegrityAudit.java diff | blob | history
integrity-audit/src/main/java/org/onap/policy/common/ia/IntegrityAuditProperties.java diff | blob | history
integrity-audit/src/test/java/org/onap/policy/common/ia/AuditPeriodTest.java diff | blob | history
integrity-audit/src/test/java/org/onap/policy/common/ia/DbAuditCompareEntriesTest.java diff | blob | history
integrity-audit/src/test/java/org/onap/policy/common/ia/DbAuditTest.java diff | blob | history
integrity-audit/src/test/java/org/onap/policy/common/ia/DbDaoTest.java diff | blob | history
integrity-audit/src/test/java/org/onap/policy/common/ia/ExceptionsTest.java diff | blob | history
integrity-audit/src/test/java/org/onap/policy/common/ia/IntegrityAuditTest.java diff | blob | history
integrity-audit/src/test/java/org/onap/policy/common/ia/IntegrityAuditTestBase.java diff | blob | history
integrity-audit/src/test/java/org/onap/policy/common/ia/jpa/IaTestEntity.java diff | blob | history
Policy common shared modules