Code Review / so.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: a716045) | patch
Fix sonar for MapEntry 45/88545/1
authork.kazak <k.kazak@samsung.com>
Mon, 27 May 2019 13:00:15 +0000 (15:00 +0200)
committerk.kazak <k.kazak@samsung.com>
Mon, 27 May 2019 13:00:15 +0000 (15:00 +0200)
commitc1cd5ef428017bc26513395a3bfc00caf7209f8a
tree6001426422534e0d4cdf1e7ab0e2ddd2ecc1369etree | snapshot
parenta7160456335b2ce3710efd00658711d431eac0b4commit | diff
Fix sonar for MapEntry

MapEntry bug: make entry private and provide accessors
MapEntry codesmell: move comment 'Required by JAXB' into empty constructor
MapElements codesmell: move explanatory comment inside empty constructor
MapElements codesmell: log error stacktrace
MapAdapter codesmell: use entry set instead of key set for iteration
JAXBMarshallingTest: add test cases to cover 100% of MapElements & other cases

Change-Id: If51f1f86b5ad44b3462424e4fd73cb0eff352124
Issue-ID: SO-1811
Signed-off-by: k.kazak <k.kazak@samsung.com>
adapters/mso-adapters-rest-interface/src/main/java/org/onap/so/openstack/mappers/MapAdapter.java diff | blob | history
adapters/mso-adapters-rest-interface/src/main/java/org/onap/so/openstack/mappers/MapElements.java diff | blob | history
adapters/mso-adapters-rest-interface/src/main/java/org/onap/so/openstack/mappers/MapEntry.java diff | blob | history
adapters/mso-adapters-rest-interface/src/test/java/org/onap/so/openstack/mappers/JAXBMarshallingTest.java diff | blob | history
adapters/mso-adapters-rest-interface/src/test/resources/VfRequest-marshalled-with-complex-object.xml diff | blob | history
Service Orchestrator