Add test coverage to integrity-monitor 45/31645/5
authorJim Hahn <jrh3@att.com>
Tue, 13 Feb 2018 14:19:43 +0000 (09:19 -0500)
committerJim Hahn <jrh3@att.com>
Wed, 14 Feb 2018 00:21:55 +0000 (19:21 -0500)
commitbf2cc29bf766feabca8ef633926f5fce00a5fe2e
tree6094d9294378fe7226a3ed7e287dc0381b067fcf
parent86664073b5a778c56e831d64b3a1883818af0ffe
Add test coverage to integrity-monitor

Removed "test" from package name.
Refactored tests, creating common IntegrityMonitorTestBase.
Turned log/print statements into assertEquals in StateTransitionTest.
Turned log/print statements into assertEquals in StateManagementTest.
Modified AllSeemsWellTest to use IntegrityMonitorTestBase.
Modified IntegrityMonitorTest to use IntegrityMonitorTestBase.
Added several hooks to IntegrityMonitor to control timers at a
finer granularity.
Added hooks to IntegrityMonitor to control the FPManager thread.
Remove hooks for refresh timer, as property suffices.
Added assertException() and assertNoException() methods to
IntegrityMonitorTestBase, and then replaced most "try/catch" blocks
with calls to those methods.
Updated StateManagement to close EntityManagers.
Modify pom to remove scope from utils dependency.
Fix some comments and remove an unneeded EntityTransaction variable.

Change-Id: Ic0789d26f985a40a35f618343fa4e88aa473b2b3
Issue-ID: POLICY-582
Signed-off-by: Jim Hahn <jrh3@att.com>
15 files changed:
integrity-monitor/pom.xml
integrity-monitor/src/main/java/org/onap/policy/common/im/IntegrityMonitor.java
integrity-monitor/src/main/java/org/onap/policy/common/im/StateManagement.java
integrity-monitor/src/main/resources/META-INF/persistence.xml
integrity-monitor/src/test/java/org/onap/policy/common/im/AllSeemsWellTest.java [new file with mode: 0644]
integrity-monitor/src/test/java/org/onap/policy/common/im/ExceptionsTest.java [moved from integrity-monitor/src/test/java/org/onap/policy/common/im/test/ExceptionsTest.java with 98% similarity]
integrity-monitor/src/test/java/org/onap/policy/common/im/IntegrityMonitorTest.java [new file with mode: 0644]
integrity-monitor/src/test/java/org/onap/policy/common/im/IntegrityMonitorTestBase.java [new file with mode: 0644]
integrity-monitor/src/test/java/org/onap/policy/common/im/StateManagementEntityTest.java [new file with mode: 0644]
integrity-monitor/src/test/java/org/onap/policy/common/im/StateManagementTest.java [new file with mode: 0644]
integrity-monitor/src/test/java/org/onap/policy/common/im/StateTransitionTest.java [moved from integrity-monitor/src/test/java/org/onap/policy/common/im/test/StateTransitionTest.java with 67% similarity]
integrity-monitor/src/test/java/org/onap/policy/common/im/test/AllSeemsWellTest.java [deleted file]
integrity-monitor/src/test/java/org/onap/policy/common/im/test/IntegrityMonitorTest.java [deleted file]
integrity-monitor/src/test/java/org/onap/policy/common/im/test/StateManagementEntityTest.java [deleted file]
integrity-monitor/src/test/java/org/onap/policy/common/im/test/StateManagementTest.java [deleted file]