Code Review / policy / models.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: a029cca) | patch
Improve code coverage and sonar fixes 44/138644/8
authorwaynedunican <wayne.dunican@est.tech>
Tue, 23 Jul 2024 08:23:51 +0000 (09:23 +0100)
committerwaynedunican <wayne.dunican@est.tech>
Tue, 13 Aug 2024 07:49:10 +0000 (08:49 +0100)
commitb7804abcf865dc58a01bed3f2be4756e731d9288
tree7f6fc3b50622578bb8612de9fe5e5c6adddfaf28tree | snapshot
parenta029ccab07f2dd71286804da620c513da9fdfc0ecommit | diff
Improve code coverage and sonar fixes

Increased code coverage to 90%
SONAR - Removed TODO comments
SONAR - Added NOSONAR where appropriate
SONAR - Replaced stream.Collect() with stream.toList() where applicable
SONAR - Made variables serializable or transient to comply with sonar rules

Issue-ID: POLICY-5069
Change-Id: Ife256eaf4e6f427fe40b138bacc6f112dc5bcea4
Signed-off-by: waynedunican <wayne.dunican@est.tech>
110 files changed:
models-base/src/main/java/org/onap/policy/models/base/PfConceptFilter.java diff | blob | history
models-base/src/main/java/org/onap/policy/models/base/PfModel.java diff | blob | history
models-base/src/main/java/org/onap/policy/models/base/PfUtils.java diff | blob | history
models-base/src/main/java/org/onap/policy/models/base/PfValidator.java diff | blob | history
models-base/src/main/java/org/onap/policy/models/base/Validated.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/PfReferenceKeyTest.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/PfUtilsTest.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/testconcepts/DummyPfKey.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/testconcepts/DummyPfObjectFilter.java diff | blob | history
models-dao/pom.xml diff | blob | history
models-dao/src/main/java/org/onap/policy/models/dao/impl/DefaultPfDao.java diff | blob | history
models-dao/src/main/java/org/onap/policy/models/dao/impl/ProxyDao.java diff | blob | history
models-dao/src/test/java/org/onap/policy/models/dao/PfFilterParametersTest.java [new file with mode: 0644] blob
models-dao/src/test/java/org/onap/policy/models/dao/impl/PfNonTimestampKeyFilterTest.java [new file with mode: 0644] blob
models-dao/src/test/java/org/onap/policy/models/dao/impl/ProxyDaoTest.java [new file with mode: 0644] blob
models-decisions/pom.xml diff | blob | history
models-decisions/src/test/java/org/onap/policy/models/decisions/concepts/TestDecisionException.java [new file with mode: 0644] blob
models-decisions/src/test/java/org/onap/policy/models/decisions/concepts/TestDecisionRequest.java [new file with mode: 0644] blob
models-decisions/src/test/java/org/onap/policy/models/decisions/serialization/TestDecisionRequestMessageBodyHandler.java [new file with mode: 0644] blob
models-decisions/src/test/java/org/onap/policy/models/decisions/serialization/TestDecisionResponseMessageBodyHandler.java [new file with mode: 0644] blob
models-interactions/model-actors/actor.a1p/src/test/java/org/onap/policy/controlloop/actor/a1p/A1pOperationTest.java diff | blob | history
models-interactions/model-actors/actor.a1p/src/test/java/org/onap/policy/controlloop/actor/a1p/BasicA1pOperation.java diff | blob | history
models-interactions/model-actors/actor.aai/src/test/java/org/onap/policy/controlloop/actor/aai/AaiCustomQueryOperationTest.java diff | blob | history
models-interactions/model-actors/actor.aai/src/test/java/org/onap/policy/controlloop/actor/aai/AaiGetOperationTest.java diff | blob | history
models-interactions/model-actors/actor.aai/src/test/java/org/onap/policy/controlloop/actor/aai/AaiGetPnfOperationTest.java diff | blob | history
models-interactions/model-actors/actor.aai/src/test/java/org/onap/policy/controlloop/actor/aai/AaiGetTenantOperationTest.java diff | blob | history
models-interactions/model-actors/actor.appc/src/test/java/org/onap/policy/controlloop/actor/appc/AppcOperationTest.java diff | blob | history
models-interactions/model-actors/actor.appc/src/test/java/org/onap/policy/controlloop/actor/appc/BasicAppcOperation.java diff | blob | history
models-interactions/model-actors/actor.appc/src/test/java/org/onap/policy/controlloop/actor/appc/ModifyConfigOperationTest.java diff | blob | history
models-interactions/model-actors/actor.appclcm/src/test/java/org/onap/policy/controlloop/actor/appclcm/AppcLcmOperationTest.java diff | blob | history
models-interactions/model-actors/actor.cds/src/test/java/org/onap/policy/controlloop/actor/cds/GrpcActorServiceManagerTest.java diff | blob | history
models-interactions/model-actors/actor.sdnc/src/test/java/org/onap/policy/controlloop/actor/sdnc/BandwidthOnDemandOperationTest.java diff | blob | history
models-interactions/model-actors/actor.sdnc/src/test/java/org/onap/policy/controlloop/actor/sdnc/BasicSdncOperation.java diff | blob | history
models-interactions/model-actors/actor.sdnr/src/test/java/org/onap/policy/controlloop/actor/sdnr/BasicSdnrOperation.java diff | blob | history
models-interactions/model-actors/actor.sdnr/src/test/java/org/onap/policy/controlloop/actor/sdnr/SdnrOperationTest.java diff | blob | history
models-interactions/model-actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/RestManagerResponse.java diff | blob | history
models-interactions/model-actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/VfModuleDelete.java diff | blob | history
models-interactions/model-actors/actor.so/src/test/java/org/onap/policy/controlloop/actor/so/ModifyCllTest.java diff | blob | history
models-interactions/model-actors/actor.so/src/test/java/org/onap/policy/controlloop/actor/so/ModifyNssiTest.java diff | blob | history
models-interactions/model-actors/actor.so/src/test/java/org/onap/policy/controlloop/actor/so/SoOperationTest.java diff | blob | history
models-interactions/model-actors/actor.so/src/test/java/org/onap/policy/controlloop/actor/so/VfModuleCreateTest.java diff | blob | history
models-interactions/model-actors/actor.so/src/test/java/org/onap/policy/controlloop/actor/so/VfModuleDeleteTest.java diff | blob | history
models-interactions/model-actors/actor.test/src/main/java/org/onap/policy/controlloop/actor/test/BasicOperation.java diff | blob | history
models-interactions/model-actors/actor.test/src/test/java/org/onap/policy/controlloop/actor/test/BasicBidirectionalTopicOperationTest.java diff | blob | history
models-interactions/model-actors/actor.test/src/test/java/org/onap/policy/controlloop/actor/test/BasicHttpOperationTest.java diff | blob | history
models-interactions/model-actors/actor.test/src/test/java/org/onap/policy/controlloop/actor/test/BasicOperationTest.java diff | blob | history
models-interactions/model-actors/actor.vfc/src/test/java/org/onap/policy/controlloop/actor/vfc/VfcOperationTest.java diff | blob | history
models-interactions/model-actors/actor.xacml/src/test/java/org/onap/policy/controlloop/actor/xacml/DecisionOperationTest.java diff | blob | history
models-interactions/model-actors/actor.xacml/src/test/java/org/onap/policy/controlloop/actor/xacml/GuardOperationTest.java diff | blob | history
models-interactions/model-actors/actor.xacml/src/test/java/org/onap/policy/controlloop/actor/xacml/XacmlActorTest.java diff | blob | history
models-interactions/model-actors/actorServiceProvider/src/main/java/org/onap/policy/controlloop/actorserviceprovider/impl/BidirectionalTopicOperation.java diff | blob | history
models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/impl/BidirectionalTopicActorTest.java diff | blob | history
models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/impl/BidirectionalTopicOperationTest.java diff | blob | history
models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/impl/HttpOperationTest.java diff | blob | history
models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/impl/HttpPollingOperationTest.java diff | blob | history
models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/impl/HttpPollingOperatorTest.java diff | blob | history
models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/impl/OperationPartialTest.java diff | blob | history
models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/pipeline/PipelineControllerFutureTest.java diff | blob | history
models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/topic/ForwarderTest.java diff | blob | history
models-interactions/model-impl/aai/src/main/java/org/onap/policy/aai/AaiCqResponse.java diff | blob | history
models-interactions/model-impl/aai/src/main/java/org/onap/policy/aai/AaiManager.java diff | blob | history
models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/CommonHeaderTest.java diff | blob | history
models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/RequestTest.java diff | blob | history
models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/ResponseStatusTest.java diff | blob | history
models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/ResponseTest.java diff | blob | history
models-interactions/model-impl/cds/src/test/java/org/onap/policy/cds/client/CdsProcessorGrpcClientTest.java diff | blob | history
models-interactions/model-impl/events/src/main/java/org/onap/policy/controlloop/ControlLoopEvent.java diff | blob | history
models-interactions/model-impl/events/src/main/java/org/onap/policy/controlloop/VirtualControlLoopEvent.java diff | blob | history
models-interactions/model-impl/events/src/test/java/org/onap/policy/controlloop/ControlLoopOperationTest.java diff | blob | history
models-interactions/model-impl/rest/src/test/java/org/onap/policy/rest/HttpDeleteWithBodyTest.java diff | blob | history
models-interactions/model-impl/rest/src/test/java/org/onap/policy/rest/RestTest.java diff | blob | history
models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciCommonHeaderTest.java diff | blob | history
models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciRequestTest.java diff | blob | history
models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciRequestWrapperTest.java diff | blob | history
models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciResponseTest.java diff | blob | history
models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciResponseWrapperTest.java diff | blob | history
models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciStatusTest.java diff | blob | history
models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciWrapperTest.java diff | blob | history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoRequestDetailsTest.java diff | blob | history
models-interactions/model-impl/so/src/test/java/org/onap/policy/so/SoResponseWrapperTest.java diff | blob | history
models-interactions/model-simulators/src/test/java/org/onap/policy/simulators/CdsSimulatorTest.java diff | blob | history
models-pap/src/main/java/org/onap/policy/models/pap/concepts/PdpDeployPolicies.java diff | blob | history
models-pdp/src/main/java/org/onap/policy/models/pdp/concepts/PdpGroupFilter.java diff | blob | history
models-pdp/src/main/java/org/onap/policy/models/pdp/concepts/PdpGroups.java diff | blob | history
models-pdp/src/main/java/org/onap/policy/models/pdp/concepts/PdpUpdate.java diff | blob | history
models-pdp/src/main/java/org/onap/policy/models/pdp/persistence/provider/PdpFilterParameters.java diff | blob | history
models-pdp/src/main/java/org/onap/policy/models/pdp/persistence/provider/PdpProvider.java diff | blob | history
models-pdp/src/test/java/org/onap/policy/models/pdp/persistence/provider/PdpFilterParametersTest.java diff | blob | history
models-pdp/src/test/java/org/onap/policy/models/pdp/persistence/provider/PdpProviderTest.java diff | blob | history
models-provider/pom.xml diff | blob | history
models-provider/src/test/java/org/onap/policy/models/provider/PolicyModelsProviderFactoryTest.java diff | blob | history
models-provider/src/test/java/org/onap/policy/models/provider/impl/AbstractModelsProviderTest.java [new file with mode: 0644] blob
models-provider/src/test/java/org/onap/policy/models/provider/impl/DatabasePolicyModelsProviderTest.java diff | blob | history
models-provider/src/test/java/org/onap/policy/models/provider/impl/DbPolicyModelsProviderImplTest.java [new file with mode: 0644] blob
models-provider/src/test/java/org/onap/policy/models/provider/impl/PolicyToscaPersistenceTest.java diff | blob | history
models-sim/policy-models-sim-pdp/src/test/java/org/onap/policy/models/sim/pdp/TestPdpSimulatorConstants.java diff | blob | history
models-sim/policy-models-simulators/src/main/java/org/onap/policy/models/simulators/Main.java diff | blob | history
models-tosca/pom.xml diff | blob | history
models-tosca/src/main/java/org/onap/policy/models/tosca/authorative/concepts/ToscaEntityFilter.java diff | blob | history
models-tosca/src/main/java/org/onap/policy/models/tosca/authorative/concepts/ToscaTypedEntityFilter.java diff | blob | history
models-tosca/src/main/java/org/onap/policy/models/tosca/authorative/provider/AuthorativeToscaProvider.java diff | blob | history
models-tosca/src/main/java/org/onap/policy/models/tosca/simple/concepts/JpaToscaPolicyType.java diff | blob | history
models-tosca/src/test/java/org/onap/policy/models/tosca/authorative/concepts/ToscaEntityFilterTest.java diff | blob | history
models-tosca/src/test/java/org/onap/policy/models/tosca/authorative/provider/AuthorativeToscaProviderGenericTest.java diff | blob | history
models-tosca/src/test/java/org/onap/policy/models/tosca/authorative/provider/AuthorativeToscaProviderPolicyTypeTest.java diff | blob | history
models-tosca/src/test/java/org/onap/policy/models/tosca/simple/concepts/JpaToscaCapabilityAssignmentsTest.java [new file with mode: 0644] blob
models-tosca/src/test/java/org/onap/policy/models/tosca/simple/concepts/JpaToscaCapabilityTypeTest.java [new file with mode: 0644] blob
models-tosca/src/test/java/org/onap/policy/models/tosca/simple/concepts/JpaToscaRequirementTest.java [new file with mode: 0644] blob
models-tosca/src/test/java/org/onap/policy/models/tosca/simple/provider/SimpleToscaProviderTest.java diff | blob | history
models-tosca/src/test/java/org/onap/policy/models/tosca/simple/serialization/OptimizationPolicyTypeSerializationTest.java diff | blob | history
This repo will hold model code agnostic to PDP engines (Casablanca)